From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145511672315904 X-Received: by 10.223.153.226 with SMTP id y89mr121081wrb.18.1504861400966; Fri, 08 Sep 2017 02:03:20 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.152.136 with SMTP id a130ls246789wme.19.gmail; Fri, 08 Sep 2017 02:03:20 -0700 (PDT) X-Google-Smtp-Source: ADKCNb70HvcuumIVuJ12WtrbPqDpTNxGceYF5cRpUu/rw0Jgf76UvmmFYLGcYZ4/xGx2Mqd5vUNJ X-Received: by 10.223.150.118 with SMTP id c51mr130774wra.20.1504861400726; Fri, 08 Sep 2017 02:03:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504861400; cv=none; d=google.com; s=arc-20160816; b=Z5M5vHjuxQ1t/9/6i7hriVenTkMvpnN7EaEDnyoz1HxjZUMI1Lfmwgekqkq7F4Z0N9 ILwMh/OQmIjsUHvM/ELh+Ki4VSvJyUk50GWtQ1vVyw7GkBzXfDUCc+FDjkpTc26tKCit ZzZa2o05x/eNd4t7XbDlIx8nTNm5Dc6A3Os+gZwCZQj7EthZsy9Uef6zUpWb0CBgpiJ6 ncd9dNDkFw6mlS3Wy5fC0Ye2Kn2CBgUUn+WXZCjhzwFgUW5Dt6d22iTr1VRcPCVS1kN+ Zk5jL+LTmovaGfKKPzt/ugV+uVjMXjY7yFrQMs2mrCpkkycF4z9G1ut07TFSt8CBT9gG DCFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=6qoEhoxyRR0+KgY6jRSCn8JNizABhl3REqwWYr8YrAU=; b=Wen98iw9V0NINK2Jri5y19b7BbB/WHZpOQXUtMmBzHCY+srJ/paHVEpQIHrfG9LIs0 wSCy72R/HOuJqKivEEpOg+Y+fva/ingvM6kPMILr+l3z9v3ScH12BbSUQ7lIM1cUgP6e 6D5zvR6Itq27gh9OIZ5NWhHnE+zlQFS1viuzTke3dnxQFFnIqR3jNbDGL8vZV4QJWIz1 +Z7v5ikCpWzQfkjRmlsyvBrqYypllDCV4vy2r3n4RI8Wv473DAK/fkE8oKZACJDHHIHr prqzZJt2sVVwdlI9XyJ+CdsUSDc1ylBJBZ8WLDs+Fw3qDI3zmIgyCPr8PXhIv7mYRqMS Q7sQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id b62si63388wmd.3.2017.09.08.02.03.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Sep 2017 02:03:20 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v8893JtK013945 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Sep 2017 11:03:19 +0200 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v8893JsX014825; Fri, 8 Sep 2017 11:03:19 +0200 Date: Fri, 8 Sep 2017 11:03:28 +0200 From: Henning Schild To: Claudius Heine Cc: Alexander Smirnov , Claudius Heine , Subject: Re: [PATCH 1/6] meta/dpkg: Make 'do_unpack' more generic, prepare for pulling out Message-ID: <20170908110328.776e15a8@md1em3qc> In-Reply-To: References: <6f7b53c5-3238-1d8d-88a7-7afc3859a9ec@ilbers.de> <62849b3a-fd2f-3184-ace0-0941fd3f9325@siemens.com> <20170908103057.34462bf1@md1em3qc> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: +xraA6lHAqUf Am Fri, 8 Sep 2017 10:44:29 +0200 schrieb Claudius Heine : > Hi, > > On 08.09.2017 10:30, Henning Schild wrote: > > Am Tue, 5 Sep 2017 10:37:48 +0300 > > schrieb Alexander Smirnov : > > > >> Hi, > >> > >>>> On 09/04/2017 05:11 PM, Alexander Smirnov wrote: > >>>>> On 08/30/2017 10:03 PM, Henning Schild wrote: > >>>>>> Issue: > >>>>>> The unpacker in dpkg is not generic since it does not unpack to > >>>>>> WORKDIR, so it can not be pulled into a more generic class to > >>>>>> make it available for other users. > >>>>>> > >>>>> > >>>>> As I already wrote to mail-list, WORKDIR and BUILDROOT are > >>>>> different folders, and there was the reason to do so. > >>>> > >>>> Yes we (Henning and I) get that. That is the reason why the > >>>> patch includes the line: > >>>> > >>>> +WORKDIR_task-unpack = "${BUILDROOT}" > >>>> > >>>> That means that only for the unpack task in the dpkg.bbclass the > >>>> variable WORKDIR is set to the BUILDROOT variable. This makes > >>>> the unpack step more generic so that it can be moved to the base > >>>> class. Essentially removing the dependency of the unpack task to > >>>> the dpkg class. > >>> > >>> Does this mean that "log.do_unpack" and "run.do_unpack" will be > >>> stored in buildchroot? Let me check this. > >>> > >> > >> Yes it does: > >> > >> ls > >> isar/build/tmp/work/buildchroot/debian-wheezy-armhf/rootfs/home/builder/hello/temp/ > >> > >> log.do_unpack > >> log.do_unpack.19557 > >> log.task_order > >> run.do_unpack > >> run.do_unpack.19557 > >> > >> While it's assumed that they should be stored in: > >> isar/build/tmp/work/hello-0.1+g7f35942-1-r0/temp/ > > > > I think i am starting to understand the whole problem with the > > WORKDIR and the BUILDROOT better. Instead of the unpacking to > > BUILDROOT or messing with WORKDIR i think we should have a new task > > after do_unpack > > > > So instead of do_unpack -> BUILDROOT > > > > do_unpack archive -> WORKDIR > > do_copy_to_buildroot WORKDIR -> BUILDROOT > > > > That should keep all the logs in an unmodified WORKDIR and the > > unpacker would always extract to there. Classes that need the files > > to live in BUILDROOT would have to include the task > > do_copy_to_buildroot. > > I agree with that separating those into two tasks is the better > solution, but I don't like the 'copy_to_buildroot' name, because it > limits possible implementations of this task by that name. For > instance you could, and maybe even should, use a bind mount instead > of copying the files around. > > Something like "populate" or "prepare" as a prefix sounds a bit > better IMO. Agreed, i will think of a better name. Henning > Cheers, > Claudius >