From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6463342265335021568 X-Received: by 10.25.196.138 with SMTP id u132mr210449lff.20.1504870132704; Fri, 08 Sep 2017 04:28:52 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.42.91 with SMTP id f88ls64446lfl.42.gmail; Fri, 08 Sep 2017 04:28:52 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCwQBrc9bVdICsZzpUPfWfAlee+NStcifOkbfLT+EUyawfnkPgLmQjM8XcCux9NEpb+hL5n X-Received: by 10.25.196.138 with SMTP id u132mr210448lff.20.1504870132161; Fri, 08 Sep 2017 04:28:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504870132; cv=none; d=google.com; s=arc-20160816; b=nNihwqxzc/fIgRjad5XUFlIPOPM6p+XRdxkv3YvSjix6Dt14I7qhA5Qi5ReQHl7N1v /zu+txCzQ+LGr5LtSX+Xb7NNVYuMhQdlQEpqiqG22zewr93gx4gj8ZyuJC7YdMFzfTAv RJYyOw/mauwILAnNoon67dRtau7g9lrwvJWz1IglNMfT9dvD28pxSZgM9fy4YWRHizAj CU2HOkzWz1jf2Gyr5IhQEBB17qGGcC0xZq4PTpKVOKawfr2jGGfx9LT8XKQ+ITmX5Sf6 dmGEVrajQ4IipLLU3HYm9b3K3nDuGND/+ivI4v02wEi+sDioUK5gwL4q1zQhFEUe7d0e 3K2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=o7DPCHDZ+mNu4sAmodiGaZwoM2UQkM8Z9JR2uJalJaY=; b=EytJn6990lJMsyqzZiIG7i6fO3Md/RIh3653gUd5Nhq/1lYWMXPcQfve6VyD3L2/XW jH0NT/4qcECSA2QBUuqSB+z/HiN0X4lg/YlSpWpZE10ZqEWM7ShXRC+MQUl6xii/JtTM pRCs+MoibO/5ot7SrNE6YaZA/36gNo5FabIitvCP1PK2b1TWFjWoNbs8cspXom1xnvxW 54QyqGGVMNIkoDHzehSN1idOsRYVj8qCvU93kAKUBp1HfgEzFD5NuHNR0bu1hw3eihSi IhGPd+L8W0WB8HSwsnWMoam5RN0PmmWgfIXlCjvRT6xWzG2oJE+A6AwU/Mj9npKkq8jE EUCg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id r3si95176wmg.6.2017.09.08.04.28.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Sep 2017 04:28:52 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v88BSpfT007411 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Sep 2017 13:28:51 +0200 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v88BSpx3012622; Fri, 8 Sep 2017 13:28:51 +0200 Date: Fri, 8 Sep 2017 13:29:00 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 2/2] class/dpkg: Unify workplace for packages Message-ID: <20170908132900.1d5a2b95@md1em3qc> In-Reply-To: <20170908094834.26496-3-asmirnov@ilbers.de> References: <20170908094834.26496-1-asmirnov@ilbers.de> <20170908094834.26496-3-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: S+MiBn6qHoNz Am Fri, 8 Sep 2017 12:48:34 +0300 schrieb Alexander Smirnov : > Get rid of splitting package's data between WORKDIR and BUILDCHROOT. > Now everything is stored into WORKDIR, and BUILDCHROOT is used for > compilation only. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/dpkg.bbclass | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 360a95c..f1a29aa 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -3,12 +3,11 @@ > > # Add dependency from buildchroot creation > DEPENDS += "buildchroot" > -do_unpack[deptask] = "do_build" > +do_build[deptask] = "do_build" > > # Each package should have its own unique build folder, so use > # recipe name as identifier > PP = "/home/builder/${PN}" > -BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" > > do_fetch[dirs] = "${DL_DIR}" > > @@ -27,9 +26,8 @@ python do_fetch() { > > addtask fetch before do_unpack > > -do_unpack[dirs] = "${BUILDROOT}" > +do_unpack[dirs] = "${WORKDIR}" > do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > -S ?= "${BUILDROOT}" > > # Unpack package and put it into working directory in buildchroot > python do_unpack() { > @@ -37,7 +35,7 @@ python do_unpack() { > if len(src_uri) == 0: > return > > - rootdir = d.getVar('BUILDROOT', True) > + rootdir = d.getVar('WORKDIR', True) > > try: > fetcher = bb.fetch2.Fetch(src_uri, d) > @@ -48,17 +46,22 @@ python do_unpack() { > > addtask unpack after do_fetch before do_build > > +BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" > do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > # Build package from sources using build script > do_build() { > + mkdir -p ${BUILDROOT} > + sudo mount --bind ${WORKDIR} ${BUILDROOT} > sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} > + sudo umount ${BUILDROOT} > + rm -rf ${BUILDROOT} > } Sweet, that seems to be going into the right direction. We do not unpack to BUILDROOT anymore but rather make sure what is unpacked to WORKDIR becomes visible in BUILDROOT for the build. Seems like what i suggested in one of my last mails. I think that would finally allow to move fetch and unpack out of dpkg. Henning > # Install package to dedicated deploy directory > do_install() { > - install -m 644 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ > + install -m 644 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > } > > addtask install after do_build