From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6463342265335021568 X-Received: by 10.28.142.212 with SMTP id q203mr959859wmd.29.1505148464858; Mon, 11 Sep 2017 09:47:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.85.22 with SMTP id j22ls333421ljb.33.gmail; Mon, 11 Sep 2017 09:47:44 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBZ9sr6KLtoIciIf3U8W+stayC4urnLKux7vhxENDT4wvV+ddm11NtuYTccJ2a7czw+RXAL X-Received: by 10.25.169.1 with SMTP id s1mr915772lfe.29.1505148464404; Mon, 11 Sep 2017 09:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505148464; cv=none; d=google.com; s=arc-20160816; b=UbRYimPs4WgHoDldHqhAqNfAd/Tj0CESAPnD4krj0ZSQ1+anWMcnXcIARue7hzRA9N YXrCY0f9WHXqzEwCztsLUjAO6XCV97ONOCjaD9D4s2bsNhGp+PS+9FfeQ3s+hw70sLaJ NBJLUXTFF4zYq8UPApvlRSlLpm7/JVTMqIM4wT4h2ABOv096cvEqabpaIdYBRrtskViD PW9jEB+l8sK+4IvNw+W2+j/NwbokyIWy2ufmxtwgOPUIh4LseaBZHDjnelsN07GI/DSS oyrVPDxK3zRCqfP1covUkjFctMzCpbd8mWeZ7bZf+ZpzETlVZhxIEVmbmX7cCZJwbYtW U5Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=QwWFsjh9jJ7gJeXoTd8TIZ71dM5KZt4qaP7KpF/2uYo=; b=nEQ0fH6+874yVZV95kI5C6ZnqrjR6wJX53mCabvMkzCUJc3glcHgwpKWGjqg3h4zvZ CcFhR08Su5vcyjjjme8/pYBMlQ4A8xMcsHI1+B0ti5T1GStSGvApMFahjgg6FO4TkbXK tyHC1kNEm9K1pTgksyefKf0byHYKvivR1xkg4MyVdKjU/kb2lSDsxA9UT3ex9/vcxnd/ Knyv6GacKT4QpfNFZT2zfula2OaNJLlfmIX9URUqT5AMjXmrEXJ+OwltmitNqI36+9G9 xxUFwpqOLnFdZmaow9JE7/tIMJnQyMoAS7844fkAvGVUgsFX3gfThlkE25+Y3lIOU8IQ bnfw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id 74si642804wmf.8.2017.09.11.09.47.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2017 09:47:44 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v8BGli9d003830 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Sep 2017 18:47:44 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v8BGlhhp020888; Mon, 11 Sep 2017 18:47:43 +0200 Date: Mon, 11 Sep 2017 18:47:55 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH v2 5/5] class/dpkg: Unify workplace for packages Message-ID: <20170911184755.45159d91@md1em3qc> In-Reply-To: <20170908155606.7654-6-asmirnov@ilbers.de> References: <20170908155606.7654-1-asmirnov@ilbers.de> <20170908155606.7654-6-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: swdJfpRdn+eW Am Fri, 8 Sep 2017 18:56:06 +0300 schrieb Alexander Smirnov : > Get rid of splitting package's data between WORKDIR and BUILDCHROOT. > Now everything is stored into WORKDIR, and BUILDCHROOT is used for > compilation only. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/dpkg.bbclass | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 360a95c..f1a29aa 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -3,12 +3,11 @@ > > # Add dependency from buildchroot creation > DEPENDS += "buildchroot" > -do_unpack[deptask] = "do_build" > +do_build[deptask] = "do_build" > > # Each package should have its own unique build folder, so use > # recipe name as identifier > PP = "/home/builder/${PN}" > -BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" > > do_fetch[dirs] = "${DL_DIR}" > > @@ -27,9 +26,8 @@ python do_fetch() { > > addtask fetch before do_unpack > > -do_unpack[dirs] = "${BUILDROOT}" > +do_unpack[dirs] = "${WORKDIR}" > do_unpack[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > -S ?= "${BUILDROOT}" > > # Unpack package and put it into working directory in buildchroot > python do_unpack() { > @@ -37,7 +35,7 @@ python do_unpack() { > if len(src_uri) == 0: > return > > - rootdir = d.getVar('BUILDROOT', True) > + rootdir = d.getVar('WORKDIR', True) This change is in conflict with the comment, please fix the comment of do_unpack. Henning > try: > fetcher = bb.fetch2.Fetch(src_uri, d) > @@ -48,17 +46,22 @@ python do_unpack() { > > addtask unpack after do_fetch before do_build > > +BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" > do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > # Build package from sources using build script > do_build() { > + mkdir -p ${BUILDROOT} > + sudo mount --bind ${WORKDIR} ${BUILDROOT} > sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} > + sudo umount ${BUILDROOT} > + rm -rf ${BUILDROOT} > } > > > # Install package to dedicated deploy directory > do_install() { > - install -m 644 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ > + install -m 644 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > } > > addtask install after do_build