From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6464921707679318016 X-Received: by 10.28.215.195 with SMTP id o186mr120247wmg.9.1505376658951; Thu, 14 Sep 2017 01:10:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.216.78 with SMTP id p75ls1336396wmg.15.canary-gmail; Thu, 14 Sep 2017 01:10:58 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDpRHDkUX0BdUxVQzv7lGZsxbu4vWvfIFZYiJ+T8M4eLytSYAcEXmNJQ3mVu2bFL4LYH7fF X-Received: by 10.28.6.76 with SMTP id 73mr112945wmg.26.1505376658575; Thu, 14 Sep 2017 01:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505376658; cv=none; d=google.com; s=arc-20160816; b=eeHcEKwRKfsD4l05kMxIPE1imLLtLK4FdRieEauLFKpik9ZzQs0NnM54E1nldWOyjs O74+0UGjbGMuPTlh4Xdhw0oW9wA1i1+BN283a8u6zoCROwR1Nq9KHNZK+ZkyBnxKrtL5 2rSGnI6QZAVTb9HPeeZ3YQILvCVyKA03woQQ5ibZtRYI9dmShd6YBzoTpUHHSjk3zse8 MFljP9phs+jcDhybRRK6HJMuv6Kf6f+qdMe5n5eREySeZ8ApoIf/4oezFqfCJwwp7ZmG DIrOJIRHF8NwDHJ8PrSJv1XNDvVlhudK3JYhpFtMYv1qbGV/fFx6zYRONWouIrR8ak97 CP8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=0ineoEncKWWTNi6G+wuVPlQmmZ1VRAISBnUrVtAmyrA=; b=PVqw68r8ZMT232N39KRCXltGH6bZvn0J3wpkRpvTJpWQO8D/+RwwLqeYggcQWWPMza JGzBnpgtAIeJoaorqfz8mhBaitDa2TdaNF9bLwpS0tzjkcSIZMmw+X8fpLc+PzxpsfMP yoZvxzrYkyZArZY1mEzcb7vKWQNga/BNg6TEddXKTW+dcUKCY9t5dWsYUbObhvUMqn9F tcfEF1fQBXGD1uNPJyLvn2f2zlKhYm8Q4rNrFVEUsnB/RHv8/YJ/ZDcwcyI9OclGIscR ULFjuNmzHr5pYEW2H+rJf13BDB/QxnR7D+V86dsjOzX3gJDelgbcIgV/I7FWhze5Xq4F cEDQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id c142si67156wmh.3.2017.09.14.01.10.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Sep 2017 01:10:58 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v8E8AvBD006047 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Sep 2017 10:10:57 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v8E8AvKO005766; Thu, 14 Sep 2017 10:10:57 +0200 Date: Thu, 14 Sep 2017 10:11:09 +0200 From: Henning Schild To: Alexander Smirnov Cc: Andreas Reichel , , Claudius Heine Subject: Re: [PATCH v2 6/6] recipes-app/example-raw: add an example on how to use dpkg-raw Message-ID: <20170914101109.1c4123d9@md1em3qc> In-Reply-To: References: <20170912155810.9434-1-henning.schild@siemens.com> <20170912155810.9434-7-henning.schild@siemens.com> <20170913113934.GA15762@iiotirae> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: F00lhBMIKZ1/ Am Thu, 14 Sep 2017 10:28:36 +0300 schrieb Alexander Smirnov : > On 09/13/2017 02:39 PM, Andreas Reichel wrote: > > On Tue, Sep 12, 2017 at 05:58:10PM +0200, [ext] Henning Schild > > wrote: > >> Issue: > >> It might not be clear to a user how to make use of the class > >> dpkg-raw. > >> > >> Change: > >> Add an example that demonstrates some features. > >> > >> Impact: > >> This patch does not change the behaviour of Isar. It addresses the > >> issue partially, documentation would also be useful. > >> > >> Signed-off-by: Henning Schild > >> --- > >> .../recipes-app/example-raw/example-raw_0.1.bb | 35 > >> ++++++++++++++++++++++ > >> meta-isar/recipes-app/example-raw/files/README | 1 + > >> meta-isar/recipes-app/example-raw/files/postinst | 16 ++++++++++ > >> 3 files changed, 52 insertions(+) create mode 100644 > >> meta-isar/recipes-app/example-raw/example-raw_0.1.bb create mode > >> 100644 meta-isar/recipes-app/example-raw/files/README create mode > >> 100644 meta-isar/recipes-app/example-raw/files/postinst > >> > >> diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.1.bb > >> b/meta-isar/recipes-app/example-raw/example-raw_0.1.bb new file > >> mode 100644 index 0000000..d548465 > >> --- /dev/null > >> +++ b/meta-isar/recipes-app/example-raw/example-raw_0.1.bb > >> @@ -0,0 +1,35 @@ > >> +# Sample application using dpkg-raw, which turns a folder (${D}) > >> of +# files into a .deb > >> +# > >> +# This software is a part of ISAR. > >> + > >> +DESCRIPTION = "Sample application for ISAR" > >> +MAINTAINER = "Your name here " > >> +DEBIAN_DEPENDS = "apt" > >> + > >> +SRC_URI = "file://README \ > >> + file://postinst" > >> + > >> +inherit dpkg-raw > >> + > >> +do_populate_package() { > >> + bbnote "Creating ${PN} binary" > >> + echo "#!/bin/sh" > ${WORKDIR}/${PN} > >> + echo "echo Hello ISAR! ${PN}_${PV}" >> ${WORKDIR}/${PN} > > > > Maybe "Creating executable content"? Nowhere a binary is created... > > > > Any other comments? > > >> + > >> + bbnote "Putting ${PN} into package" > >> + install -v -d ${D}/usr/local/bin/ > >> + install -v -m 755 ${WORKDIR}/${PN} > >> ${D}/usr/local/bin/${PN} > >> + > > Maybe "Packaging ${PN}" ? > > > >> + bbnote "Now copy ${FILESDIR}/README into package" > >> + install -v -d ${D}/usr/local/doc/ > >> + install -v -m 644 ${WORKDIR}/README > >> ${D}/usr/local/doc/README-${P} + > >> + bbnote "Now for a debian hook, see dpkg-deb" > >> + install -v -m 755 ${WORKDIR}/postinst ${D}/DEBIAN/postinst > >> + > >> + bbnote "Now for a fake config file" > > > > Maybe "Generating config file" > > And here... These comments are mostly a matter of taste. I did not react because i did not want such tiny changes to hold up the series. I would be ok with the strings as they are. Alex please tell me what you think and Andreas please tell me if you are stricly against the current strings. Henning > Alex > > > > > Kind regards > > Andreas > >> + echo "# empty config file" > ${WORKDIR}/${PN}.conf > >> + install -v -d ${D}/usr/local/etc/ > >> + install -v -m 644 ${WORKDIR}/${PN}.conf > >> ${D}/usr/local/etc/${PN}.conf +} > >> diff --git a/meta-isar/recipes-app/example-raw/files/README > >> b/meta-isar/recipes-app/example-raw/files/README new file mode > >> 100644 index 0000000..6e2ce0f > >> --- /dev/null > >> +++ b/meta-isar/recipes-app/example-raw/files/README > >> @@ -0,0 +1 @@ > >> +This is an example file that we get from FILESDIR in recipe. > >> diff --git a/meta-isar/recipes-app/example-raw/files/postinst > >> b/meta-isar/recipes-app/example-raw/files/postinst new file mode > >> 100644 index 0000000..a28afa3 > >> --- /dev/null > >> +++ b/meta-isar/recipes-app/example-raw/files/postinst > >> @@ -0,0 +1,16 @@ > >> +#!/bin/sh > >> + > >> +set -e > >> + > >> +if ! getent group isar >/dev/null; then > >> + addgroup --quiet --system isar > >> +fi > >> + > >> +if ! getent passwd isar >/dev/null; then > >> + useradd --system --gid isar --create-home \ > >> + --home /var/lib/isar --no-user-group \ > >> + --comment "My isar user" \ > >> + isar > >> +fi > >> + > >> +chown -R isar:isar /var/lib/isar > >> -- > >> 2.13.5 > >> > >> -- > >> You received this message because you are subscribed to the Google > >> Groups "isar-users" group. To unsubscribe from this group and stop > >> receiving emails from it, send an email to > >> isar-users+unsubscribe@googlegroups.com. To post to this group, > >> send email to isar-users@googlegroups.com. To view this discussion > >> on the web visit > >> https://groups.google.com/d/msgid/isar-users/20170912155810.9434-7-henning.schild%40siemens.com. > >> For more options, visit https://groups.google.com/d/optout. > > >