From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6464921707679318016 X-Received: by 10.28.212.14 with SMTP id l14mr129489wmg.11.1505377886928; Thu, 14 Sep 2017 01:31:26 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.85.199 with SMTP id g68ls367007lje.46.gmail; Thu, 14 Sep 2017 01:31:26 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBjOK6VncyLPXDX6QMCmjWF6nOFieInf8d2t4b2Hy5Tj30UMpTlkj1/Ub4K72SdDzrJo0Q4 X-Received: by 10.46.8.74 with SMTP id g10mr1673962ljd.27.1505377856302; Thu, 14 Sep 2017 01:30:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505377856; cv=none; d=google.com; s=arc-20160816; b=cBljBGJOYV/DiZilArowGxwBptrS8kfgH4KDA4k/1lPC7iOu+NYN7gnOZ8uAeH6tr3 6/eG6zLyFAl/XSLvdroVPmpdR1NNZM66Z7BoEGbWxjgt0HJl8DqDTKW9OSJzuuNNM95z oQIrQVuUsjHLuogw37UnCfJaoY5wjR9wWfuEVxXfG97uMKipwi3fWk3lCBoATKEcChqG QeCq1m/bbvQ0LdjyBH/BrP3+/8fTH667q5VDU0P+wEA+4x+aaCv9kSeXNTv6MKVFIHUq W5Z023DfLKiqpIZ/ZElk4xGQyfV4J3vE2aza6iMnOEFvE2aK1CxJ0PgXBmwskLuVc/do RU9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=9dPJUhi7kaQA42LgnPt2Z01t/BBOZBaApbvWb0BQ6Bg=; b=sQY4t3TZAxuMq7JlZLFbdpMApZcrQZctdV1Phux+ydhtQd8j8SUAWbcOCMTBC1FYwx uyIeZ/XlC5kNUb/yPx9m/aMRml4QKtOAq8o1Q/1IAj7SNJfqCtzEbzdEsd5BJa94zCPg +rYvYcBWNA5FLqhj06t8Hk+0Xv4mPyK3ozvOrXTkfqO5JsShV0CwxMjHPWtZ/ZKUkvXI clsPY9PEWGN5jujOwcOEichUrWZE/aJLTDzl1zmWDliITVBgDTNjFlalbSGgtORYr9Gy Ko1zZe+cvrJ6yMxQmQ7WUomn+yhI7xEMpb4K/mQZoYahW4GXQAm0fV8VcWFVrjxLRuly kmMQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id q145si52220wme.4.2017.09.14.01.30.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Sep 2017 01:30:56 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v8E8UtOk009584 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Sep 2017 10:30:55 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v8E8UtcI025719; Thu, 14 Sep 2017 10:30:55 +0200 Date: Thu, 14 Sep 2017 10:31:08 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH][FYI] dpkg-raw: Allow multiconfig build Message-ID: <20170914103108.5339a155@md1em3qc> In-Reply-To: <0d4f7101-2608-dd43-443d-516aecb54943@ilbers.de> References: <20170912155810.9434-1-henning.schild@siemens.com> <20170913150020.9927-1-asmirnov@ilbers.de> <0d4f7101-2608-dd43-443d-516aecb54943@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 65DuSFzMWFZB Am Wed, 13 Sep 2017 18:09:32 +0300 schrieb Alexander Smirnov : > P.S. all the multiconfig builds have been completed, no more issues > found. Sweet, thanks for finding and fixing these issues. I will look into the whole multiconfig story and test future changes on more than one config. Henning > On 09/13/2017 06:00 PM, Alexander Smirnov wrote: > > Add suffixes to stamps for tasks defined in dpkg-raw class. This > > allows to use multiconfig. > > > > 8<-- > > > > If I build Isar using command: > > > > $ bitbake multiconfig:qemuarm-wheezy:isar-image-base > > multiconfig:qemuarm-jessie:isar-image-base > > > > There will be the following stamps created: > > > > 1. Without this patch: > > > > $ ls -1 tmp/stamps > > > > ... > > example-raw-0.1-r0.do_build.raspbian-jessie-armhf > > example-raw-0.1-r0.do_deb_package_conffiles > > example-raw-0.1-r0.do_deb_package_prepare > > example-raw-0.1-r0.do_fetch > > example-raw-0.1-r0.do_populate_package > > ... > > [example for hello package]: > > hello-1.0-r0.do_build.debian-jessie-armhf > > hello-1.0-r0.do_build.debian-wheezy-armhf > > hello-1.0-r0.do_fetch > > hello-1.0-r0.do_unpack.debian-jessie-armhf > > hello-1.0-r0.do_unpack.debian-wheezy-armhf > > ... > > > > In this case, the "example-raw" package will be processed only > > once, so for all the other architectures bitbake will ignore tasks > > execution. > > > > 2. With this patch: > > > > ... > > example-raw-0.1-r0.do_build.debian-jessie-armhf > > example-raw-0.1-r0.do_build.debian-wheezy-armhf > > example-raw-0.1-r0.do_deb_package_conffiles.debian-jessie-armhf > > example-raw-0.1-r0.do_deb_package_conffiles.debian-wheezy-armhf > > example-raw-0.1-r0.do_deb_package_prepare.debian-jessie-armhf > > example-raw-0.1-r0.do_deb_package_prepare.debian-wheezy-armhf > > example-raw-0.1-r0.do_fetch > > example-raw-0.1-r0.do_populate_package.debian-jessie-armhf > > example-raw-0.1-r0.do_populate_package.debian-wheezy-armhf > > example-raw-0.1-r0.do_unpack.debian-jessie-armhf > > example-raw-0.1-r0.do_unpack.debian-wheezy-armhf > > ... > > > > So all the new tasks added to Isar, that are distro and/or > > architecture specific, should have suffixes in stamps. > > > > 8<-- > > > > Signed-off-by: Alexander Smirnov > > --- > > meta/classes/dpkg-raw.bbclass | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/meta/classes/dpkg-raw.bbclass > > b/meta/classes/dpkg-raw.bbclass index f9a7411..6c6a89c 100644 > > --- a/meta/classes/dpkg-raw.bbclass > > +++ b/meta/classes/dpkg-raw.bbclass > > @@ -14,6 +14,7 @@ do_populate_package() { > > bbnote "Put your files for this package in ${D}" > > } > > > > +do_populate_package[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > addtask populate_package after do_unpack before > > do_deb_package_prepare > > # so we can put hooks etc. in there already > > @@ -39,6 +40,7 @@ do_deb_package_prepare() { > > done > > } > > > > +do_deb_package_prepare[stamp-extra-info] = > > "${DISTRO}-${DISTRO_ARCH}" addtask deb_package_prepare after > > do_populate_package before do_deb_package_conffiles > > do_deb_package_conffiles() { > > @@ -47,6 +49,7 @@ do_deb_package_conffiles() { > > test -s $CONFFILES || rm $CONFFILES > > } > > > > +do_deb_package_conffiles[stamp-extra-info] = > > "${DISTRO}-${DISTRO_ARCH}" addtask deb_package_conffiles after > > do_deb_package_prepare before do_build > > dpkg_runbuild() { > > >