Re: [PATCH v2 2/4] meta-isar-bin: Generate cache repos

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 19 Sep 2017 15:20:50 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> Generate repos for each configuration in multiconfig.
> 
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
>  meta-isar-bin/conf/layer.conf |  3 +++
>  meta/classes/image.bbclass    | 14 ++++++++++++++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/meta-isar-bin/conf/layer.conf
> b/meta-isar-bin/conf/layer.conf index 3518184..5ef6e60 100644
> --- a/meta-isar-bin/conf/layer.conf
> +++ b/meta-isar-bin/conf/layer.conf
> @@ -9,3 +9,6 @@ DEBCACHEDIR ?= "${LAYERDIR}/apt"
>  
>  # Path to the configuration files templates used by `reprepro`
>  DEBFILESDIR ?= "${LAYERDIR}/files"
> +
> +# Path to the databases used by `reprepro`
> +DEBDBDIR ?= "${LAYERDIR}/db"
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 30f241a..9db7371 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -35,6 +35,20 @@ python __anonymous () {
>          f.close()
>  }
>  
> +do_create_cache_db[stamp-extra-info] = "${DISTRO}"
> +
> +do_create_cache_db() {
> +    path_cache="${DEBCACHEDIR}/${DISTRO}"
> +    path_databases="${DEBDBDIR}/${DISTRO}"
> +
> +    if [ ! -d "${path_databases}" ]; then
> +        reprepro --waitforlock 3 -b ${path_cache} --dbdir
> ${path_databases} \
> +                 export ${DEBDISTRONAME}
> +    fi
> +}
> +
> +addtask create_cache_db before do_fetch

This adds a new tool dependency, maybe update docs with the patch or
keep in mind for later.

Why "waitforlock 3" is there any chance at all that multiple images run
into that at the same time? And if so how do we know 3 is enough? I just
tested that a second "reprepro export" will still return 0, so it seems
safe to do that multiple times, not sure what would happen if some
packages where already added and you "export" again.

Henning

>  do_populate[stamp-extra-info] = "${DISTRO}-${MACHINE}"
>  
>  # Install Debian packages, that were built from sources