Re: [PATCH v2 3/4] meta-isar-bin: Populate cache

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 19 Sep 2017 15:20:51 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> Add newly built packages to apt cache.
> 
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
>  meta/classes/image.bbclass | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 9db7371..d59959b 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -54,6 +54,15 @@ do_populate[stamp-extra-info] =
> "${DISTRO}-${MACHINE}" # Install Debian packages, that were built
> from sources do_populate() {
>      if [ -n "${IMAGE_INSTALL}" ]; then
> +        for p in ${IMAGE_INSTALL}; do
> +            reprepro --waitforlock 3 \
> +                     -b ${DEBCACHEDIR}/${DISTRO} \
> +                     --dbdir ${DEBDBDIR}/${DISTRO} \
> +                     -C main \
> +                     includedeb ${DEBDISTRONAME} \
> +                     ${DEPLOY_DIR_DEB}/${p}_*.deb
> +        done

Why not just do that in do_deploy_deb? Maybe DEPLOY_DIR_DEB could go
away because we deploy directly into the repo.

I found that for kernels built with "make deb-pkg" the "${p}_*.deb"
pattern does not match. At least the way that i named the recipe.
"do_deploy_deb" already works on WORKDIR/*.deb which naturally covers
all packages coming out of a recipe, even if they had names different
from the recipe. Imagine a recipe that downloads multiple .debs from
somewhere and they all have very different names.

Again the question about the waitforlock, 3 seems only slightly better
than 1. I think we need infinite or a serialization mechanism and 1.

Henning

>          sudo mkdir -p ${IMAGE_ROOTFS}/deb
>  
>          for p in ${IMAGE_INSTALL}; do