From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6467463440282681344 X-Received: by 10.223.142.172 with SMTP id q41mr276005wrb.25.1505895760472; Wed, 20 Sep 2017 01:22:40 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.16.8 with SMTP id j8ls78098lje.16.gmail; Wed, 20 Sep 2017 01:22:40 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCKeSs1mfu+Jy36dUg5q+8gi1koXrT6QDfb+a2jkajK6aB3JX3jtC6n+wWmCVexNVmWi7hT X-Received: by 10.25.157.19 with SMTP id g19mr125075lfe.26.1505895760192; Wed, 20 Sep 2017 01:22:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505895760; cv=none; d=google.com; s=arc-20160816; b=EqFBEY0QBU5RRcV2El2LAeAIn1IvrWVNzdH2kE/HjfHhPrWcNQb5jU0eAGeKi9W5p5 yFLqc2NN23S29o7YEOY25GwEq5isHPTqTCQ9Up3vzHafK+UlzT8hZEQh4OzLA2EKR1g8 z1MVYmK+t5L6kt5W79tz9CL1pNXdcZ10/fBofhqpi48FVM8mTzkNENGgbkr7RJDVAaaF IM63ZoTxwe/uHU8bXIlWqJwT/yEDmGgpbF84zZgGMzcAEa8Pshx4pf/fz5GSi+DZ5zuC KKrVyStDzQXfnvWL5W+8QBgDPE/SS7MEIJ99RX2rIKGNl+Q0qsdw3yGQdpQMt8VguCTd AzOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=5Oje93o6kPobbq6aT7HxbeqENTwNtsb/1lwPNpI4ZeM=; b=s4i/ZWNoi7CvR2by1PSrw6b5vlpgtgwOf1G1DdekbE0xpkIAn44Cc6rYH5NRMHBxfb f/qLLqvikwEtE0xYPgMTWzi31zAg8zgLAQFKje8wdouSWRUUEGHepquNUZGRIfGXwSFY rVYmXvh/QKQviiPCtKNoY2ViDYW0OglrlpjrUjFNLdv5OYVVSFRtTunn1TwIkbXZlHgx OU9S59TKO9+cCw1H4TTOs0ug7LlC+rZlcR76M0H8fq8ny1Jlg/xYObVc17fVMnn+1hnu yquL6We6TEKBfjn9tQ7TvD/L7oCSASoN+v2PSpxLBxevneC8tbk79E0n7GG5U8bx5aNn zD3Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id c142si132522wmh.3.2017.09.20.01.22.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Sep 2017 01:22:40 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v8K8Mde3018942 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Sep 2017 10:22:39 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v8K8Mdp2031020; Wed, 20 Sep 2017 10:22:39 +0200 Date: Wed, 20 Sep 2017 10:22:53 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH v2 3/4] meta-isar-bin: Populate cache Message-ID: <20170920102253.22199e95@md1em3qc> In-Reply-To: <20170919122052.28688-4-asmirnov@ilbers.de> References: <20170919122052.28688-1-asmirnov@ilbers.de> <20170919122052.28688-4-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: aKhONOdlJZhi Am Tue, 19 Sep 2017 15:20:51 +0300 schrieb Alexander Smirnov : > Add newly built packages to apt cache. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/image.bbclass | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 9db7371..d59959b 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -54,6 +54,15 @@ do_populate[stamp-extra-info] = > "${DISTRO}-${MACHINE}" # Install Debian packages, that were built > from sources do_populate() { > if [ -n "${IMAGE_INSTALL}" ]; then > + for p in ${IMAGE_INSTALL}; do > + reprepro --waitforlock 3 \ > + -b ${DEBCACHEDIR}/${DISTRO} \ > + --dbdir ${DEBDBDIR}/${DISTRO} \ > + -C main \ > + includedeb ${DEBDISTRONAME} \ > + ${DEPLOY_DIR_DEB}/${p}_*.deb > + done Why not just do that in do_deploy_deb? Maybe DEPLOY_DIR_DEB could go away because we deploy directly into the repo. I found that for kernels built with "make deb-pkg" the "${p}_*.deb" pattern does not match. At least the way that i named the recipe. "do_deploy_deb" already works on WORKDIR/*.deb which naturally covers all packages coming out of a recipe, even if they had names different from the recipe. Imagine a recipe that downloads multiple .debs from somewhere and they all have very different names. Again the question about the waitforlock, 3 seems only slightly better than 1. I think we need infinite or a serialization mechanism and 1. Henning > sudo mkdir -p ${IMAGE_ROOTFS}/deb > > for p in ${IMAGE_INSTALL}; do