From: claudius.heine.ext@siemens.com
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: [PATCH v2 1/2] isar-image-base & buildchroot: create hooks_multistrap dir with bb flag
Date: Thu, 21 Sep 2017 13:19:10 +0200 [thread overview]
Message-ID: <20170921111911.8133-2-claudius.heine.ext@siemens.com> (raw)
In-Reply-To: <20170921111911.8133-1-claudius.heine.ext@siemens.com>
From: Claudius Heine <ch@denx.de>
Issue:
Bitbake provides a mechanism to create required directories with the
'dirs' flag of the tasks. This feature should be prefered instead of
depending on the shell.
Change:
Use the 'dirs' flag to create the hooks_multistrap directory instead of
using the 'install' shell command in the build task.
Impact:
No negative impact known.
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta-isar/recipes-core/images/isar-image-base.bb | 3 +--
meta/recipes-devtools/buildchroot/buildchroot.bb | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
index 5cb8b1c..ccbece0 100644
--- a/meta-isar/recipes-core/images/isar-image-base.bb
+++ b/meta-isar/recipes-core/images/isar-image-base.bb
@@ -20,10 +20,9 @@ IMAGE_PREINSTALL += "apt \
WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
do_rootfs[stamp-extra-info] = "${MACHINE}-${DISTRO}"
+do_rootfs[dirs] = "${WORKDIR}/hooks_multistrap"
do_rootfs() {
- install -d -m 755 ${WORKDIR}/hooks_multistrap
-
# Copy config file
install -m 644 ${THISDIR}/files/multistrap.conf.in ${WORKDIR}/multistrap.conf
install -m 755 ${THISDIR}/files/${DISTRO_CONFIG_SCRIPT} ${WORKDIR}/configscript.sh
diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
index 30039f2..af9f3a8 100644
--- a/meta/recipes-devtools/buildchroot/buildchroot.bb
+++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
@@ -24,10 +24,9 @@ BUILDCHROOT_PREINSTALL ?= "gcc \
WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
+do_build[dirs] = "${WORKDIR}/hooks_multistrap"
do_build() {
- install -d -m 755 ${WORKDIR}/hooks_multistrap
-
# Copy config files
install -m 644 ${THISDIR}/files/multistrap.conf.in ${WORKDIR}/multistrap.conf
install -m 755 ${THISDIR}/files/configscript.sh ${WORKDIR}
--
2.14.1
next prev parent reply other threads:[~2017-09-21 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 11:19 [PATCH v2 0/2] Use fetcher for images claudius.heine.ext
2017-09-21 11:19 ` claudius.heine.ext [this message]
2017-09-21 11:19 ` [PATCH v2 2/2] meta-isar/isar-image-base and meta/buildchroot: Use fetcher for files claudius.heine.ext
2017-09-21 12:25 ` [PATCH v2 0/2] Use fetcher for images Henning Schild
2017-09-25 12:32 ` Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921111911.8133-2-claudius.heine.ext@siemens.com \
--to=claudius.heine.ext@siemens.com \
--cc=ch@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox