From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6467810279643152384 X-Received: by 10.28.212.14 with SMTP id l14mr73266wmg.11.1505992760708; Thu, 21 Sep 2017 04:19:20 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.157.27 with SMTP id k27ls664789wre.0.gmail; Thu, 21 Sep 2017 04:19:20 -0700 (PDT) X-Google-Smtp-Source: AOwi7QB2dZ27EO1upytjv8RJLhJ2iJOUK99/tLe2iHuAneKIvbQM0dRXc4Nx0fSLyzPrOww7GIjq X-Received: by 10.28.68.135 with SMTP id r129mr72258wma.19.1505992760418; Thu, 21 Sep 2017 04:19:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505992760; cv=none; d=google.com; s=arc-20160816; b=xiFjmGUe2Mlt/rgUF4ZNClrKchaVk26uhOoqNHySuKKQDPrBiaY8LEPbLld8VhqDVC SG53ZfaB4O6wk4AsVMBx5lsRWAYO1UQMH0Xobt2xh0FWpIXnt2fGhoJ1CP9M+sgbMvYt rjS5l1A1WS0lXUJZ7N+E4E6uAjkPCDw5IUiiEsm87hia6fuuSx1blZHdR4FJO9WjXIAb QhK0jJBWt4xuALQPQ8YkKfbjHuC39PkJOyGLoOmwYbAgUNVfPV93w3UfcTxb5EI+eJvl WDCjIpIft/HPRSpMr0k0UgBc6xgbzgO0rFbCnbZpelxqNbVZeVgK1C6E/AE0BsqMPjLu NE8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=KLXTjbeEkkTdR9NGozsr4sXAGz7CIFV0EqiIuJTmsDo=; b=qnLmRSDM2De5BG5zoueHMqBHMEIAIBb+djr/258CJn4T8kF8RSSgZewE475PiluYDa gakolrhko08ahG69VHz3y6NL9yzJ9/U/w438CuCJqj33KsC0bsOujmv1GuQJBp2Ht9I5 0jP0PHJv5aaB3T2wx4X//o4QEAmJ95ZLv7DF3Mw2GzwVG8Hvk1D/l0m85nBNUU3Mkqrq CwqhOc4sKwDynIhAeBDhSCNQ8vpeIfTCG24LeZdI7hLgkvssfEbISWBqffl+wic8/Ia/ H+5rnuOm1EQnrlGKOa+pT8zu3O4p1OkUZVCkqogCL2+j8Q0nl9YJPdB6KFiRzv1vVKvz wdmA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id k18si303849wmd.1.2017.09.21.04.19.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 04:19:20 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.14 is neither permitted nor denied by domain of claudius.heine.ext@siemens.com) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.14 is neither permitted nor denied by domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v8LBJJ8i003990 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Sep 2017 13:19:19 +0200 Received: from ring.ppmd.siemens.net (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id v8LBJIv2024918; Thu, 21 Sep 2017 13:19:19 +0200 From: claudius.heine.ext@siemens.com To: isar-users@googlegroups.com Cc: Claudius Heine Subject: [PATCH v2 1/2] isar-image-base & buildchroot: create hooks_multistrap dir with bb flag Date: Thu, 21 Sep 2017 13:19:10 +0200 Message-Id: <20170921111911.8133-2-claudius.heine.ext@siemens.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170921111911.8133-1-claudius.heine.ext@siemens.com> References: <20170921111911.8133-1-claudius.heine.ext@siemens.com> X-TUID: 8ey/AAW8LKS9 From: Claudius Heine Issue: Bitbake provides a mechanism to create required directories with the 'dirs' flag of the tasks. This feature should be prefered instead of depending on the shell. Change: Use the 'dirs' flag to create the hooks_multistrap directory instead of using the 'install' shell command in the build task. Impact: No negative impact known. Signed-off-by: Claudius Heine --- meta-isar/recipes-core/images/isar-image-base.bb | 3 +-- meta/recipes-devtools/buildchroot/buildchroot.bb | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb index 5cb8b1c..ccbece0 100644 --- a/meta-isar/recipes-core/images/isar-image-base.bb +++ b/meta-isar/recipes-core/images/isar-image-base.bb @@ -20,10 +20,9 @@ IMAGE_PREINSTALL += "apt \ WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" do_rootfs[stamp-extra-info] = "${MACHINE}-${DISTRO}" +do_rootfs[dirs] = "${WORKDIR}/hooks_multistrap" do_rootfs() { - install -d -m 755 ${WORKDIR}/hooks_multistrap - # Copy config file install -m 644 ${THISDIR}/files/multistrap.conf.in ${WORKDIR}/multistrap.conf install -m 755 ${THISDIR}/files/${DISTRO_CONFIG_SCRIPT} ${WORKDIR}/configscript.sh diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb index 30039f2..af9f3a8 100644 --- a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -24,10 +24,9 @@ BUILDCHROOT_PREINSTALL ?= "gcc \ WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" +do_build[dirs] = "${WORKDIR}/hooks_multistrap" do_build() { - install -d -m 755 ${WORKDIR}/hooks_multistrap - # Copy config files install -m 644 ${THISDIR}/files/multistrap.conf.in ${WORKDIR}/multistrap.conf install -m 755 ${THISDIR}/files/configscript.sh ${WORKDIR} -- 2.14.1