From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6477538949418975232 X-Received: by 10.223.134.37 with SMTP id 34mr1554583wrv.1.1508335602557; Wed, 18 Oct 2017 07:06:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.186.15 with SMTP id o15ls1273776wrg.13.gmail; Wed, 18 Oct 2017 07:06:42 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SFpyDqD8BMKxzgsRd7ID4NqYmoQdYq6fyvYN+rTne3fES8JdM9PKHb4IeIOJbaCjoJBLt8 X-Received: by 10.28.158.129 with SMTP id h123mr757246wme.17.1508335602277; Wed, 18 Oct 2017 07:06:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508335602; cv=none; d=google.com; s=arc-20160816; b=0DM9i4yVWW0gm+udprWbAJBwOq2/7l6+PF+2yYstUrkNReB+VsC4hE9Ny5gN1l8hfS I7kzp0c6dexCMNsXatTOtCyYoGhbHIGap9Sx4PNpQ1iSCWYrV9VJ63/dzs7c2jOmDcTq YLyqliMJTVaojmRpbModES5l7YLCpYsQIQbmYnYCOd5AA7AIJJMdKBu2o4xNmFpiUdDH WF5LQgWnHe4BDRgxltOF9GAPZXpk0RarWQKBx8droqnAo8Si856ksoCbMGKYBbWia6pI 6uqIO08vmfHmaqf3oQP/afE6gZcWtLpxadzjoGLuiAJi2z2FQwZg62q+VO14+6CeohRO GXhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=qlOZw+n/XcgC9c+hk+Wl+AgbBezjtL9cZWhlBVXtEPc=; b=FGdOAoNWE/ACJviDILG9N+EYnbMPB7BXtCy8zFPl3ripdaI4r/iG+sF4vVRs9fVcQF l7/x/CVJ/d1uJixxQZ8wOP2P2oGqAuMLjH7rvZmKL/ymZ8SZZuaMEf3rptjFEC+46rKh 6lioRKI5cCWvGTb8WlL1zizB5pSKeywqSwknuG7bD7CR0+eeHjmZmJUwO3PxzCv5BLJC 9R+4oNR8mGQQd+w7qO9HFnl83F2Ab10nSx80+mHQExslwRcjJuo7Qsc8O/Qk1gOVlGL4 6/MPnG4F5s6kMo+HRK6lQG3Z4DosXXpq4pP1bIkAXEl4XR+Q/heauDuuxXxIZSGQoSju 5GHg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id m62si194241wmi.1.2017.10.18.07.06.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2017 07:06:42 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v9IE6fw4026069 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Oct 2017 16:06:41 +0200 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v9IE6ff2021968; Wed, 18 Oct 2017 16:06:41 +0200 Date: Wed, 18 Oct 2017 16:06:40 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [URGENT][PATCH v2 0/2] Correctly determine kernel and initrd versions Message-ID: <20171018160640.6b8f3beb@md1em3qc> In-Reply-To: <20171017192308.3802-1-asmirnov@ilbers.de> References: <20171017192308.3802-1-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: DScwnvjfHB94 I have not tested these patches, but they look good to me. The whole readlink thing is not too important. Henning On Tue, 17 Oct 2017 22:23:06 +0300 Alexander Smirnov wrote: > Hello all, > > IMPORTANT: lets try to review this series ASAP, becuase Isar build is > broken again due to recent update of Raspbian kernel version in apt. > Instead of yet-another-version update I'd like to commit proper > solution. > > In current Isar implementation, multiconfig file contains hardcoded > version for boot files: kernel and initrd. This is used for both: > > - Add respective package to multistrap config. > - Copy boot files to deploy directory. > > This series drops this hardcoded versions, so now Isar is able to > determine version of boot files during building. > > Changes since v1: > - Differentiate 'do_copy_boot_files' stamps. > - Update start_vm script accordingly. > - Check if symlinks 'vmlinuz' and 'initrd.img' exist before reading > them. If symlink doesn't exist, this function skips it. > > With best regards, > Alex > > > *** BLURB HERE *** > > Alexander Smirnov (2): > meta-isar: Drop hardcoded kernel versions > meta-isar: Rework boot files copying > > meta-isar/conf/multiconfig/qemuamd64-jessie.conf | 5 +---- > meta-isar/conf/multiconfig/qemuamd64-stretch.conf | 5 +---- > meta-isar/conf/multiconfig/qemuarm-jessie.conf | 5 +---- > meta-isar/conf/multiconfig/qemuarm-stretch.conf | 5 +---- > meta-isar/conf/multiconfig/qemuarm-wheezy.conf | 5 +---- > meta-isar/conf/multiconfig/qemui386-jessie.conf | 5 +---- > meta-isar/conf/multiconfig/qemui386-stretch.conf | 5 +---- > meta-isar/conf/multiconfig/rpi-jessie.conf | 3 --- > meta/classes/ext4-img.bbclass | 8 -------- > meta/classes/image.bbclass | 24 > ++++++++++++++++++++--- > scripts/start_vm | 8 ++++++-- 11 > files changed, 34 insertions(+), 44 deletions(-) >