public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Alexander Smirnov <asmirnov@ilbers.de>
To: isar-users@googlegroups.com
Cc: Alexander Smirnov <asmirnov@ilbers.de>
Subject: [PATCH] meta-isar: Setting root password
Date: Thu, 19 Oct 2017 13:30:43 +0300	[thread overview]
Message-ID: <20171019103043.25702-1-asmirnov@ilbers.de> (raw)

This patch addresses the following issues:

1. At the moment there are two places where root password is set:
 - mulristrap scripts
 - example-raw application
So there is no need to do this twice for default Isar layout.

2. According to the README.md, the default password is 'root', so it
needs to set it back to avoid unnecessary surprise of existing users.

3. Define default passowrd as variable to have possibility to override
it from local config.

Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
---
 meta-isar/recipes-app/example-raw/example-raw_0.2.bb         | 4 +++-
 meta-isar/recipes-core/images/files/debian-configscript.sh   | 3 ---
 meta-isar/recipes-core/images/files/raspbian-configscript.sh | 3 ---
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb
index 7dd343a..0f0ee27 100644
--- a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb
+++ b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb
@@ -12,6 +12,8 @@ SRC_URI = "file://README \
 
 inherit dpkg-raw
 
+ISAR_DEFAULT_PASSWORD ?= "root"
+
 do_install() {
 	bbnote "Creating ${PN} binary"
 	echo "#!/bin/sh" > ${WORKDIR}/${PN}
@@ -29,7 +31,7 @@ do_install() {
 	install -v -m 755 ${WORKDIR}/postinst ${D}/DEBIAN/postinst
 
 	bbnote "Also change the root password"
-	echo 'echo "root:isar" | chpasswd' >> ${D}/DEBIAN/postinst
+	echo 'echo "root:${ISAR_DEFAULT_PASSWORD}" | chpasswd' >> ${D}/DEBIAN/postinst
 
 	bbnote "Now for a fake config file"
 	echo "# empty config file" > ${WORKDIR}/${PN}.conf
diff --git a/meta-isar/recipes-core/images/files/debian-configscript.sh b/meta-isar/recipes-core/images/files/debian-configscript.sh
index 7303598..d028c75 100644
--- a/meta-isar/recipes-core/images/files/debian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/debian-configscript.sh
@@ -46,9 +46,6 @@ export LC_ALL=C LANGUAGE=C LANG=C
 # Configuring packages
 dpkg --configure -a
 
-# set the root password if that has not been done before
-grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd
-
 cat > /etc/fstab << EOF
 # Begin /etc/fstab
 /dev/$ROOTFS_DEV	/		ext4		defaults		1	1
diff --git a/meta-isar/recipes-core/images/files/raspbian-configscript.sh b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
index 4cb004b..2cdd1cb 100644
--- a/meta-isar/recipes-core/images/files/raspbian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
@@ -50,9 +50,6 @@ rm /var/lib/dpkg/info/raspberrypi-bootloader-nokernel.postinst
 # Configuring packages
 dpkg --configure -a
 
-# set the root password if that has not been done before
-grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd
-
 cat > /etc/fstab << EOF
 # Begin /etc/fstab
 /dev/$ROOTFS_DEV	/		ext4		defaults		1	1
-- 
2.1.4


             reply	other threads:[~2017-10-19 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19 10:30 Alexander Smirnov [this message]
2017-10-19 10:51 ` Henning Schild
2017-10-19 11:18   ` Alexander Smirnov
2017-10-19 12:04     ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019103043.25702-1-asmirnov@ilbers.de \
    --to=asmirnov@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox