Re: [PATCH] meta-isar: Setting root password

[Henning Schild <henning.schild@siemens.com>]

On Thu, 19 Oct 2017 13:30:43 +0300
Alexander Smirnov <asmirnov@ilbers.de> wrote:

> This patch addresses the following issues:
> 
> 1. At the moment there are two places where root password is set:
>  - mulristrap scripts
>  - example-raw application
> So there is no need to do this twice for default Isar layout.

Productive images are not likely to contain the example, they might
have a recipe that sets the password (like the example). Having the
second chpasswd makes sure we have a password set even when no
additional packages are installed, also not the example.
So i think we should stick to two places.

> 2. According to the README.md, the default password is 'root', so it
> needs to set it back to avoid unnecessary surprise of existing users.

That is an issue that could be changed by updating the documentation.

> 3. Define default passowrd as variable to have possibility to override
> it from local config.

The example-raw shows a clear way to set the password for an image, no
need to invent another way, we have one that works.

So i suggest to drop this patch and i will change the documentation.
Either with a new version of the patch i wrote, or with a new patch on
top.

Henning
 
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
>  meta-isar/recipes-app/example-raw/example-raw_0.2.bb         | 4 +++-
>  meta-isar/recipes-core/images/files/debian-configscript.sh   | 3 ---
>  meta-isar/recipes-core/images/files/raspbian-configscript.sh | 3 ---
>  3 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb
> b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb index
> 7dd343a..0f0ee27 100644 ---
> a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb +++
> b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb @@ -12,6 +12,8
> @@ SRC_URI = "file://README \ 
>  inherit dpkg-raw
>  
> +ISAR_DEFAULT_PASSWORD ?= "root"
> +
>  do_install() {
>  	bbnote "Creating ${PN} binary"
>  	echo "#!/bin/sh" > ${WORKDIR}/${PN}
> @@ -29,7 +31,7 @@ do_install() {
>  	install -v -m 755 ${WORKDIR}/postinst ${D}/DEBIAN/postinst
>  
>  	bbnote "Also change the root password"
> -	echo 'echo "root:isar" | chpasswd' >> ${D}/DEBIAN/postinst
> +	echo 'echo "root:${ISAR_DEFAULT_PASSWORD}" | chpasswd' >>
> ${D}/DEBIAN/postinst 
>  	bbnote "Now for a fake config file"
>  	echo "# empty config file" > ${WORKDIR}/${PN}.conf
> diff --git
> a/meta-isar/recipes-core/images/files/debian-configscript.sh
> b/meta-isar/recipes-core/images/files/debian-configscript.sh index
> 7303598..d028c75 100644 ---
> a/meta-isar/recipes-core/images/files/debian-configscript.sh +++
> b/meta-isar/recipes-core/images/files/debian-configscript.sh @@ -46,9
> +46,6 @@ export LC_ALL=C LANGUAGE=C LANG=C # Configuring packages
> dpkg --configure -a 
> -# set the root password if that has not been done before
> -grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd
> -
>  cat > /etc/fstab << EOF
>  # Begin /etc/fstab
>  /dev/$ROOTFS_DEV	/		ext4
> defaults		1	1 diff --git
> a/meta-isar/recipes-core/images/files/raspbian-configscript.sh
> b/meta-isar/recipes-core/images/files/raspbian-configscript.sh index
> 4cb004b..2cdd1cb 100644 ---
> a/meta-isar/recipes-core/images/files/raspbian-configscript.sh +++
> b/meta-isar/recipes-core/images/files/raspbian-configscript.sh @@
> -50,9 +50,6 @@
> rm /var/lib/dpkg/info/raspberrypi-bootloader-nokernel.postinst #
> Configuring packages dpkg --configure -a -# set the root password if
> that has not been done before -grep "root:\*:" /etc/shadow && echo
> "root:root" | chpasswd -
>  cat > /etc/fstab << EOF
>  # Begin /etc/fstab
>  /dev/$ROOTFS_DEV	/		ext4
> defaults		1	1