From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6478567610421084160 X-Received: by 10.46.18.17 with SMTP id t17mr58406lje.33.1508414678507; Thu, 19 Oct 2017 05:04:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.25.80 with SMTP id p77ls1003847lje.1.gmail; Thu, 19 Oct 2017 05:04:38 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SWLX5nZmg8oOyYY/CrtJiqHiP+iA2lJ09aPspjcPlhe5EYPhC035fXudULa9ZhI16pBLhy X-Received: by 10.46.34.4 with SMTP id i4mr57821lji.17.1508414678224; Thu, 19 Oct 2017 05:04:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508414678; cv=none; d=google.com; s=arc-20160816; b=C/3IhMgY5cDtPxna1O/Go9FFbBnI+xEy/dzyE2CSSpaDDcpPcskY8SJgL/RUUoOLNv BfvHUS9vihOEZS1nCyaK7za1MbGq5Ni3dGAtzU0q6xAYavcB97NZRSBNPzaLXY+ZJIc5 iHuV3sslwNTqWL1MFi1cqbEc7MJgItBz2gUGt9GIPbQRpStRuW3GDc/ke9OlnK1VoP9O 6Z+xIzZXFn9BoNEn/bYH8LgEfU8wXnx2kB6OQonvIczLyzMbPlJLFxURrWq0271BColP G/hhZzDZ+kCeP4+qnqadIdpsAMhZa8IeE3K/eS5WmeCIRTqaxnwC/l/0OnV1T+YjeKRs txZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=dmLpTukzKOm3ua22/C6Lh6OEsTNhwmJ0SKon5HZNHyc=; b=p7B/eNvvkGz49/jj5/FGXf3MqhLhIWHrMdYqGg3SHDvb0QHXuZDbByVVvItmoZSuyc BaSsJSLfDZ1JLI8r/hJ2Nxo0n7WB2AOQBdmFWkygPps9XTpPBlvjzhWB98DjOXeg/FD2 K3oVwXD7mHPXalaYXbzGlIZtT5cdxNoExkiutqlUGU+wVnbiXQWnnEIwUmA9Y5D5Bva7 q5DI3iUDZRKXztvubIAB30LSmd5oXfLykMxG4yrdTaVL2cdphNQrtbiy3BBdFaAUwSEq qPPFDbGynA44/4KQAzftyDPgQCe58sGYZd3zws94y+fXLLyZvMck9HCbNC1zGMEVSFkG xyww== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id g84si559515lfl.3.2017.10.19.05.04.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 05:04:38 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v9JC4b2O030141 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Oct 2017 14:04:37 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v9JC4bBZ032397; Thu, 19 Oct 2017 14:04:37 +0200 Date: Thu, 19 Oct 2017 14:04:36 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH] meta-isar: Setting root password Message-ID: <20171019140436.3f62bdb1@md1em3qc> In-Reply-To: <5fcf2095-d222-5708-a38e-bfe04ca320e7@ilbers.de> References: <20171019103043.25702-1-asmirnov@ilbers.de> <20171019125109.71bc0078@md1em3qc> <5fcf2095-d222-5708-a38e-bfe04ca320e7@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: bUggs60fwnFX On Thu, 19 Oct 2017 14:18:09 +0300 Alexander Smirnov wrote: > On 10/19/2017 01:51 PM, Henning Schild wrote: > > On Thu, 19 Oct 2017 13:30:43 +0300 > > Alexander Smirnov wrote: > > > >> This patch addresses the following issues: > >> > >> 1. At the moment there are two places where root password is set: > >> - mulristrap scripts > >> - example-raw application > >> So there is no need to do this twice for default Isar layout. > > > > Productive images are not likely to contain the example, they might > > have a recipe that sets the password (like the example). Having the > > second chpasswd makes sure we have a password set even when no > > additional packages are installed, also not the example. > > So i think we should stick to two places. > > > >> 2. According to the README.md, the default password is 'root', so > >> it needs to set it back to avoid unnecessary surprise of existing > >> users. > > > > That is an issue that could be changed by updating the > > documentation. > >> 3. Define default passowrd as variable to have possibility to > >> override it from local config. > > > > The example-raw shows a clear way to set the password for an image, > > no need to invent another way, we have one that works. > > > > So i suggest to drop this patch and i will change the documentation. > > Either with a new version of the patch i wrote, or with a new patch > > on top. > > The default Isar password should stay the same, i.e. 'root', I see no > reason to change this policy. So if example application is optional > and both password setting approaches should stay in Isar, then they > should set the same password. Otherwise after dropping 'example-raw' > user won't be able to login by following README.md. > > So I propose to change 'isar' to 'root' in example-raw application. > Please let me know if you could handle this, or I could prepare the > patch. It's quite urgent because README.md is inconsistent now. I will send an updated patch. It is not urgent since it is a regression in next and not in master. And next is not for end-users. Henning > Alex > > > > > Henning > > > >> Signed-off-by: Alexander Smirnov > >> --- > >> meta-isar/recipes-app/example-raw/example-raw_0.2.bb | 4 > >> +++- meta-isar/recipes-core/images/files/debian-configscript.sh > >> | 3 --- > >> meta-isar/recipes-core/images/files/raspbian-configscript.sh | 3 > >> --- 3 files changed, 3 insertions(+), 7 deletions(-) > >> > >> diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb > >> b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb index > >> 7dd343a..0f0ee27 100644 --- > >> a/meta-isar/recipes-app/example-raw/example-raw_0.2.bb +++ > >> b/meta-isar/recipes-app/example-raw/example-raw_0.2.bb @@ -12,6 > >> +12,8 @@ SRC_URI = "file://README \ > >> inherit dpkg-raw > >> > >> +ISAR_DEFAULT_PASSWORD ?= "root" > >> + > >> do_install() { > >> bbnote "Creating ${PN} binary" > >> echo "#!/bin/sh" > ${WORKDIR}/${PN} > >> @@ -29,7 +31,7 @@ do_install() { > >> install -v -m 755 ${WORKDIR}/postinst > >> ${D}/DEBIAN/postinst > >> bbnote "Also change the root password" > >> - echo 'echo "root:isar" | chpasswd' >> ${D}/DEBIAN/postinst > >> + echo 'echo "root:${ISAR_DEFAULT_PASSWORD}" | chpasswd' >> > >> ${D}/DEBIAN/postinst > >> bbnote "Now for a fake config file" > >> echo "# empty config file" > ${WORKDIR}/${PN}.conf > >> diff --git > >> a/meta-isar/recipes-core/images/files/debian-configscript.sh > >> b/meta-isar/recipes-core/images/files/debian-configscript.sh index > >> 7303598..d028c75 100644 --- > >> a/meta-isar/recipes-core/images/files/debian-configscript.sh +++ > >> b/meta-isar/recipes-core/images/files/debian-configscript.sh @@ > >> -46,9 +46,6 @@ export LC_ALL=C LANGUAGE=C LANG=C # Configuring > >> packages dpkg --configure -a > >> -# set the root password if that has not been done before > >> -grep "root:\*:" /etc/shadow && echo "root:root" | chpasswd > >> - > >> cat > /etc/fstab << EOF > >> # Begin /etc/fstab > >> /dev/$ROOTFS_DEV / ext4 > >> defaults 1 1 diff --git > >> a/meta-isar/recipes-core/images/files/raspbian-configscript.sh > >> b/meta-isar/recipes-core/images/files/raspbian-configscript.sh > >> index 4cb004b..2cdd1cb 100644 --- > >> a/meta-isar/recipes-core/images/files/raspbian-configscript.sh +++ > >> b/meta-isar/recipes-core/images/files/raspbian-configscript.sh @@ > >> -50,9 +50,6 @@ > >> rm /var/lib/dpkg/info/raspberrypi-bootloader-nokernel.postinst # > >> Configuring packages dpkg --configure -a -# set the root password > >> if that has not been done before -grep "root:\*:" /etc/shadow && > >> echo "root:root" | chpasswd - > >> cat > /etc/fstab << EOF > >> # Begin /etc/fstab > >> /dev/$ROOTFS_DEV / ext4 > >> defaults 1 1 > > >