From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6478661911279828992 X-Received: by 10.28.107.65 with SMTP id g62mr266455wmc.32.1508431022783; Thu, 19 Oct 2017 09:37:02 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.181.129 with SMTP id c1ls2104293wre.9.gmail; Thu, 19 Oct 2017 09:37:02 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TRRCv8HpA6vb0skgIlqHjqNR6S3+7BfJFXHi3Ya86wTdfa+p0xQ78sGYj0RsoKYphC1c7y X-Received: by 10.28.69.24 with SMTP id s24mr276082wma.31.1508431022486; Thu, 19 Oct 2017 09:37:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508431022; cv=none; d=google.com; s=arc-20160816; b=vy7RXFtQwSvNC4ZgVwsEasAkI2ApLuo9W+Gxp7S/NfRpwwz2/RsF9RCZussUmnDfLV HxbGspW8HUeCbU8enQXmatKzz/DJlS+bvNngo3zlY2WvRyFY9H7LnnbpPYiGgT9nWXHY cYafM7DAnwKh54iA8e9m41WTE+o07HO4yDYoLnI09All/TI/iKZsNtfRfM9aY/8SJeSX J+GDr98sKD+it/8ociGSJkA+tVOyKcRHEoHEuPNBGI6oW/c39lO5KEDv2nYt39jpqzx3 LkA/R4HsLydH770fBzKD8najS+zspmjZnkv5G428lu/fH3iPqrqh57QNMpkdI38KlgI3 6KxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:arc-authentication-results; bh=2NUWjUapB5CENOxEOem5rcuITHbLbclPw569BDzpIJA=; b=rOG20tWk1LGUSHW2BrVFN/+plVDTZuQu6r5tOI2u5RmEgPIkIm4KxHBgAYIkztDe6E afOwwet+Q33mULw7ru1Wdy+B9ERr8rDbUwQu1Oga0TK/ha+pTYFjwBOjMcmp2dLZDoo3 Q0akKMVn2qBcs33i6MRsvFZzUjBuQ0OXQC/LeFbnXZzdKu1XnsfdurUnWlBddP07JJa+ gvMyVIjAe93r6XaC/KL6PWnHv1p3Tc5eHC+ebIXsuPz5ADvZ1HuD9lqCs4/8/g4d+wAg Z2kM2l2M7BIMwFlDIu7IqQ0AiKqXF4VMyJ9e4h7TkBdKDCAhW8wXLajx9Uthxv78o+Uv NsaQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id h17si125639wmd.0.2017.10.19.09.37.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 09:37:02 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v9JGb1pt016106 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 19 Oct 2017 18:37:02 +0200 Received: from md1em3qc.ww002.siemens.net ([139.25.68.40]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id v9JGb1F2031546; Thu, 19 Oct 2017 18:37:01 +0200 From: Henning Schild To: isar-users@googlegroups.com Cc: Henning Schild Subject: [PATCH] multistrap: do not ignore multistrap errors anymore Date: Thu, 19 Oct 2017 18:36:59 +0200 Message-Id: <20171019163659.15289-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.13.6 X-TUID: b3qwx/IU9zwg Issue: Isar problems are often hard to debug and often enough you wonder why configscript.sh is not there. In that case the real problem always is in multistrap actually failing and Isar ignoring the return value. Change: Do not ignore the return value of multistrap anymore. Impact: Debugging should become much easier, the last error message will be the actual error message. Signed-off-by: Henning Schild --- meta-isar/recipes-core/images/isar-image-base.bb | 2 +- meta/recipes-devtools/buildchroot/buildchroot.bb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb index 121b586..7e36e22 100644 --- a/meta-isar/recipes-core/images/isar-image-base.bb +++ b/meta-isar/recipes-core/images/isar-image-base.bb @@ -55,7 +55,7 @@ do_rootfs() { sudo mount -t proc none ${IMAGE_ROOTFS}/proc # Create root filesystem - sudo multistrap -a ${DISTRO_ARCH} -d "${IMAGE_ROOTFS}" -f "${WORKDIR}/multistrap.conf" || true + sudo multistrap -a ${DISTRO_ARCH} -d "${IMAGE_ROOTFS}" -f "${WORKDIR}/multistrap.conf" # Configure root filesystem sudo chroot ${IMAGE_ROOTFS} /${DISTRO_CONFIG_SCRIPT} ${MACHINE_SERIAL} ${BAUDRATE_TTY} \ diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb index 452536f..3e5c0ac 100644 --- a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -55,7 +55,7 @@ do_build() { sudo mount -t proc none ${IMAGE_ROOTFS}/proc # Create root filesystem - sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f "${WORKDIR}/multistrap.conf" || true + sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f "${WORKDIR}/multistrap.conf" # Install package builder script sudo install -m 755 ${THISDIR}/files/build.sh ${BUILDCHROOT_DIR} -- 2.13.6