public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Alexander Smirnov <asmirnov@ilbers.de>
Cc: <isar-users@googlegroups.com>
Subject: Re: [URGENT][PATCH v2 0/2] Correctly determine kernel and initrd versions
Date: Thu, 19 Oct 2017 18:00:51 +0200	[thread overview]
Message-ID: <20171019180051.04ac5a52@md1em3qc> (raw)
In-Reply-To: <20171018160640.6b8f3beb@md1em3qc>

On Wed, 18 Oct 2017 16:06:40 +0200
"[ext] Henning Schild" <henning.schild@siemens.com> wrote:

> I have not tested these patches, but they look good to me. The whole
> readlink thing is not too important.

Just tested them and they break wic because the two variables are not
part of any config. Would require the eval(bitbake) stuff that is done
in start_vm. Probably not the best idea to do that over and over, maybe
the code should append that to local.conf or write it to a file that
everyone can read.

Why are they on top of next in git and not on master? Would the urgent
not suggest we should test them on top of master and take them on the
fast lane before next?

Setting the two guys back to what they where in multiconfig does not
work because the code would now look for /vmlinuz-4.9....

Setting them to "boot/vmlinuz-4.9..." creates wic trouble again.

I think a wic use-case needs to be added to CI, but since wic is not
integrated in bitbake i am afraid i can not send patches because the
change needs to happen in your CI.

Henning

> Henning
> 
> On Tue, 17 Oct 2017 22:23:06 +0300
> Alexander Smirnov <asmirnov@ilbers.de> wrote:
> 
> > Hello all,
> > 
> > IMPORTANT: lets try to review this series ASAP, becuase Isar build
> > is broken again due to recent update of Raspbian kernel version in
> > apt. Instead of yet-another-version update I'd like to commit proper
> > solution.
> > 
> > In current Isar implementation, multiconfig file contains hardcoded
> > version for boot files: kernel and initrd. This is used for both:
> > 
> >  - Add respective package to multistrap config.
> >  - Copy boot files to deploy directory.
> > 
> > This series drops this hardcoded versions, so now Isar is able to
> > determine version of boot files during building.
> > 
> > Changes since v1:
> >  - Differentiate 'do_copy_boot_files' stamps.
> >  - Update start_vm script accordingly.
> >  - Check if symlinks 'vmlinuz' and 'initrd.img' exist before reading
> >    them. If symlink doesn't exist, this function skips it.
> > 
> > With best regards,
> > Alex
> > 
> > 
> > *** BLURB HERE ***
> > 
> > Alexander Smirnov (2):
> >   meta-isar: Drop hardcoded kernel versions
> >   meta-isar: Rework boot files copying
> > 
> >  meta-isar/conf/multiconfig/qemuamd64-jessie.conf  |  5 +----
> >  meta-isar/conf/multiconfig/qemuamd64-stretch.conf |  5 +----
> >  meta-isar/conf/multiconfig/qemuarm-jessie.conf    |  5 +----
> >  meta-isar/conf/multiconfig/qemuarm-stretch.conf   |  5 +----
> >  meta-isar/conf/multiconfig/qemuarm-wheezy.conf    |  5 +----
> >  meta-isar/conf/multiconfig/qemui386-jessie.conf   |  5 +----
> >  meta-isar/conf/multiconfig/qemui386-stretch.conf  |  5 +----
> >  meta-isar/conf/multiconfig/rpi-jessie.conf        |  3 ---
> >  meta/classes/ext4-img.bbclass                     |  8 --------
> >  meta/classes/image.bbclass                        | 24
> > ++++++++++++++++++++---
> > scripts/start_vm                                  |  8 ++++++-- 11
> > files changed, 34 insertions(+), 44 deletions(-)
> >   
> 


  reply	other threads:[~2017-10-19 16:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 19:23 Alexander Smirnov
2017-10-17 19:23 ` [URGENT][PATCH v2 1/2] meta-isar: Drop hardcoded kernel versions Alexander Smirnov
2017-10-17 19:23 ` [URGENT][PATCH v2 2/2] meta-isar: Rework boot files copying Alexander Smirnov
2017-10-18 14:06 ` [URGENT][PATCH v2 0/2] Correctly determine kernel and initrd versions Henning Schild
2017-10-19 16:00   ` Henning Schild [this message]
2017-10-19 16:08     ` Henning Schild
2017-10-19 19:18       ` Alexander Smirnov
2017-10-19 19:13     ` [PATCH v4] meta-isar: Rework boot files copying Alexander Smirnov
2017-10-19 19:39       ` Alexander Smirnov
2017-10-20 16:11       ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019180051.04ac5a52@md1em3qc \
    --to=henning.schild@siemens.com \
    --cc=asmirnov@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox