From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6477538949418975232 X-Received: by 10.46.86.156 with SMTP id k28mr87583lje.22.1508429301835; Thu, 19 Oct 2017 09:08:21 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.86.218 with SMTP id k87ls1090011lje.15.gmail; Thu, 19 Oct 2017 09:08:21 -0700 (PDT) X-Google-Smtp-Source: ABhQp+R0Nt0CNocHJXrHUpZacOIwALf/da8rqnJp/b/SUSPvrRqfyERioP+qRb2jiNPPMVdcAo2D X-Received: by 10.25.39.20 with SMTP id n20mr70826lfn.9.1508429301463; Thu, 19 Oct 2017 09:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508429301; cv=none; d=google.com; s=arc-20160816; b=BRhcreDR89GFP4fpYgXHzLUYFZjsvGdGD5I0OhIdTSnnIJopHJr9c0YgQ8QOwyyPXK o4+dlo8IXtAjZ3puQvda6LPeDhuxCfGhwAytZHa2+ZfPjnlOQk6S9VFmS3VSaEtV/8kL 0MelqrRH05kMcpaQIP5fdFJHwi5cGFwef4CLeeJOpwhh7mnqYfimn2MapuF4Hqu49jIo KtKSyxchdFAKrTN7yQwd+vKgpDeqjgNptuCDkb0JSqvgSQfswOoWa+pSwWJoWe3gq2JO ns/lvr+FAhbEuEe0y+HTMPOgZLnJZ5rAdQD55CnjnAVaxB/Q/y/Qr80WFqVfrFpF0u88 EYZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=YxPot/s/UgDof2K+13jAeOQwEyd1zj25eNPMcVVvWZo=; b=ghyeb2Okn9vje29IAtRWvpH+bQHjAbVll9LUNjPFHTUqHiWEggJqIOTg1lKADeeisF QiAq2luavPVkDVnpMSj3STJPhVbNGWR1jLKsWJV8M5GLJ7voFMs4WSey+ejpLYDswwrk B70e/PNSFgzX/HcmYJrFuIsvs1ERFtVeH43Rkt7FG4YJPqR+G96A3Az8IIZXZUWp1CKs kOI2z8tD0SmeXJQsUnpMdEZV7UpXmq59wRfAMRgVm9ah540DRrhWugmrFS4jB730V5FU tjtCO6uX1pepYnqrNAWa37qwnc9dfaZaZWdSs22+OwSE+FWnK0ZUUR97GeGHZHgdYBkn 7LfA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id l14si808308lje.1.2017.10.19.09.08.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 09:08:21 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id v9JG8Kaf029724 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Oct 2017 18:08:20 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v9JG8K9A016445; Thu, 19 Oct 2017 18:08:20 +0200 Date: Thu, 19 Oct 2017 18:08:19 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [URGENT][PATCH v2 0/2] Correctly determine kernel and initrd versions Message-ID: <20171019180819.02ccff13@md1em3qc> In-Reply-To: <20171019180051.04ac5a52@md1em3qc> References: <20171017192308.3802-1-asmirnov@ilbers.de> <20171018160640.6b8f3beb@md1em3qc> <20171019180051.04ac5a52@md1em3qc> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: bO5NAAmKswCj On Thu, 19 Oct 2017 18:00:51 +0200 "[ext] Henning Schild" wrote: > On Wed, 18 Oct 2017 16:06:40 +0200 > "[ext] Henning Schild" wrote: > > > I have not tested these patches, but they look good to me. The whole > > readlink thing is not too important. > > Just tested them and they break wic because the two variables are not > part of any config. Would require the eval(bitbake) stuff that is done > in start_vm. Probably not the best idea to do that over and over, > maybe the code should append that to local.conf or write it to a file > that everyone can read. > > Why are they on top of next in git and not on master? Would the urgent > not suggest we should test them on top of master and take them on the > fast lane before next? > > Setting the two guys back to what they where in multiconfig does not > work because the code would now look for /vmlinuz-4.9.... > > Setting them to "boot/vmlinuz-4.9..." creates wic trouble again. > > I think a wic use-case needs to be added to CI, but since wic is not > integrated in bitbake i am afraid i can not send patches because the > change needs to happen in your CI. All that being said, go ahead and merge them to master. If wic is not part of CI, wic users can carry fixes for the new issues in their branches for now. Henning > Henning > > > Henning > > > > On Tue, 17 Oct 2017 22:23:06 +0300 > > Alexander Smirnov wrote: > > > > > Hello all, > > > > > > IMPORTANT: lets try to review this series ASAP, becuase Isar build > > > is broken again due to recent update of Raspbian kernel version in > > > apt. Instead of yet-another-version update I'd like to commit > > > proper solution. > > > > > > In current Isar implementation, multiconfig file contains > > > hardcoded version for boot files: kernel and initrd. This is used > > > for both: > > > > > > - Add respective package to multistrap config. > > > - Copy boot files to deploy directory. > > > > > > This series drops this hardcoded versions, so now Isar is able to > > > determine version of boot files during building. > > > > > > Changes since v1: > > > - Differentiate 'do_copy_boot_files' stamps. > > > - Update start_vm script accordingly. > > > - Check if symlinks 'vmlinuz' and 'initrd.img' exist before > > > reading them. If symlink doesn't exist, this function skips it. > > > > > > With best regards, > > > Alex > > > > > > > > > *** BLURB HERE *** > > > > > > Alexander Smirnov (2): > > > meta-isar: Drop hardcoded kernel versions > > > meta-isar: Rework boot files copying > > > > > > meta-isar/conf/multiconfig/qemuamd64-jessie.conf | 5 +---- > > > meta-isar/conf/multiconfig/qemuamd64-stretch.conf | 5 +---- > > > meta-isar/conf/multiconfig/qemuarm-jessie.conf | 5 +---- > > > meta-isar/conf/multiconfig/qemuarm-stretch.conf | 5 +---- > > > meta-isar/conf/multiconfig/qemuarm-wheezy.conf | 5 +---- > > > meta-isar/conf/multiconfig/qemui386-jessie.conf | 5 +---- > > > meta-isar/conf/multiconfig/qemui386-stretch.conf | 5 +---- > > > meta-isar/conf/multiconfig/rpi-jessie.conf | 3 --- > > > meta/classes/ext4-img.bbclass | 8 -------- > > > meta/classes/image.bbclass | 24 > > > ++++++++++++++++++++--- > > > scripts/start_vm | 8 ++++++-- 11 > > > files changed, 34 insertions(+), 44 deletions(-) > > > > > >