From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6478661911279828992 X-Received: by 10.28.150.130 with SMTP id y124mr276694wmd.22.1508431219783; Thu, 19 Oct 2017 09:40:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.10.83 with SMTP id 80ls1505467wmk.1.canary-gmail; Thu, 19 Oct 2017 09:40:19 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SMrOsfb3Lr4kYIgrxib5RIaHRpvIlRB5LgZ9Bn+kZslMLeUvdOkeI8vHTtvhX0UkOFfwq+ X-Received: by 10.28.63.130 with SMTP id m124mr283031wma.20.1508431219525; Thu, 19 Oct 2017 09:40:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508431219; cv=none; d=google.com; s=arc-20160816; b=r7hemmz2DCZz3S018BsAQVRYavaSU+MG6TvJheXZZC6W3dR9ycYC49Uo6fZ2+MHDI+ ssMgepAOrLYHZie6S3W/tgjB/paZgEErgXOgG/oAUmwpJtZXySVQFX2cU/zYQKh9zqOW CAukct+5BQzMh+nb7IXtOKMOr9wHZSSlel/jWzqbOn6Xk960hB8Uu24BFr44wr0RW1nt ztpAt1wW5EIwkpiUe5HOvlTNe/MF5untwJlU1JUNjdbARTrjUn6lf89QmOE8G343iHH4 qF6e7eb1affE5566zee8kg2IuZU/PaVGGJyjMgPE5nmDrEpq/ZGmPrA1J9j8QKc4a+1A OGdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:arc-authentication-results; bh=UiiI/KZoPVU5f1zZvb9gqAATFQfmp5jbrtt27IfJRKo=; b=y5IZaAACBSL3LjFkT81uAE6lwKJX77XxmEG7aIYt/LiKzoz1jKlQ2MvnrXQDPvhWyV cz8VPdnEEcaCHEIkOTVC7QUa2Cc5RGg2gm28YkJXvtiWmwq+fW1tppNompH+PocsseVI YpnVp+05OB/yfdGHPdBXSz7pbhcY4b3gCwXAJOtrRayNA3fUJeosF7Kf/AIQmQKzZyoE Q3vQ7R6fw4tQj22G3aasVSY5fkBszm4pwA1EyZjaQjMiIx2GtLDnkr12q1KQcdeFkt8W /gl9ikfxQSwtHf4/pUE72Dh4+05jWhqQEFsAmIFRYv+c8D1X+0B86teZFCq7XYG3/Q5h V7bQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id e29si610146wrg.2.2017.10.19.09.40.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 09:40:19 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v9JGeJ02021721 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 19 Oct 2017 18:40:19 +0200 Received: from md1em3qc ([139.25.68.40]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id v9JGeIcE015093 for ; Thu, 19 Oct 2017 18:40:18 +0200 Date: Thu, 19 Oct 2017 18:40:17 +0200 From: Henning Schild To: Subject: Re: [PATCH] multistrap: do not ignore multistrap errors anymore Message-ID: <20171019184017.44c11095@md1em3qc> In-Reply-To: <20171019163659.15289-1-henning.schild@siemens.com> References: <20171019163659.15289-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: CB5tsMKFKZyU On Thu, 19 Oct 2017 18:36:59 +0200 Henning Schild wrote: > Issue: Isar problems are often hard to debug and often enough you > wonder why configscript.sh is not there. In that case the real > problem always is in multistrap actually failing and Isar ignoring > the return value. > > Change: Do not ignore the return value of multistrap anymore. > > Impact: Debugging should become much easier, the last error message > will be the actual error message. Whoever put that "|| true" there probably had a reason to do so. The multistrap manpage says something about accumulating also warnings and adding them up in the return value. That might be the reason for ignoring the output of such an essential step. However, i could just build an image with this patch applied. Henning > Signed-off-by: Henning Schild > --- > meta-isar/recipes-core/images/isar-image-base.bb | 2 +- > meta/recipes-devtools/buildchroot/buildchroot.bb | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb > b/meta-isar/recipes-core/images/isar-image-base.bb index > 121b586..7e36e22 100644 --- > a/meta-isar/recipes-core/images/isar-image-base.bb +++ > b/meta-isar/recipes-core/images/isar-image-base.bb @@ -55,7 +55,7 @@ > do_rootfs() { sudo mount -t proc none ${IMAGE_ROOTFS}/proc > > # Create root filesystem > - sudo multistrap -a ${DISTRO_ARCH} -d "${IMAGE_ROOTFS}" -f > "${WORKDIR}/multistrap.conf" || true > + sudo multistrap -a ${DISTRO_ARCH} -d "${IMAGE_ROOTFS}" -f > "${WORKDIR}/multistrap.conf" > # Configure root filesystem > sudo chroot ${IMAGE_ROOTFS} /${DISTRO_CONFIG_SCRIPT} > ${MACHINE_SERIAL} ${BAUDRATE_TTY} \ diff --git > a/meta/recipes-devtools/buildchroot/buildchroot.bb > b/meta/recipes-devtools/buildchroot/buildchroot.bb index > 452536f..3e5c0ac 100644 --- > a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ > b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -55,7 +55,7 @@ > do_build() { sudo mount -t proc none ${IMAGE_ROOTFS}/proc > # Create root filesystem > - sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f > "${WORKDIR}/multistrap.conf" || true > + sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f > "${WORKDIR}/multistrap.conf" > # Install package builder script > sudo install -m 755 ${THISDIR}/files/build.sh ${BUILDCHROOT_DIR}