From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.223.171.237 with SMTP id s100mr280997wrc.31.1508436293758; Thu, 19 Oct 2017 11:04:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.93.144 with SMTP id r138ls1535776wmb.12.canary-gmail; Thu, 19 Oct 2017 11:04:53 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Tojywwu5Y6M75C4AkOIHWzeUSAZNYfKFf63R3wUVx0DyJJBeB/censgEX/rDWGvYwE6DOV X-Received: by 10.223.191.9 with SMTP id p9mr259026wrh.6.1508436293487; Thu, 19 Oct 2017 11:04:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508436293; cv=none; d=google.com; s=arc-20160816; b=cOFhYaBY/WS9f0s7vBrGB1YRsDafSSDVqU7cLYWTyQN7E+9eLd9ASOPYZX1MXDA/8p XBH+S0zRAvVug5oStOs5t+RKtStF9plvRTWjW0xquPy0rRBRJpnbZtHx5HTHZASYnZvD oxVtPg4IXwAGgQiy2H4qkvH6ebVfdC/H5VOUqWHfatTFVuEWXLTjn8rgPeFNgx/lHce8 L8xA12GLq6K7nGYOhX03kLTEf7bTB2ycez9gEluqZ68HW2T+zqXNojOR3ddpyuHtJxVB J/HfyqUC9hxVs/6xGAIDS3j50I7MlGXYGeO4qhh5I395SvbzGxnONWVryqiH3d378JTj xhbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:arc-authentication-results; bh=fbOhG3BInvN8gbCY+5T9v9nKddwFuL2BPb33Jp2ZE/w=; b=fCD8RzLvd3CSx/OaGyMOGi8GtFz5fKz/TG2KHSOXqOje4To+ADIwT8DXOsUf+dwNiE 395UgP2u2eQ7zptxCnz0Qa+dfm84uxebeSFZm2FFj3MJMtVghcwfSSqR3IMx4L0DnDhk +5vgVdrBrlQyedfrjUTsnA90inHWC5XRGD1H/X/eFDUFXBfLJfRKYSgFmt2+f0cBARHY GOXtIlGY9r24zbvfvwaHjRiCKPpulSEjXMW5cerlVKNxRWvtBszge4NjdtXM3AbBMQQV zPOzqTBDNVyxYWRcg56y6YAWcP2THENNQIhDH+lxaNcg9FSjCrRH8TjP6027jZV0qM1w dTjQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id l9si827041wrf.4.2017.10.19.11.04.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 11:04:53 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v9JI4qTh024417 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Oct 2017 20:04:52 +0200 Received: from md1em3qc ([139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id v9JI4pKW027110; Thu, 19 Oct 2017 20:04:52 +0200 Date: Thu, 19 Oct 2017 20:04:50 +0200 From: Henning Schild To: , Alexander Smirnov , Baurzhan Ismagulov Subject: Re: [PATCH 01/16] meta: ext4-img: copy and keep attributes, always copy with sudo Message-ID: <20171019200450.75759e7e@md1em3qc> In-Reply-To: <5e98880f61dba959ada0c9bc8feca65b0a5760e5.1501582237.git.henning.schild@siemens.com> References: <5e98880f61dba959ada0c9bc8feca65b0a5760e5.1501582237.git.henning.schild@siemens.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: fqecTpNRWo+t I just wasted another hour on that guy ... again. Now i found an easy way to reproduce the issue on amd64 IMAGE_PREINSTALL += "dropbear" Probably something in the package hooks, update-initramfs ... But who cares, that could have been fixed months ago. Since my original patch touches code that Alex is currently moving around i hope he will fix the issue that has been ignored for too long. Henning On Tue, 1 Aug 2017 12:17:19 +0200 Henning Schild wrote: > Some security enhancing packages can cause our initrd to be not > readable by a normal user. So we need to copy with sudo. > Also regular cp would destroy ownership and other attributes of files, > possibly creating problems in the future. > > Signed-off-by: Henning Schild > --- > meta/classes/ext4-img.bbclass | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/ext4-img.bbclass > b/meta/classes/ext4-img.bbclass index 65d4c11..6dc2039 100644 > --- a/meta/classes/ext4-img.bbclass > +++ b/meta/classes/ext4-img.bbclass > @@ -21,16 +21,16 @@ do_ext4_image() { > > mkdir -p ${WORKDIR}/mnt > sudo mount -o loop ${EXT4_IMAGE_FILE} ${WORKDIR}/mnt > - sudo cp -r ${S}/* ${WORKDIR}/mnt > + sudo cp -a ${S}/* ${WORKDIR}/mnt > sudo umount ${WORKDIR}/mnt > rm -r ${WORKDIR}/mnt > > if [ -n "${KERNEL_IMAGE}" ]; then > - cp ${S}/boot/${KERNEL_IMAGE} ${DEPLOY_DIR_IMAGE} > + sudo cp -a ${S}/boot/${KERNEL_IMAGE} ${DEPLOY_DIR_IMAGE} > fi > > if [ -n "${INITRD_IMAGE}" ]; then > - cp ${S}/boot/${INITRD_IMAGE} ${DEPLOY_DIR_IMAGE} > + sudo cp -a ${S}/boot/${INITRD_IMAGE} ${DEPLOY_DIR_IMAGE} > fi > } >