Re: [PATCH] image: copy INITRD_IMAGE out with sudo

[Henning Schild <henning.schild@siemens.com>]

This patch was previously discussed as
[PATCH] meta: ext4-img: copy and keep attributes, always copy with sudo

This time it is just the sudo for the initrd. No "cp -a" and nothing
else is copied with sudo. And dropbear is provided as an example.

Henning

Am Mon, 30 Oct 2017 17:55:34 +0100
schrieb Henning Schild <henning.schild@siemens.com>:

> Issue: do_copy_boot_files can fail to read initrd if certain packages
> are installed in the image. One example package causing that issue is
> "dropbear", it is probably connected with the initrd being rebuild
> during installation. The file will have mode 0600 instead of the
> expected 0644.
> 
> Fix: use sudo to copy the file
> 
> Impact: There is one more sudo in the Isar codebase. People that faced
> the issue are now be able to build their images, others will not see a
> difference.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 4bfd39c..2c2bafc 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -92,7 +92,7 @@ do_copy_boot_files() {
>  
>      INITRD_IMAGE=${@get_image_name(d, 'initrd.img')}
>      if [ -n "${INITRD_IMAGE}" ]; then
> -        cp -f ${IMAGE_ROOTFS}/boot/${INITRD_IMAGE}
> ${DEPLOY_DIR_IMAGE}
> +        sudo cp -f ${IMAGE_ROOTFS}/boot/${INITRD_IMAGE}
> ${DEPLOY_DIR_IMAGE} fi
>  }
>