Re: [PATCH] build.sh: Fix perl complaints about locale

[Christian Storm <christian.storm@siemens.com>]

> On 11/13/2017 03:21 PM, Christian Storm wrote:
> > The log.do_build is flooded by perl's locale complaints:
> > 
> >      perl: warning: Setting locale failed.
> >      perl: warning: Please check that your locale settings:
> >              LANGUAGE = (unset),
> >              LC_ALL = "en_US.UTF-8",
> >              LANG = (unset)
> >          are supported and installed on your system.
> >      perl: warning: Falling back to the standard locale ("C").
> > 
> > Make perl happy by explicitly giving it the C locale.
> > 
> > Signed-off-by: Christian Storm <christian.storm@siemens.com>
> > ---
> >   meta/recipes-devtools/buildchroot/files/build.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-devtools/buildchroot/files/build.sh b/meta/recipes-devtools/buildchroot/files/build.sh
> > index 19d554e..e53d359 100644
> > --- a/meta/recipes-devtools/buildchroot/files/build.sh
> > +++ b/meta/recipes-devtools/buildchroot/files/build.sh
> > @@ -23,4 +23,4 @@ for i in configure aclocal.m4 Makefile.am Makefile.in; do
> >   done
> >   
> >   # Build the package
> > -dpkg-buildpackage
> > +LC_ALL=C LANGUAGE=C LANG=C dpkg-buildpackage
> > 
> 
> There is code that should setup locales for current buildchroot:
> 
> https://github.com/ilbers/isar/blob/master/meta/recipes-devtools/buildchroot/files/configscript.sh#L8
> 
> So it would be nice to fix this globally instead of local solution. 

Sure, but this alone doesn't solve the problem as you have to put the
locale into every (sudo) environment. Then, what about

--- a/meta/recipes-devtools/buildchroot/files/build.sh
+++ b/meta/recipes-devtools/buildchroot/files/build.sh
@@ -3,6 +3,8 @@
 # This software is a part of ISAR.
 # Copyright (C) 2015-2017 ilbers GmbH
 
+[ -r /etc/default/locale ] && . /etc/default/locale
+
 # Go to build directory
 cd $1
 
--

for which I could send a patch if this is OK for you..


> BTW, which target distro do you use, Stretch? I already have this
> issue in todo list, but you are welcome to fix this. :-)

Yes, stretch.



Besten Gru�,
   Christian

-- 
Dr. Christian Storm
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Otto-Hahn-Ring 6, 81739 M�nchen, Germany