Re: [PATCH] build.sh: Fix perl complaints about locale

[Christian Storm <christian.storm@siemens.com>]

> >>> [...]
> >>>
> >>> Not sure what "ignorenativearch" does, but "sed /etc/locale.gen &&
> >>> locale-gen" is clearer and probably free of side-effects. Are we
> >>> sure about all implications of ignorenativearch?
> >>
> >> To be honest, I don't exactly know what multistrap does in native
> >> mode (to be investigated), but with "ignorenativearch=true" we can
> >> guarantee that Isar has the same build flow for *all* the
> >> architectures. Otherwise we will have 2 possible flows: for native
> >> arch and for foreign archs, what could be the source of potential
> >> bugs like we have now with locales.
> > 
> > True, but without that knowledge and looking at the one issue, i would
> > prefer that patch that i understand ;).
> > 
> 
> Yeah, but on the other hand:
>   - There is dedicated code which should setup locales, seems it's
>   broken in master for native builds now.
>   - Instead of fixing it, yet another locale setup is proposed.

Well, strictly speaking, it's not yet another locale setup. If you do
the `sed` and `dpkg-reconfigure locale` it's merely an explicit setup,
more of the same so to say. The `dpkg --configure -a` at the bottom of
configscript.sh may not *re-*configure a (wrongly) configured locale
package.

>   - This new locale setup affects already working builds.

Yes, to the extent that after locale setup, a *re-*configure is
explicitly triggered. Shouldn't be a problem but instead intended
behavior as you may have changed the locale in configscript.sh above
this line nonetheless.

>   - Old locale stays in the tree.

With my commit
  ec997ad "isar-image-base: purge locales and installed packages' .deb",
unused locale are purged. Or didn't I get the point here?

> So, for me it would be better to spend a few hours to understand 
> 'ignorenativearch' option before taking any decision. I'd happy to this :-)

Independently of the issue at hand, this is a very welcome proposal of
yours! I'd like to hear the results...

That said, from a quick multistrap manpage glimpse, I read
"A native multistrap can be used directly with chroot, so "multistrap"
 runs "dpkg --configure -a" at the end of the multistrap process, unless
 the ignorenativearch option is set to true in the General section of the
 configuration file."

So, on native multistrap, `dpkg --configure -a` is run if ignorenativearch=false.
Otherwise, if ignorenativearch=true, it's not run.
However, `dpkg --configure -a` is run unconditionally in configscript.sh...


Besten Gru�,
   Christian

-- 
Dr. Christian Storm
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Otto-Hahn-Ring 6, 81739 M�nchen, Germany