public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Christian Storm <christian.storm@siemens.com>
To: isar-users@googlegroups.com
Subject: Re: download_dev-random hook question
Date: Mon, 20 Nov 2017 11:00:54 +0100	[thread overview]
Message-ID: <20171120100054.p3x5t4csvavcpkyv@MD1KR9XC.ww002.siemens.net> (raw)
In-Reply-To: <20171120104138.42466b1d@md1em3qc>

> > > I just stumbled over the download_dev-random multistrap hook:
> > > Why is it that you only create /dev/{,u}random?
> > > Why not also create other essential files like /dev/{null,zero}
> > > as well [...]  
> > 
> > ... and, a further question that just came to my mind: Why is this
> > handled in a multistrap hook in the first place? Seems rather
> > implicit to me. Why not do it explicitly in buildchroot.bb and
> > isar-image-base.bb?
> 
> Is a hook not explicit? I do not get the point. 

It depends :)

In my opinion it's not explicit as /dev node generation is kind of a
side-effect of running multistrap realized via its hooks. If multistrap
would have done it anyway without us placing the hook in there, fine.
But we're placing a hook script in multistrap that does the work -
which could as well be done in do_build(), there named explicitly as
/dev node generation. If I wanted to know how/where /dev node generation
is done, there's as of now one more indirection in terms of the
multistrap hook. That said, I'm not strongly opinionated on this as I
guess it's mostly a matter of taste though...


> Using a script outside of do_build even allows for sharing between the
> two users. 

Yes, but this is also true if this external script is called from within
the two do_builds, explicitly.


> And these two recipes should probably be deduplicated one day.

Yes, I agree but that's another issue...



   Christian

-- 
Dr. Christian Storm
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Otto-Hahn-Ring 6, 81739 M�nchen, Germany

      reply	other threads:[~2017-11-20 10:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 16:35 Christian Storm
2017-11-13 18:09 ` Henning Schild
2017-11-14  9:06   ` [ext] Christian Storm
2017-11-16  9:04 ` [ext] Christian Storm
2017-11-16  9:19   ` Alexander Smirnov
2017-11-16  9:41     ` Christian Storm
2017-11-16  9:49       ` Alexander Smirnov
2017-11-16 10:04         ` Christian Storm
2017-11-20  9:41   ` Henning Schild
2017-11-20 10:00     ` Christian Storm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171120100054.p3x5t4csvavcpkyv@MD1KR9XC.ww002.siemens.net \
    --to=christian.storm@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox