From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6487938995161399296 X-Received: by 10.28.7.75 with SMTP id 72mr1333508wmh.23.1511172134498; Mon, 20 Nov 2017 02:02:14 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.120.3 with SMTP id t3ls853762wmc.5.canary-gmail; Mon, 20 Nov 2017 02:02:14 -0800 (PST) X-Google-Smtp-Source: AGs4zMaogf3uU4oPDTR6aPxceuRGRbWZ9IyDXfZeSS3FhaNpH/venw1bRdMOZ9+uXWMYyTeIcs07 X-Received: by 10.28.190.16 with SMTP id o16mr1032868wmf.22.1511172134081; Mon, 20 Nov 2017 02:02:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511172134; cv=none; d=google.com; s=arc-20160816; b=qAG22x0oEmPx0TRmIQbgfEvCS3E+6MwAY7QW4t9x4yEjVmcbVGeD8SlChBVjZ2PQSu ihd7/Aza9UdxL9qq5XZVoiqn+uvVu4wYgosDeXplMazR5q4UhZYKzXcXEx1ioYvn8RX+ KObtHx6c6IvHFc3RvyXyK84kUrBnocDWLdrJrwbh20XfVQya7sDL9UciEWOJOpD+fLq9 6tOQP1OVjaJOxwyTi4c64RmpbKr9OSyxgmthrelqTlizO0thNYGfcNbyk/E+nO5xI4BR 5sn64eDFmnxgArwdh2U1ctP0J5tLQGYAATVfOIlixzUCwVEde76tUp+IQrSwlJwXUPoi WvvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:mail-followup-to:message-id :subject:to:from:date:arc-authentication-results; bh=V9A8xWH/g8mvZhnmp0Lg66KxH7NaW3zegqY4ZRYQXFY=; b=nHWVMkUo5p4yNf6GbH4qx43KwLUI64qieIQfmdBLkDr0GEW8r39klLGPMhJOPnxswR ymVpXWdU7LBCshecAPreVQ6u8wHkipm0ZB1N0wgRRIQ1Yb+Xaq/Ynbqlm3dQTaBSgk5A YnJH4ljRvFOJDqd4XPecvovlgfjM2zFUf2e8apYdDFr9v/scCaVnaF58yo1AFU1TVmkM SnvLKu3vQcSIAnGPxF82Kwb6iIic6AbeJuC6ELHaCn01Po4uPlzG2n1Oool0wigx90Ch K571Hy+g7vWsVz2V126rAwjIems5cv3ScNzwQ+pGhGZvkrDpUZ2NVBFHkz7B8zQ+1jo0 lkeA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id z15si249670wmc.3.2017.11.20.02.02.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2017 02:02:14 -0800 (PST) Received-SPF: pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of christian.storm@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=christian.storm@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id vAKA2D3D020444 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 20 Nov 2017 11:02:13 +0100 Received: from localhost ([139.25.69.251]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTPS id vAKA2DVZ003521 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 20 Nov 2017 11:02:13 +0100 Date: Mon, 20 Nov 2017 11:00:54 +0100 From: Christian Storm To: isar-users@googlegroups.com Subject: Re: download_dev-random hook question Message-ID: <20171120100054.p3x5t4csvavcpkyv@MD1KR9XC.ww002.siemens.net> Mail-Followup-To: isar-users@googlegroups.com MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171120104138.42466b1d@md1em3qc> User-Agent: Mutt/20170113 (1.7.2) X-TUID: FQ5vQmFtyXam > > > I just stumbled over the download_dev-random multistrap hook: > > > Why is it that you only create /dev/{,u}random? > > > Why not also create other essential files like /dev/{null,zero} > > > as well [...] > > > > ... and, a further question that just came to my mind: Why is this > > handled in a multistrap hook in the first place? Seems rather > > implicit to me. Why not do it explicitly in buildchroot.bb and > > isar-image-base.bb? > > Is a hook not explicit? I do not get the point. It depends :) In my opinion it's not explicit as /dev node generation is kind of a side-effect of running multistrap realized via its hooks. If multistrap would have done it anyway without us placing the hook in there, fine. But we're placing a hook script in multistrap that does the work - which could as well be done in do_build(), there named explicitly as /dev node generation. If I wanted to know how/where /dev node generation is done, there's as of now one more indirection in terms of the multistrap hook. That said, I'm not strongly opinionated on this as I guess it's mostly a matter of taste though... > Using a script outside of do_build even allows for sharing between the > two users. Yes, but this is also true if this external script is called from within the two do_builds, explicitly. > And these two recipes should probably be deduplicated one day. Yes, I agree but that's another issue... Christian -- Dr. Christian Storm Siemens AG, Corporate Technology, CT RDA ITP SES-DE Otto-Hahn-Ring 6, 81739 M�nchen, Germany