From: Henning Schild <henning.schild@siemens.com>
To: Alexander Smirnov <asmirnov@ilbers.de>
Cc: <isar-users@googlegroups.com>,
"Christian Storm" <christian.storm@siemens.com>
Subject: Re: [PATCH 1/3] dpkg-base: Fix buildchroot dependency
Date: Tue, 21 Nov 2017 20:10:27 +0100 [thread overview]
Message-ID: <20171121201027.197aec5e@md1em3qc> (raw)
In-Reply-To: <20171121184940.5425-2-asmirnov@ilbers.de>
Am Tue, 21 Nov 2017 21:49:38 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> Existing code forces recipe to depends from 'do_build' task for all
> the items listed in DEPENDS, what actually makes no sense. This task
> only produces binary deb package and it can't satisfy any dependencies
> for another task.
With DEPENDS you would also say that application1 that you build in
buildchroot needs lib1 and lib2 and buildtool3, and you have recipes
for all of those (they are not upstream debian).
Now requiring .debs makes some sense because now the "apt-get install
-y $DEPS" could actually install them in buildchroot. I do not think
that works at the moment, because the Isar repo is not in buildchroot
multistrap.
Technically both versions are wrong, so applying that patch does not
seem to improve the situation.
We need an example of two packages from Isar that actually DEPEND on
each other in buildchroot. I think Christian has patches for that
problem.
Henning
> Original idea was to add dependency from 'buildchroot:do_build' task,
> so this patch fixes this.
>
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
> meta/classes/dpkg-base.bbclass | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/classes/dpkg-base.bbclass
> b/meta/classes/dpkg-base.bbclass index 35af6d5..4941f9b 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -2,8 +2,7 @@
> # Copyright (C) 2017 Siemens AG
>
> # Add dependency from buildchroot creation
> -DEPENDS += "buildchroot"
> -do_build[deptask] = "do_build"
> +do_build[depends] = "buildchroot:do_build"
>
> # Each package should have its own unique build folder, so use
> # recipe name as identifier
next prev parent reply other threads:[~2017-11-21 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 18:49 [PATCH 0/3] Improvements Alexander Smirnov
2017-11-21 18:49 ` [PATCH 1/3] dpkg-base: Fix buildchroot dependency Alexander Smirnov
2017-11-21 19:10 ` Henning Schild [this message]
2017-11-21 19:33 ` Alexander Smirnov
2017-11-22 7:13 ` Christian Storm
2017-11-21 18:49 ` [PATCH 2/3] image: Add do_rootfs template to image class Alexander Smirnov
2017-11-21 18:49 ` [PATCH 3/3] buildchroot: Add prepare and cleanup tasks Alexander Smirnov
2017-11-21 19:15 ` Henning Schild
2017-11-21 19:36 ` Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121201027.197aec5e@md1em3qc \
--to=henning.schild@siemens.com \
--cc=asmirnov@ilbers.de \
--cc=christian.storm@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox