From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6490941990528614400 X-Received: by 10.80.244.178 with SMTP id s47mr5854319edm.6.1511291410550; Tue, 21 Nov 2017 11:10:10 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.241.28 with SMTP id w28ls596092edl.0.gmail; Tue, 21 Nov 2017 11:10:10 -0800 (PST) X-Google-Smtp-Source: AGs4zMaTtTLrS9Na1wfuj8v9PGRJEMdLRxI1R+QKGHmnxFHJ/Pgd2ttF4vs7ggJu9oIXg6vtVKjM X-Received: by 10.80.145.246 with SMTP id h51mr5911007eda.10.1511291410383; Tue, 21 Nov 2017 11:10:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511291410; cv=none; d=google.com; s=arc-20160816; b=Cdwq7M9Ss1FZtAhoAtmxZsJMGjGno8WnZaA4Hz/zwFSWGk804wgQLtfwqDr/qNkhD6 84imKRRiEbXTENHpjr67RGs4aiiJNqtdVaq8V1NfYoV+OVABzOqfKindq6A3sB02+epp wfaKumUyeaF82ax1FJeM8VY42iqRwkKdBUp55XO7sGhiO9/gjRozLMUaO04D5w+HOLrF 5j0nZ1kXo9Z+Ukd6G7z1Rfy4FxvED5LTiIxBsrHfsJJdAPF0MA0Vtlltd8xdi3ftoe3z Un0bGRUWGueimVhgcuqv8Oo9z9qjIPUa4wgHeiWNJ5JHX0cvBbI3ogF0yYuTbVsP6kNw ul6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=cUpMVwjXWKgSi1vd05wVG3ycpxTOmlqT2eEq4BVgmTo=; b=JS9u4HE8PhIZsTUmjDUbajxhq3WdbYigSj6xhyrRusv5m84ey5UiOUX6CtbCOfrGa3 ITesy+38qNLGIZmPW0wIt3LjP5AxVZpkli/9YDTgY4AO90gyh3AshsrCfvdK66Vk3VZe edtDQ46Sp2GVevJU4ZXzzjSKN4VBD2uHrauNCHVAcG1J738jeYM38wGnrUE5V+vWUuIN 38mUEzqR9Z+BAGZVKYQPcaMxGAcwKyYZO7/9du99lToo1yyGg2nrcBWJe0ghGGeqAf0Y ESAKXyRTCpMCgkeUmOWAz7Nk6rOS5daueEJf2a7nW9oBGHGzql9lmjQmNDiL9OPq/In7 p2hg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id q7si1204328edd.0.2017.11.21.11.10.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2017 11:10:10 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id vALJAAJc005716 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2017 20:10:10 +0100 Received: from md1em3qc ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id vALJA9lO001109; Tue, 21 Nov 2017 20:10:09 +0100 Date: Tue, 21 Nov 2017 20:10:27 +0100 From: Henning Schild To: Alexander Smirnov Cc: , "Christian Storm" Subject: Re: [PATCH 1/3] dpkg-base: Fix buildchroot dependency Message-ID: <20171121201027.197aec5e@md1em3qc> In-Reply-To: <20171121184940.5425-2-asmirnov@ilbers.de> References: <20171121184940.5425-1-asmirnov@ilbers.de> <20171121184940.5425-2-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: BcAeX1QiijH9 Am Tue, 21 Nov 2017 21:49:38 +0300 schrieb Alexander Smirnov : > Existing code forces recipe to depends from 'do_build' task for all > the items listed in DEPENDS, what actually makes no sense. This task > only produces binary deb package and it can't satisfy any dependencies > for another task. With DEPENDS you would also say that application1 that you build in buildchroot needs lib1 and lib2 and buildtool3, and you have recipes for all of those (they are not upstream debian). Now requiring .debs makes some sense because now the "apt-get install -y $DEPS" could actually install them in buildchroot. I do not think that works at the moment, because the Isar repo is not in buildchroot multistrap. Technically both versions are wrong, so applying that patch does not seem to improve the situation. We need an example of two packages from Isar that actually DEPEND on each other in buildchroot. I think Christian has patches for that problem. Henning > Original idea was to add dependency from 'buildchroot:do_build' task, > so this patch fixes this. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/dpkg-base.bbclass | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index 35af6d5..4941f9b 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -2,8 +2,7 @@ > # Copyright (C) 2017 Siemens AG > > # Add dependency from buildchroot creation > -DEPENDS += "buildchroot" > -do_build[deptask] = "do_build" > +do_build[depends] = "buildchroot:do_build" > > # Each package should have its own unique build folder, so use > # recipe name as identifier