From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6470427481174179840 X-Received: by 10.25.25.71 with SMTP id 68mr1950342lfz.29.1512756609321; Fri, 08 Dec 2017 10:10:09 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.33.148 with SMTP id h20ls316002lji.3.gmail; Fri, 08 Dec 2017 10:10:08 -0800 (PST) X-Google-Smtp-Source: AGs4zMa1OXRYpIOEYXFMAg77rGvB/Do58va/Okj1L6oP4LKfHqEnfR6z1om4Z6sqv5Mg+g9BGXSu X-Received: by 10.46.116.16 with SMTP id p16mr2215049ljc.0.1512756608823; Fri, 08 Dec 2017 10:10:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512756608; cv=none; d=google.com; s=arc-20160816; b=ur+0MjxKeA8kfiDGlqeDT050+sNVIkLaR71RH5jRBAAvbjHxAwND7KLrr3QElzaVOY 6g2nzAY5+0nHHm9MrM3obxmB2QugMQG4iI60GQkGdlv6Q2yzKCUbyeh2zshvkX/R/iFN CWRxswiHlIYOsryGNKhzMpHx5AVpNlLN1VpyKfV5zn+LYhytGvLMpDVlrQO8CjCEZ86b 5Er0Ka0vml5/OnQYx41XMOzDTeY9n38fOZSwBah/B/6LcJKrpxk/sM6UAcCkbBV+Uixi AonyTADFtk9+pyE8I06OAWt3vCZPLT1ksEa099Ncve14CU7CMOBHRnPXA2LGpgh7zh7f Jtxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=B7A+g5xT3a2K0TeB/PAKOjMMtf8zTRMUqTr15gP2gCU=; b=Ios4MH4l+ZPwvCVYZIEj01PyD/xa0zYkuUOGZqxjAejU+EgG4fZsbE4oZPAq/+VrUP rxvTBUSLaXT7xCP9WogN9K3Vx09pQTkdWkS+T9UPwefYMSjX6gPfl+GBu78am4bA/etB t+55lw17ko2C+GUxrarsURwQ1fA7S43aqpcs0zb8CeVrlx5eV3MCn/kFdOhkPUEQIeqc Yg1/m7W1AsM8zDJAxGA8VXt0tO/b2PRjz02hCvZBW3gjiuPvdAijVub+vo57dthMFTAQ q3AXTtcoLr+O7WxlrRv/z6VLbnUmniPACr1XP+VinG9QoOB0VY8CCywDALKwn7BqYGNS pD4Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id i8si734803lfl.3.2017.12.08.10.10.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Dec 2017 10:10:08 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id vB8IA7Hf028879 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Dec 2017 19:10:07 +0100 Received: from md1em3qc (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id vB8IA7IL003801; Fri, 8 Dec 2017 19:10:07 +0100 Date: Fri, 8 Dec 2017 19:10:06 +0100 From: Henning Schild To: "[ext] Andreas J. Reichel" , Alexander Smirnov Cc: , Subject: Re: [PATCH v2 1/1] Add proxy support to isar-image-*.bb and buildchroot.bb Message-ID: <20171208191006.2c323ff9@md1em3qc> In-Reply-To: <20170927120234.1541-2-andreas.reichel.ext@siemens.com> References: <20170927120234.1541-1-andreas.reichel.ext@siemens.com> <20170927120234.1541-2-andreas.reichel.ext@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: aF+0+5rMSAYg Alex, could you please merge this patch or comment on it. I had some comments and after that the process stopped. However i do not have any objections to this version. Henning Am Wed, 27 Sep 2017 14:02:18 +0200 schrieb "[ext] Andreas J. Reichel" : > From: Andreas Reichel > > * BB_ENV_EXTRAWHITE provides a list for variables that are kept in the > environment by bitbake. However, isar init script clears any > additional settings. Thus, add proxy variables to BB_ENV_EXTRAWHITE in > isar-buildenv-internal. > > * Bitbake clears environment variables for each task within a recipe. > However, bb.utils.export_proxies function can be used with an > inline-python call to reexport the proxy settings. > > * Sudo loses environment variables again, thus call multistrap with > sudo with the -E option to preserve (the already cleaned) environment > for the task's multistrap command. > > Note: > Downloads are normally done by the fetcher task, which calls a python > function that in turn uses bb.util.export_proxies. However we have a > non-fetcher task, which needs download capabilities as well. > > Signed-off-by: Andreas Reichel > --- > meta-isar/recipes-core/images/isar-image-base.bb | 5 ++++- > meta/recipes-devtools/buildchroot/buildchroot.bb | 4 +++- > scripts/isar-buildenv-internal | 2 +- > 3 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb > b/meta-isar/recipes-core/images/isar-image-base.bb index > b679d97..96b5510 100644 --- > a/meta-isar/recipes-core/images/isar-image-base.bb +++ > b/meta-isar/recipes-core/images/isar-image-base.bb @@ -24,6 +24,8 @@ > IMAGE_ROOTFS = "${S}" do_rootfs[stamp-extra-info] = > "${MACHINE}-${DISTRO}" > do_rootfs() { > + E="${@ bb.utils.export_proxies(d)}" > + > install -d -m 755 ${WORKDIR}/hooks_multistrap > > # Copy config file > @@ -46,7 +48,8 @@ do_rootfs() { > cd ${TOPDIR} > > # Create root filesystem > - sudo multistrap -a ${DISTRO_ARCH} -d "${S}" -f > "${WORKDIR}/multistrap.conf" || true > + # We must use sudo -E here to preserve the environment because > of proxy settings > + sudo -E multistrap -a ${DISTRO_ARCH} -d "${S}" -f > "${WORKDIR}/multistrap.conf" || true > # Configure root filesystem > sudo chroot ${S} /configscript.sh ${MACHINE_SERIAL} > ${BAUDRATE_TTY} \ diff --git > a/meta/recipes-devtools/buildchroot/buildchroot.bb > b/meta/recipes-devtools/buildchroot/buildchroot.bb index > ccba683..e251a8f 100644 --- > a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ > b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -26,6 +26,8 @@ > WORKDIR = "${TMPDIR}/work/${PF}/${DISTRO}" do_build[stamp-extra-info] > = "${DISTRO}-${DISTRO_ARCH}" do_build() { > + E="${@ bb.utils.export_proxies(d)}" > + > install -d -m 755 ${WORKDIR}/hooks_multistrap > > # Copy config files > @@ -48,7 +50,7 @@ do_build() { > cd ${TOPDIR} > > # Create root filesystem > - sudo multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f > "${WORKDIR}/multistrap.conf" || true > + sudo -E multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f > "${WORKDIR}/multistrap.conf" || true > # Install package builder script > sudo install -m 755 ${THISDIR}/files/build.sh ${BUILDCHROOT_DIR} > diff --git a/scripts/isar-buildenv-internal > b/scripts/isar-buildenv-internal index f14d1ff..94d7eb1 100755 > --- a/scripts/isar-buildenv-internal > +++ b/scripts/isar-buildenv-internal > @@ -66,5 +66,5 @@ export PATH > BBPATH="${BUILDDIR}" > export BBPATH > > -BB_ENV_EXTRAWHITE="BASEDIR BUILDDIR" > +BB_ENV_EXTRAWHITE="BASEDIR BUILDDIR http_proxy https_proxy ftp_proxy > no_proxy" export BB_ENV_EXTRAWHITE