Re: [PATCH 3/4 v2] buildchroot: Add prepare and cleanup tasks

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 11 Dec 2017 12:23:40 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> Hi Christian,
> 
> On 12/08/2017 10:58 AM, Christian Storm wrote:
> >   
> >> 2. 'do_cleanup': This task is executed after all the packages are
> >> deployed. Some notes:
> >>   - This task also should not have stamp.
> >>   - This task depends from the recipes listed in IMAGE_INSTALL.  
> > 
> > This breaks build dependencies when building two packages from
> > source (same example I've given in other posts as well):
> > 
> > Consider A-dev required by B, both to be built from source. B cannot
> > install the A-dev.deb since B depending on A-dev's deploy_deb() and
> > installing it the ugly way via dpkg -i (as no other option is
> > currently available in Isar) puts B as late in the task order so
> > that it's git repo is not mounted anymore. Failure.
> > 
> > If A-dev installs it's produced .deb as last step in its
> > dpkg_runbuild(), which is also ugly, then there's a potential race
> > in dpkg. Failure.  
> 
> Seems I don't fully understand your usecase, could you please comment
> if it's correct:
> 
> 1. You have two Isar recipes A and B that build packages from source
> code.
> 
> 2. After building of package A, apart from binary A, A-dev also
> provided.
> 
> 3. Package B depends on A-dev.
> 
> Also, have you added dependency from A in B recipe?

Dependencies will not help here, Isar simply does not support that
case ... yet.
You have B depending on A both at runtime and on build-time. So you need
a buildchroot to build A in. And for B you need a buildchroot which has
A installed.

To get the buildchroot for B you either have to install A into its own
buildchroot or multistrap again.

I think Christian currently installs A, but with "dpkg -i". I think
multistrapping again would be overkill. IMHO the best solution would be
to install such packages in buildchroot with apt-get, after they have
been repreproed to the "Isar" repo.

I suggested improvements on "[PATCH 0/4 v5] Isar apt deployment" but
the feedback was delayed until a v2.

Essentially deploy_deb needs to reprepro, do_populate needs to go away,
builchroot needs aptsources=Isar in its multistrap.conf. Now the
apt-get in build.sh should work.

Henning