From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6491554293275951104 X-Received: by 10.223.135.69 with SMTP id 5mr163934wrz.8.1513017000454; Mon, 11 Dec 2017 10:30:00 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.154.44 with SMTP id z41ls1886200wrb.6.gmail; Mon, 11 Dec 2017 10:30:00 -0800 (PST) X-Google-Smtp-Source: ACJfBotWRyeTeYJWxZhFBS8j2CIwnPeuiQEJsegfCy9Mz9MS5ZRfeD3XDyrmeHEodLEecBGPg295 X-Received: by 10.28.96.214 with SMTP id u205mr229359wmb.21.1513016999990; Mon, 11 Dec 2017 10:29:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513016999; cv=none; d=google.com; s=arc-20160816; b=BnpjdunbY7MpAVqyVQ3trQZUeVYgQSk8PEVWXDWitvNK0zVpV1ahIVmua+MjVL0oTQ sIxtHCCsoX9xRR46JyJlMzVL908OrRosuAos/0sDfD0TUAXdSKEqijHJE1UulqoPhQGP Ryy+nRBPym79IJgzq6HRYLt9TXYOTU1Zv/qaKM+6s7choyH4LXrMCVNUNiFvgZCLdqN8 6yvcHms4usVsuBTLeElOv1+XOZoy4xihZ8w8WFvjAtcG03cVLXaoisD3rT8Z56gT4h79 2Y2O0og/yhht2nvIDvAhyEZhhhX03AuCANshguPd/SuLzb1rTOXdKKgGgP8twu/nYJ7p fGKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=YktlGGus8zCs0XkyB0ENcSIVt+va/Ls22xIF7iEzNmo=; b=M2JFRdxvdq08wlmedgT0AKr2N0HMJwFHvAPyrjtLOSjzCIdxUd3upBPQ3TvkcqYpH6 0U+A1gbbnCRBLgm/je2j8qYTd/GdtCc+gXyxHQjF+aZwPtkBtAG3p+qwWNKNNIf5ycj7 6LTqlHGAbLXZY60HXR3FtSE5zjcr3CvixsnNLLIjk8Vx4kFJ7f9/liQ1ivdYAkZQLr8U AxhAGBP6kCNEuV+3fBA0hYaT3hjefQNZ5voUZbkN4HdOCzOMDRub20rTVu8Jly85uLrq sbwXriQpkXZZ6LDudP7QKMGjHbkcoCXZ5B8bwOg9fHjDCJoDNkOeiLx+akfcLE+00fBt x3aQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id r70si896453wmg.2.2017.12.11.10.29.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 10:29:59 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id vBBITxOF017634 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Dec 2017 19:29:59 +0100 Received: from md1pvb1c (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id vBBITxrS029082; Mon, 11 Dec 2017 19:29:59 +0100 Date: Mon, 11 Dec 2017 19:29:58 +0100 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 3/4 v2] buildchroot: Add prepare and cleanup tasks Message-ID: <20171211192958.79ff98e6@md1pvb1c> In-Reply-To: <20171123102532.26274-4-asmirnov@ilbers.de> References: <20171123102532.26274-1-asmirnov@ilbers.de> <20171123102532.26274-4-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: R54CVY9rRM4g Just found another issue with this one. Building something on current next. >> ERROR: Nothing PROVIDES '${IMAGE_INSTALL}' (but >> multiconfig:qemuamd64-stretch:/builder/isar/meta/recipes-devtools/buildchroot/buildchroot.bb >> DEPENDS on or otherwise requires it) a 'IMAGE_INSTALL ?= ""' fixes that. Henning Am Thu, 23 Nov 2017 13:25:31 +0300 schrieb Alexander Smirnov : > Some packages could require builchroot filesystem tunning, for > example share Isar downloads folder with chroot filesystem. > > This patch adds two tasks for buildchroot: > > 1. 'do_prepare': This task is executed after buildchroot rootfs > generation and before 'do_build' from packages to be built. > Some notes: > - An individual task is required for the case when you want to > rebuild some package, this would require to run this preparation > stuff for existing buildchroot rootfs. > - This task should not have stamp. This means that anytime you want > to build something, 'do_prepare' should be executed. > > 2. 'do_cleanup': This task is executed after all the packages are > deployed. Some notes: > - This task also should not have stamp. > - This task depends from the recipes listed in IMAGE_INSTALL. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/dpkg-base.bbclass | 2 +- > meta/classes/image.bbclass | 1 + > meta/recipes-devtools/buildchroot/buildchroot.bb | 21 > +++++++++++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index 4941f9b..21ae88d 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -2,7 +2,7 @@ > # Copyright (C) 2017 Siemens AG > > # Add dependency from buildchroot creation > -do_build[depends] = "buildchroot:do_build" > +do_build[depends] = "buildchroot:do_prepare" > > # Each package should have its own unique build folder, so use > # recipe name as identifier > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 7813b16..b0f645c 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -83,6 +83,7 @@ do_populate() { > > addtask populate before do_build after do_unpack > do_populate[deptask] = "do_deploy_deb" > +do_populate[depends] = "buildchroot:do_cleanup" > > do_rootfs[stamp-extra-info] = "${MACHINE}-${DISTRO}" > > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb > b/meta/recipes-devtools/buildchroot/buildchroot.bb index > 6a94733..fe88e98 100644 --- > a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ > b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -67,7 +67,28 @@ > do_build() { # Install package builder script > sudo install -m 755 ${WORKDIR}/build.sh ${BUILDCHROOT_DIR} > > + # Create share point for downloads > + sudo install -d ${BUILDCHROOT_DIR}/git > + > # Configure root filesystem > sudo chroot ${BUILDCHROOT_DIR} /configscript.sh > _do_build_cleanup > } > + > +do_prepare[nostamp] = "1" > + > +do_prepare() { > + sudo mount --bind ${GITDIR} ${BUILDCHROOT_DIR}/git > +} > + > +addtask prepare after do_build > + > +DEPENDS += "${IMAGE_INSTALL}" > +do_cleanup[deptask] = "do_deploy_deb" > +do_cleanup[nostamp] = "1" > + > +do_cleanup() { > + sudo umount ${BUILDCHROOT_DIR}/git > +} > + > +addtask cleanup after do_prepare