From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6491554293275951104 X-Received: by 10.223.136.137 with SMTP id f9mr181764wrf.0.1513017165940; Mon, 11 Dec 2017 10:32:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.133.238 with SMTP id 43ls1910509wru.14.gmail; Mon, 11 Dec 2017 10:32:45 -0800 (PST) X-Google-Smtp-Source: ACJfBotnzaW1aG6PT2Rs+G7M6rrlHodW/N/Hir4wRSGJa2lt2ASbMPwdneoxGGMuJBM/ZOywLdE7 X-Received: by 10.28.141.149 with SMTP id p143mr211373wmd.13.1513017165646; Mon, 11 Dec 2017 10:32:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513017165; cv=none; d=google.com; s=arc-20160816; b=TgXnCme4HPgxe92UKGtnLZsCyzG1P7UyMYZZ0cfuZF44iLikZy/HfA2gYdrrGOqwH4 7UvOAkUe7pV+KT6ayiRNSYIquLSMov4WCcRExaNIrHLbcQdeVIHoamqn1vTIugiWcSKK QE+bewd8z+pd5CIpZHt0A1Neyn3QsqpogCTF9ZkEnMgFTpCUCl4oCI1miSnFZhz16xoq 63Et/IAVtzJwDnc4GyGWNNZoDUtdzO52OB0ZwTZys2EM774ZKiXXAJO/ITwFjA2VF7Cj fchwU7JDj88rPtpuilDWD8TGrostf8B8Sy8/UsU9dLCn5dGpKpgqfe5lLL+7+OZ9R4n7 S6tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=2pAGvW/H1uPD7Tf0bPKozt+45JJXZAFzezsp3XfyIpQ=; b=l2ftsLj58YtJOHCkboqOLadtJX01dBh06DdapfGbdfUlKE2SS4rPPFJFX9zfkBTJ1z EjlhPCMHxGgLYMLeRDTCFwl78Xp87wYxpeGlt9qnvDN2J+9oOqq7f1tzDMQgdpFF9dGq J1+zeKUUZBvSYIItrwzERlkNlRI32j4xBH+o4G76eTJQb7UnuMmCsyFoX8dqIF5D/ao5 PJ1cFsQuOKCKr+CVvEJ2Srx0YgGyb9oA3vy2uIPahEAr5raVV9gk/slvhZZLKWvpSesH KEU56wbLGm6n7IFmogItyXtrq3IJb6OaZn15hF18KzaCr5lmFW2HdqwA3bCbDKhUwluk 82xg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id j2si1320562wrh.0.2017.12.11.10.32.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 10:32:45 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id vBBIWjme009159 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Dec 2017 19:32:45 +0100 Received: from md1pvb1c (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id vBBIWjlm027333; Mon, 11 Dec 2017 19:32:45 +0100 Date: Mon, 11 Dec 2017 19:32:44 +0100 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 3/4 v2] buildchroot: Add prepare and cleanup tasks Message-ID: <20171211193244.0de19293@md1pvb1c> In-Reply-To: <20171123102532.26274-4-asmirnov@ilbers.de> References: <20171123102532.26274-1-asmirnov@ilbers.de> <20171123102532.26274-4-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: cHR9QRwT6vbn Am Thu, 23 Nov 2017 13:25:31 +0300 schrieb Alexander Smirnov : > Some packages could require builchroot filesystem tunning, for > example share Isar downloads folder with chroot filesystem. > > This patch adds two tasks for buildchroot: > > 1. 'do_prepare': This task is executed after buildchroot rootfs > generation and before 'do_build' from packages to be built. > Some notes: > - An individual task is required for the case when you want to > rebuild some package, this would require to run this preparation > stuff for existing buildchroot rootfs. > - This task should not have stamp. This means that anytime you want > to build something, 'do_prepare' should be executed. > > 2. 'do_cleanup': This task is executed after all the packages are > deployed. Some notes: > - This task also should not have stamp. > - This task depends from the recipes listed in IMAGE_INSTALL. > > Signed-off-by: Alexander Smirnov > --- > meta/classes/dpkg-base.bbclass | 2 +- > meta/classes/image.bbclass | 1 + > meta/recipes-devtools/buildchroot/buildchroot.bb | 21 > +++++++++++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index 4941f9b..21ae88d 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -2,7 +2,7 @@ > # Copyright (C) 2017 Siemens AG > > # Add dependency from buildchroot creation > -do_build[depends] = "buildchroot:do_build" > +do_build[depends] = "buildchroot:do_prepare" > > # Each package should have its own unique build folder, so use > # recipe name as identifier > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 7813b16..b0f645c 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -83,6 +83,7 @@ do_populate() { > > addtask populate before do_build after do_unpack > do_populate[deptask] = "do_deploy_deb" > +do_populate[depends] = "buildchroot:do_cleanup" > > do_rootfs[stamp-extra-info] = "${MACHINE}-${DISTRO}" > > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb > b/meta/recipes-devtools/buildchroot/buildchroot.bb index > 6a94733..fe88e98 100644 --- > a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ > b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -67,7 +67,28 @@ > do_build() { # Install package builder script > sudo install -m 755 ${WORKDIR}/build.sh ${BUILDCHROOT_DIR} > > + # Create share point for downloads > + sudo install -d ${BUILDCHROOT_DIR}/git > + > # Configure root filesystem > sudo chroot ${BUILDCHROOT_DIR} /configscript.sh > _do_build_cleanup > } > + > +do_prepare[nostamp] = "1" > + > +do_prepare() { > + sudo mount --bind ${GITDIR} ${BUILDCHROOT_DIR}/git > +} And another one ... mount: special device /builder/build/tmp/downloads/git does not exist Henning > + > +addtask prepare after do_build > + > +DEPENDS += "${IMAGE_INSTALL}" > +do_cleanup[deptask] = "do_deploy_deb" > +do_cleanup[nostamp] = "1" > + > +do_cleanup() { > + sudo umount ${BUILDCHROOT_DIR}/git > +} > + > +addtask cleanup after do_prepare