From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6491554293275951104 X-Received: by 10.80.195.1 with SMTP id a1mr634997edb.8.1513080330730; Tue, 12 Dec 2017 04:05:30 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.179.211 with SMTP id t19ls4659855edd.3.gmail; Tue, 12 Dec 2017 04:05:30 -0800 (PST) X-Google-Smtp-Source: ACJfBosKBVPBzLSwPTcb07rZTyfBsf6GtOZeKeZMpHkTZ0JmTH7A7qGYzCMkPFowtnRCRovhKg9e X-Received: by 10.80.164.203 with SMTP id x11mr624865edb.7.1513080330295; Tue, 12 Dec 2017 04:05:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513080330; cv=none; d=google.com; s=arc-20160816; b=fa3vFlX5ZlQiMYVbkSv2Oa/T3ylB05aE+SlaST+a/2y3GOTqreJDM/sTdfqepWs6f4 ecKQE/ZS1VSLZGHYhMM+yTnw6+sp0KVzRuaF+rBNtMsQnqur6LuQkGB0aAC4zgBXCFiV XnVhzAyhNTzxK+ojO01yIXKmQFWoW51nDIziGc2cxLHmILs4wo6Y7+ymQnAMtvlkkIxG BamPu8CcsOJM4Z1PsPssYaFhBz7CB3PDTq29YEE9mcMc2807YHI45x81XLeQPpDX0T58 rfMwkV0TdjPZp4uIq4f4lREJIovgahacspypie0DtXvGt+BapMd5fKb2gopuEmaY1dXY nxWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=nkX6F/vyI4Kp822sbP5qBLDuYYTtCS5l8XEkZ/p4Iso=; b=uWteefv0ZiJuQf8W6zpr5vQY3M2sdKe2kRrVlInu5k9ChZhyv+TOOAnwZHUOwKqspl ntCtCeGgRMONx2vsgVkn4b1pPZAt8o3ZVHfFbsg8EcWj5GfZq37Jr7bNeZWerK6842eY 0S0/YkZQgUpY7pAVxJj0DULADltFrfAPABf7iyLxpkPoAbCnA8rN05sVZAWRcQgYYIin vvYltJCobQjSN5OmsCKZlYM0OTcwYI0iStSpwM0o3cEDB07SJusR38PDNivmznhzR/0Y veYV0ydHPRmkG22NczteBlvlJeXP1vcmv/0gTL1D+pjU4x6Mk1a12fVY/V9FfKu1nKsK nkLQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id r58si2037502eda.3.2017.12.12.04.05.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Dec 2017 04:05:30 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id vBCC5ToY018817 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Dec 2017 13:05:29 +0100 Received: from md1pvb1c (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id vBCC5TN0017609; Tue, 12 Dec 2017 13:05:29 +0100 Date: Tue, 12 Dec 2017 13:05:21 +0100 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 3/4 v2] buildchroot: Add prepare and cleanup tasks Message-ID: <20171212130521.53a9632c@md1pvb1c> In-Reply-To: References: <20171123102532.26274-1-asmirnov@ilbers.de> <20171123102532.26274-4-asmirnov@ilbers.de> <20171211192958.79ff98e6@md1pvb1c> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: U7pyRgQlwSd4 Am Mon, 11 Dec 2017 22:56:42 +0300 schrieb Alexander Smirnov : > Hi, > > On 12/11/2017 09:29 PM, Henning Schild wrote: > > Just found another issue with this one. Building something on > > current next. > > > >>> ERROR: Nothing PROVIDES '${IMAGE_INSTALL}' (but > >>> multiconfig:qemuamd64-stretch:/builder/isar/meta/recipes-devtools/buildchroot/buildchroot.bb > >>> DEPENDS on or otherwise requires it) > > > > a 'IMAGE_INSTALL ?= ""' fixes that. > > > > Thanks for this catch. > > It would be helpful if you describe your changes from upstream Isar > that leads to this issue. Am I right, that you do not set > IMAGE_INSTALL variable in local.conf file? Yes it is a layer with IMAGE_INSTALL not set in its local.conf, no changes to Isar. > Also an ideas how to handle such cases in pure Isar are welcome. If we really need a VARIABLE to be initialized in a local.conf that should probably be documented. It might make sense to extend the testing to actually testing the layering a well. Such a layer could be in the tree and we should build targets with and without the layer. But before that we should probably sort meta and meta-isar. As far as i see it "meta" should be the core of Isar while "meta-isar" could eventually be the layer using that core. At the moment i do not really have an idea what the idea behind the current split is, and whether that cut is clean. I am already thinking about patches for more layering features, i.e. customization of multistrap.conf. Henning > Alex > > > Henning > > > > Am Thu, 23 Nov 2017 13:25:31 +0300 > > schrieb Alexander Smirnov : > > > >> Some packages could require builchroot filesystem tunning, for > >> example share Isar downloads folder with chroot filesystem. > >> > >> This patch adds two tasks for buildchroot: > >> > >> 1. 'do_prepare': This task is executed after buildchroot rootfs > >> generation and before 'do_build' from packages to be built. > >> Some notes: > >> - An individual task is required for the case when you want to > >> rebuild some package, this would require to run this preparation > >> stuff for existing buildchroot rootfs. > >> - This task should not have stamp. This means that anytime you > >> want to build something, 'do_prepare' should be executed. > >> > >> 2. 'do_cleanup': This task is executed after all the packages are > >> deployed. Some notes: > >> - This task also should not have stamp. > >> - This task depends from the recipes listed in IMAGE_INSTALL. > >> > >> Signed-off-by: Alexander Smirnov > >> --- > >> meta/classes/dpkg-base.bbclass | 2 +- > >> meta/classes/image.bbclass | 1 + > >> meta/recipes-devtools/buildchroot/buildchroot.bb | 21 > >> +++++++++++++++++++++ 3 files changed, 23 insertions(+), 1 > >> deletion(-) > >> > >> diff --git a/meta/classes/dpkg-base.bbclass > >> b/meta/classes/dpkg-base.bbclass index 4941f9b..21ae88d 100644 > >> --- a/meta/classes/dpkg-base.bbclass > >> +++ b/meta/classes/dpkg-base.bbclass > >> @@ -2,7 +2,7 @@ > >> # Copyright (C) 2017 Siemens AG > >> > >> # Add dependency from buildchroot creation > >> -do_build[depends] = "buildchroot:do_build" > >> +do_build[depends] = "buildchroot:do_prepare" > >> > >> # Each package should have its own unique build folder, so use > >> # recipe name as identifier > >> diff --git a/meta/classes/image.bbclass > >> b/meta/classes/image.bbclass index 7813b16..b0f645c 100644 > >> --- a/meta/classes/image.bbclass > >> +++ b/meta/classes/image.bbclass > >> @@ -83,6 +83,7 @@ do_populate() { > >> > >> addtask populate before do_build after do_unpack > >> do_populate[deptask] = "do_deploy_deb" > >> +do_populate[depends] = "buildchroot:do_cleanup" > >> > >> do_rootfs[stamp-extra-info] = "${MACHINE}-${DISTRO}" > >> > >> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb > >> b/meta/recipes-devtools/buildchroot/buildchroot.bb index > >> 6a94733..fe88e98 100644 --- > >> a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ > >> b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -67,7 +67,28 > >> @@ do_build() { # Install package builder script > >> sudo install -m 755 ${WORKDIR}/build.sh ${BUILDCHROOT_DIR} > >> > >> + # Create share point for downloads > >> + sudo install -d ${BUILDCHROOT_DIR}/git > >> + > >> # Configure root filesystem > >> sudo chroot ${BUILDCHROOT_DIR} /configscript.sh > >> _do_build_cleanup > >> } > >> + > >> +do_prepare[nostamp] = "1" > >> + > >> +do_prepare() { > >> + sudo mount --bind ${GITDIR} ${BUILDCHROOT_DIR}/git > >> +} > >> + > >> +addtask prepare after do_build > >> + > >> +DEPENDS += "${IMAGE_INSTALL}" > >> +do_cleanup[deptask] = "do_deploy_deb" > >> +do_cleanup[nostamp] = "1" > >> + > >> +do_cleanup() { > >> + sudo umount ${BUILDCHROOT_DIR}/git > >> +} > >> + > >> +addtask cleanup after do_prepare > > >