From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6498671579909586944 X-Received: by 10.25.199.78 with SMTP id x75mr320789lff.36.1513091674720; Tue, 12 Dec 2017 07:14:34 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.42.78 with SMTP id f75ls230724lfl.0.gmail; Tue, 12 Dec 2017 07:14:34 -0800 (PST) X-Google-Smtp-Source: ACJfBosfvKWRJZ0FzMHisjFWw2aeQZw+QArupVsD8Obv/33HHQ83gpoNjcnBxTMzw4xsV8FLl9tZ X-Received: by 10.46.84.87 with SMTP id y23mr372538ljd.4.1513091673973; Tue, 12 Dec 2017 07:14:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513091673; cv=none; d=google.com; s=arc-20160816; b=AJORXl3eZEXG1PpjeFY7vlM8Vx6dmBabMTWxHwC8O15aylxCXz8jsyUyWulOZw/Hlv /zmGNBVb52x1KpGBgksPgYXlQ/APHqViNcwjp3oR0gtCScNYwHdGOlYnW9DSkLdyNBe5 BRixIYLIW8kqw7Dn50q/YfC+j959GFfyz5H0DLh4hBshdphL+qYX3ZxPO6BKwj50MW6d IkkfVHAB8mSd2J2tayjjnCbVZMUWm3mzWkvkkaHjPAiAongcn/S2yhQAZdOZl4lkNQQH 2UOtBu1CQ02f7s6QvJ5GGtta7U6Wc/b3st7avyezmhT84+U4UIGud4a77kQDlEOWz1XO dn6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=QJFez+deQDqH93OqnZyaamtNDH/jQrMQqWD3F0VNBPU=; b=y/uHR+cn6uDIDW92YqwkII8LHwS30QEOT9SVECUlzay6QeQpQDUlkcnDy3O3LFNtAq GnimWYJdqgpsNN+nWmVBkmRMGLC/qB9xExB1SGGaBqGNsd96eHJqohvxwQm23dlQeic1 rGe87r4Fnh9HJnTG1VAMXMg4KS8Cl4g7E0kMWAwo0YGzzFV9O2dQr9ctfNih+Y0+fNg6 AcrWeNs/vnuqIkt6nAG0YGKu8xX3Cd4R3suR63UaFIzqBNaPDdc2lrx0rigYk87KhOOO zeOlAcYipyv3Nf889k3r/IL6LAxjSHNFQ15UDVuulo/p/xrz6yDH5JdZ7HXKgWmNooNY Vp3g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id n75si1691881ljb.0.2017.12.12.07.14.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Dec 2017 07:14:33 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id vBCFEXTG018121 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Dec 2017 16:14:33 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id vBCFEXHi019348; Tue, 12 Dec 2017 16:14:33 +0100 Date: Tue, 12 Dec 2017 16:14:32 +0100 From: Henning Schild To: Cc: Subject: Re: [PATCH] fetch/git: add support for disabling shared clones on unpack Message-ID: <20171212161432.555f8508@mmd1pvb1c.ad001.siemens.net> In-Reply-To: <20171212144443.30618-1-henning.schild@siemens.com> References: <20171212144443.30618-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 8yOpcLFLqoCW Am Tue, 12 Dec 2017 15:44:43 +0100 schrieb Henning Schild : > By default the unpacker will create a "shared" clone when cloning from > the DL_DIR to the WORKDIR. This patch introduces an option to control > that behaviour. Probably something that hardly anyone would want to > do. > > Imagine some recipe steps are executed in a namespace that is > different from the one your downloader and unpacker ran in. (chroot) > Because a "shared" clone has an absolute reference to its "alternate" > you now have to make that "alternate" visible in that new namespace > (chroot) at the exact place. > > With this patch you can unpack "noshared" and get a stand-alone copy. > This copy will also work if the "alternate" is not visible or > existant. > > Signed-off-by: Henning Schild > --- > lib/bb/fetch2/git.py | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py > index 5ef8cd69..30b88c83 100644 > --- a/lib/bb/fetch2/git.py > +++ b/lib/bb/fetch2/git.py > @@ -53,6 +53,13 @@ Supported SRC_URI options are: > For local git:// urls to use the current branch HEAD as the > revision for use with AUTOREV. Implies nobranch. > > +- noshared > + When unpacking do not clone with the parameter "--shared". This > option will > + allow the unpacked copy to work stand-alone i.e. if your recipe > runs in a > + chroot where the "alternate" can not be found. Setting this will > increase > + the unpack-time and the disk-usage. > + The default is "0", set noshared=1 if needed. > + > """ > > #Copyright (C) 2005 Richard Purdie > @@ -159,6 +166,8 @@ class Git(FetchMethod): > > ud.nobranch = ud.parm.get("nobranch","0") == "1" > > + ud.noshared = ud.parm.get("noshared","0") == "1" > + > # usehead implies nobranch > ud.usehead = ud.parm.get("usehead","0") == "1" > if ud.usehead: > @@ -176,7 +185,9 @@ class Git(FetchMethod): > if len(branches) != len(ud.names): > raise bb.fetch2.ParameterError("The number of name and > branch parameters is not balanced", ud.url) > - ud.cloneflags = "-s -n" > + cloneflags = "-n" > + if not ud.noshared: > + cloneflags += " -s" Rebase-mistake, forgot the "ud." before cloneflags. v2 is on the way Henning > if ud.bareclone: > ud.cloneflags += " --mirror" >