Re: [RFC PATCH 0/1] Special debian depends entries

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 14 Dec 2017 15:12:37 +0100
schrieb Claudius Heine <ch@denx.de>:

> Hi Henning,
> 
> On Thu, 2017-12-14 at 14:42 +0100, Henning Schild wrote:
> > Am Wed, 13 Dec 2017 17:07:09 +0100
> > schrieb "[ext] claudius.heine.ext@siemens.com"
> > <claudius.heine.ext@siemens.com>:
> >   
> > > From: Claudius Heine <ch@denx.de>
> > > 
> > > Hi,
> > > 
> > > this patch is to start the discussion about how to implement the
> > > debian depends.
> > > 
> > > Instead of going the just 'echo ${DEBIAN_DEPENDS}' route, I chose
> > > to
> > > be backwards compatible. Another reason for this is also for the
> > > possible next feature where ISAR 'DEPENDS' or 'RDEPENDS' will be
> > > converted to the package specific 'DEBIAN_DEPENDS'.  
> > 
> > With the current nature of dpkg-raw DEPENDS and RDEPENDS make no
> > sense.
> > Maybe some day the class will do more than just wrap stuff in a
> > package, but at the moment i do not see that coming.
> > And even if that ever happened the class could take care of turning
> > the
> > bitbake-list (R)DEPENDS into a Debian comma-seperated list.
> > 
> > I tried your code in a bash (not in Isar/bitbake etc.) and i got a
> > few
> > more commas that i would have expected.
> > 
> > 'libc, (>=, 2.16)', 'tar, |, bsdtar', systemd
> > 
> > Shell code is nasty, i think i do not even want to know why it
> > worked for you or wether it would work in Isar with my build env.  
> 
> I works in here because the ${DEBIAN_DEPENDS} is inserted by bitbake
> before any shell is executed. So in shell code for this example looks
> like this:
> 
>     DEBIAN_DEPS="$(for i in 'libc (>= 2.16)' 'tar | bsdtar' systemd;do
> echo $i,;done|tr '\n' ' '|sed 's/, *$//')"
> 
> If you try that out with your shell:
> 
>     $ echo "$(for i in 'libc (>= 2.16)' 'tar | bsdtar' systemd;do echo
> $i,;done|tr '\n' ' '|sed 's/, *$//')"
>     libc (>= 2.16), tar | bsdtar, systemd
> 
> It works correctly just like in bitbake.
> 
> DEBIAN_DEPENDS is not a shell variable but a bitbake one.
> 
> But I get your point that this is confusing and error-prone. Doing it
> with python might be easier.

It is just one of multiple points.

Could you live with the simple solution of just taking the string from
the recipe and requiring recipe-updates?

Henning

> Cheers,
> Claudius
>