Re: [PATCH] dpkg-raw: empty "Depends:" line is not allowed in .deb

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 13 Dec 2017 13:51:36 +0100
schrieb Henning Schild <henning.schild@siemens.com>:

> Apt-gat fails to install packages if the control-file contains a
> "Depends:"-line without any packages listed.
> 
>   E: Problem parsing dependency Depends
> 
> So append that line to the control-file only if DEBIAN_DEPENDS was set
> in the recipe. The user could still specify i.e. " " or anything
> invalid, we do not check that. But now our default works.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> Reported-by: Claudius Heine <ch@denx.de>
> ---
>  meta/classes/dpkg-raw.bbclass | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/dpkg-raw.bbclass
> b/meta/classes/dpkg-raw.bbclass index af62be4..1435e10 100644
> --- a/meta/classes/dpkg-raw.bbclass
> +++ b/meta/classes/dpkg-raw.bbclass
> @@ -26,10 +26,15 @@ do_deb_package_prepare() {
>  		Section: misc
>  		Priority: optional
>  		Maintainer: ${MAINTAINER}
> -		Depends: `echo ${DEBIAN_DEPENDS} | tr '[:blank:]'
> ','` Version: ${PV}+isar
>  		Description: ${DESCRIPTION}
>  	__EOF__
> +	if [ ${DEBIAN_DEPENDS} != "" ]

the condition is missing "" around DEBIAN_DEPENDS sending v2

> +	then
> +		echo -n Depends: >> ${D}/DEBIAN/control
> +		echo ${DEBIAN_DEPENDS} | tr '[:blank:]' ',' >> \
> +			${D}/DEBIAN/control
> +	fi
>  	for t in pre post
>  	do
>  		for a in inst rm