From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6498671579909586944 X-Received: by 10.80.230.25 with SMTP id y25mr1481253edm.9.1513788340428; Wed, 20 Dec 2017 08:45:40 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.144.196 with SMTP id d4ls61911eda.4.gmail; Wed, 20 Dec 2017 08:45:40 -0800 (PST) X-Google-Smtp-Source: ACJfBotXrtEoTB/2VQv2tHQEPLRvel0u8GvWv235/vfZnSEOgAMqWyewGJrOjjNkiWRNFA4mu1wR X-Received: by 10.80.151.161 with SMTP id e30mr1474208edb.4.1513788340003; Wed, 20 Dec 2017 08:45:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513788339; cv=none; d=google.com; s=arc-20160816; b=HbDVyjhzww8dqGvh7rUtsChF9WKxBlmzioG1W4LHlYIBple7LZZSMI9csRxLzQ3dG4 97uBFADYmoGuk26SBDyB/+yA/9xhnOncSCEMiE7TkCbHra11znL3x7fzHc58j5SVTUNe yY9ikpgygfbkdzZButLZENKKeNOlFE/ziiMPT3m8AkGyIhFTd4jRjLeD/rcnPsaiLgMY T9yscFs2/iPNsRJta8rtzzehgWzH1ZgpgCtUhA46udrQBYPb7JquYCC4wzOxGy6857r+ 5lxbV6tJZNqJEG9NUzFPTDJ8kcY7217q/0TymxPmi14j6D+J5K4eV0/em9KeZymQi+Bm 95+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=VyfaBspnWbZqsLwh5LpsY9oMpv/N/zM9CGQedYNLkcM=; b=lGIcfcvOQu51ooHQ8YBbYZcKgSL85ECDXszmArxcqBPoRd99er6K6yGM2eJRbDDXEL 65ipJ1KNWGOUJQoxxyJvIrD/H0n6k9+h+CtL7VB9hxlQ060noihSf+4iq9NatbXt4Z+e grIxZCC1T3A+sfwhCBKmGhvMTUwjG2z63JUdjBBTeIKxY1fGaeoxKziDMbLEfc9Scwc0 xNJ/d+ydtpRlhIC6y5GRXByqPelarIwvbBCkK5MVnAhDAyOVrzffZQxXzKUmlGMlRSFo 9kXtzxXvirEiMygIvJTpMmmglHxRHCoNtaIJ2HDIcuIrbJHXj495vdeOEUas997/1hS+ P2oQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id m7si2055893edm.4.2017.12.20.08.45.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 08:45:39 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id vBKGjdt5032584 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Dec 2017 17:45:39 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id vBKGjdP4004150; Wed, 20 Dec 2017 17:45:39 +0100 Date: Wed, 20 Dec 2017 17:45:38 +0100 From: Henning Schild To: Cc: Subject: Re: [PATCH] fetch/git: add support for disabling shared clones on unpack Message-ID: <20171220174538.441d517f@mmd1pvb1c.ad001.siemens.net> In-Reply-To: <20171220164209.9609-1-henning.schild@siemens.com> References: <20171220164209.9609-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: pSDhybBp/bvi We actually ran into that issue on a build system called Isar. https://github.com/ilbers/isar This build system executes some tasks in a chroot. In this chroot a "shared" clone will not work because it expects its "alternate" to be at the very same location it was outside the chroot. We considered several hacks in Isar - patching the alternates before and after chroot - mounting the "alternate" to the exact location in chroot None of this is really nice, so we decided to try and do something about it upstream. regards, Henning Am Wed, 20 Dec 2017 17:42:09 +0100 schrieb Henning Schild : > By default the unpacker will create a "shared" clone when cloning from > the DL_DIR to the WORKDIR. This patch introduces an option to control > that behaviour. Probably something that hardly anyone would want to > do. > > Imagine some recipe steps are executed in a namespace that is > different from the one your downloader and unpacker ran in. (chroot) > Because a "shared" clone has an absolute reference to its "alternate" > you now have to make that "alternate" visible in that new namespace > (chroot) at the exact place. > > With this patch you can unpack "noshared" and get a stand-alone copy. > This copy will also work if the "alternate" is not visible or > existant. > > Signed-off-by: Henning Schild > --- > lib/bb/fetch2/git.py | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py > index 5ef8cd69..7b7f02b2 100644 > --- a/lib/bb/fetch2/git.py > +++ b/lib/bb/fetch2/git.py > @@ -53,6 +53,13 @@ Supported SRC_URI options are: > For local git:// urls to use the current branch HEAD as the > revision for use with AUTOREV. Implies nobranch. > > +- noshared > + When unpacking do not clone with the parameter "--shared". This > option will > + allow the unpacked copy to work stand-alone i.e. if your recipe > runs in a > + chroot where the "alternate" can not be found. Setting this will > increase > + the unpack-time and the disk-usage. > + The default is "0", set noshared=1 if needed. > + > """ > > #Copyright (C) 2005 Richard Purdie > @@ -159,6 +166,8 @@ class Git(FetchMethod): > > ud.nobranch = ud.parm.get("nobranch","0") == "1" > > + ud.noshared = ud.parm.get("noshared","0") == "1" > + > # usehead implies nobranch > ud.usehead = ud.parm.get("usehead","0") == "1" > if ud.usehead: > @@ -176,7 +185,9 @@ class Git(FetchMethod): > if len(branches) != len(ud.names): > raise bb.fetch2.ParameterError("The number of name and > branch parameters is not balanced", ud.url) > - ud.cloneflags = "-s -n" > + ud.cloneflags = "-n" > + if not ud.noshared: > + ud.cloneflags += " -s" > if ud.bareclone: > ud.cloneflags += " --mirror" >