From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6509455202632859648 X-Received: by 10.223.152.182 with SMTP id w51mr1814139wrb.10.1515691213226; Thu, 11 Jan 2018 09:20:13 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.182.5 with SMTP id f5ls543458wre.0.gmail; Thu, 11 Jan 2018 09:20:12 -0800 (PST) X-Google-Smtp-Source: ACJfBovE/r/0u+jIRbeRZJAB8ZH5kUfF+BHNHtvdW/PSJXF3rqY9d4jcdISr8P3OHv1pw7nv4HIn X-Received: by 10.28.114.7 with SMTP id n7mr238814wmc.10.1515691212776; Thu, 11 Jan 2018 09:20:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515691212; cv=none; d=google.com; s=arc-20160816; b=hNzoDGLoVDzYUfBhJJHLIIxlKKibbzw9v2apqi+h9Jz8jFzOj8SA6efgLRxfvgX4f1 2f4f9CrKCAVFR99sd4FJsiq9unHdYOu+ivi+vHIhk6oTIG2pV4szHQvKx1wdaclI7Z56 1V19YeTcHOSqlPYNmPS/QgdYX5icFhDlr6JaxY77Ees3zJJ2zzenr6E5Ze+GLrtBtuYL b+q47OptWHDq8Vg/x/UTCTewRnFMWfXAOaCjOHyznt8WZbqt56ju6zhlNZtk+i1p6Yoe sY/keMh/Rvue3lvuj35jcth2jtwzg9SD0FZHYiYSKeckbSx/eJ7BTi99sd1Lg45mlsev Z5vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=IrMRgP29L8PJOkvOb2IoUIqeuGzrCxBa14cxG0A42os=; b=OZxujxluPoCPhAdT5a5mhnKJ/i+9dJD7o4Lcn1VXrGxcDtxkwZszm1RV4Zb1Jsi9cx QisFPMd7BhXVfOYTTRxkFNJFdvTSyj6yGY5sNomqtICalnJOLG0PfU7O2K9ApbzKa5GY qCE9MCHW4htu5vsaJ3ZwcGTSKTkVlhME8bHv9jrs9Cm1WhoUzsBiWvbfwdk+JEU5usCN zySl3gCqgtqf06UUivo8dYS6s6oYT2EvVQdYOQ8H7Tx6piRsGJpzhymRTpAb1UrAu8je 61g5ZtW8yxGMPSyMIxATty5tf54suH32meZ9wrG2fMaah1TzIlWNw9GJTEKDRWAlB5A9 nQog== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id w65si1076466wrb.5.2018.01.11.09.20.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jan 2018 09:20:12 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w0BHKBjn003019 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jan 2018 18:20:11 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w0BHKBd3001987; Thu, 11 Jan 2018 18:20:11 +0100 Date: Thu, 11 Jan 2018 18:20:10 +0100 From: Henning Schild To: Christopher Larson Cc: Alexander Smirnov , Subject: Re: [PATCH] dpkg.bbclass: add lockfile for do_build Message-ID: <20180111182010.6d503748@mmd1pvb1c.ad001.siemens.net> In-Reply-To: References: <20180110160409.18273-1-kergoth@gmail.com> <20180111131425.4d6035c1@mmd1pvb1c.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: vXuvI2zGfAHc Am Thu, 11 Jan 2018 08:20:54 -0700 schrieb Christopher Larson : > On Thu, Jan 11, 2018 at 5:14 AM, Henning Schild > wrote: >=20 > > Am Thu, 11 Jan 2018 13:31:45 +0300 > > schrieb Alexander Smirnov : > > =20 > > > Hello Christopher, > > > > > > thank you for this catch! > > > > > > On 01/10/2018 07:04 PM, Christopher Larson wrote: =20 > > > > All recipes using this class will run build.sh in the same > > > > chroot, and build.sh runs apt-get to install deps, so the build > > > > can fail due to dpkg being unable to acquire its lock. Add a > > > > bitbake lockfile to ensure that only one do_build task for > > > > recipes inheriting this class runs at a time. =20 > > > > > > Serialization of do_build tasks leads to whole Isar serialization, > > > what is significant issue if you have lots of packages to build. > > > So I think the "build" and "deps installation" should be split in > > > separate tasks and only the second one should be protected by > > > locks. =20 > > > > The fact that Isar uses multiconfig to build many targets from the > > same tree is not intuitive, we discussed this before. So i am not > > surprised new contributors get that "wrong". Alex i suggest you > > split the task and adopt Christophers changes. > > > > Christopher, have a look at scripts/ci_build.sh and you will see > > that Isar is capable of building multiple images at once in the > > same tree. If you are building 10 images you will have 10 > > buildchroots that have to be serialized seperately. A feature that > > probably nobody but the CI-bot will ever use ;). =20 >=20 >=20 > Fair enough, thanks, I=E2=80=99ll re-test with 1) a lockfile in the > buildchroot or 2) having build.sh wait on a lock itself, if possible. I just read your signature, and now i guess you can handle the complexity of multiconf without Alex helping you out. Watch out for changes to that code in current next. Henning