public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Baurzhan Ismagulov <ibr@radix50.net>
Cc: <isar-users@googlegroups.com>
Subject: Re: proper wic integration
Date: Fri, 19 Jan 2018 15:15:16 +0100	[thread overview]
Message-ID: <20180119151516.209bb4b9@mmd1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <20180119140210.GA9026@yssyq.radix50.net>

Am Fri, 19 Jan 2018 15:02:10 +0100
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Fri, Jan 19, 2018 at 01:18:51PM +0100, Henning Schild wrote:
> > i started looking into intetgrating wic into the build process. And
> > i have a first working version of that code.
> > On the way i found that Isar is using a massively messed-with
> > version of wic. In my point of view that is an absolute
> > show-blocker for any code that builds on top of that.  
> 
> It depends on your priorities. Our goal at ilbers is to give people
> working code first, merge with upstream second.
> 
> 
> > Before anything gets done with wic, we need to revert all patches
> > that touch wic. We should not have a fork of wic but use an
> > unmodified version of it.  
> 
> I agree with the latter. If you come up with an implementation that
> does it without modifying wic, we'd gladly review it. Before that,
> nothing will be reverted in master.

Of cause not, i will send the reverts with the working code.

> > So this mail is just to let you know that i am looking into that.  
> 
> Thanks, this is important to know.

That is why i shared an early version of my work.
 
> > A first working commit can be found here:
> > https://github.com/henning-schild-work/isar/commit/eeba383177a95bf8b03cba70e1525f65813b4df5  
> 
> The commit comment contains dirty words. Please use respectful
> expressions and tone.

Yes sorry about that, that where comments that where not supposed to
leave my local branch.

> > To get that merged i will first move to an untouched version of wic
> > and rebase it on top of that.  
> 
> That is fine with me.

I came up with something that comes very close, only one tiny bit
missing with fsck failing for some reason.

https://github.com/henning-schild-work/isar/commits/henning/staging

Henning
 
> 
> With kind regards,


  reply	other threads:[~2018-01-19 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 12:18 Henning Schild
2018-01-19 14:02 ` Baurzhan Ismagulov
2018-01-19 14:15   ` Henning Schild [this message]
2018-01-23 11:54 ` Baurzhan Ismagulov
2018-01-23 12:46   ` Jan Kiszka
2018-01-24 14:19     ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119151516.209bb4b9@mmd1pvb1c.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=ibr@radix50.net \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox