Re: [PATCH 0/3] Implement hello <-> libhello pattern

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 25 Jan 2018 11:38:48 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> This series intended to add Isar build dependencies between recipes.

Nice, this is truly needed!

> Overall concept:
>  - A new recipe is added to Isar - libhello.
>  - 'hello' application was modified, not it has 'libhello-dev' as
> build dependency.
> 
> Issues:
>  - At the moment there is no support for Isar-apt in buildchroot, so
> no clear way to install 'libhello-dev' during building 'hello'
>    application. To satisfy it for now, I've added line to install
> newly built packages right after compilation (see patch 2).
> 
> I'm going to improve Isar-apt support to avoid the issue mentioned
> above. Isar-apt looks for me as a bit complicated change, so I'd
> suggest to commit this series as intermediate small step.

I would not like to see patch2 being merged, this is just running
deeper into dept. People that have an urgent need for that can always
"dpkg -i" in their recipes, that is already happening. So when we come
up with a solution, it should be the right one and not centralizing a
known-to-work hack.

Henning

> NOTE: please don't pay attention to SRC_URI. I'm sharing my current
> tested state. Before merging this to Isar I'll update hello/libhello
> repositories and point SRC_URIs to master branches.
> 
> Alex
> 
> Alexander Smirnov (3):
>   dpkg-base: Add dependecies between Isar recipes
>   build.sh: Install newly built packages
>   libhello: Add libhello
> 
>  meta-isar/recipes-app/example-hello/example-hello.bb |  7 +++++--
>  meta-isar/recipes-app/libhello/libhello.bb           | 18
> ++++++++++++++++++
> meta/classes/dpkg-base.bbclass                       |  4 ++++
> meta/recipes-devtools/buildchroot/files/build.sh     |  3 +++ 4 files
> changed, 30 insertions(+), 2 deletions(-) create mode 100644
> meta-isar/recipes-app/libhello/libhello.bb
>