Re: [PATCH v2] build.sh: eliminate potential prompts from mk-build-deps/apt-get

[Henning Schild <henning.schild@siemens.com>]

Thanks!

Henning

Am Mon, 29 Jan 2018 17:31:05 +0100
schrieb <Cedric_Hombourger@mentor.com>:

> From: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> 
> commit 498b128 caused build dependencies to be installed via
> mk-build-deps.
> 
> The tool may ask the user to confirm installation of the dependencies
> but would fail when called from bitbake (no stdin). Override the
> default install command to add the -y switch to the apt-get command
> it uses.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta/recipes-devtools/buildchroot/files/build.sh | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/buildchroot/files/build.sh
> b/meta/recipes-devtools/buildchroot/files/build.sh index
> 975252e..77e0fdd 100644 ---
> a/meta/recipes-devtools/buildchroot/files/build.sh +++
> b/meta/recipes-devtools/buildchroot/files/build.sh @@ -6,8 +6,14 @@
>  # Go to build directory
>  cd $1
>  
> +# Install command to be used by mk-build-deps
> +# Notes:
> +#   1) everything before the -y switch is unchanged from the defaults
> +#   2) we add -y to go non-interactive
> +install_cmd="apt-get -o Debug::pkgProblemResolver=yes
> --no-install-recommends -y" +
>  # Install all build deps
> -mk-build-deps -i -r debian/control
> +mk-build-deps -t "${install_cmd}" -i -r debian/control
>  
>  # If autotools files have been created, update their timestamp to
>  # prevent them from being regenerated