From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6516773995002462208 X-Received: by 10.28.150.216 with SMTP id y207mr3186731wmd.21.1517312639913; Tue, 30 Jan 2018 03:43:59 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.223.139 with SMTP id w133ls422560wmg.2.canary-gmail; Tue, 30 Jan 2018 03:43:59 -0800 (PST) X-Google-Smtp-Source: AH8x224WPvSjCIDNnxnLDMpwynHlc5zzgfnZOdSpy/I9OofruSktloJBJ4GaLH2LEel6l9X6Xdu5 X-Received: by 10.28.225.70 with SMTP id y67mr52795wmg.0.1517312639382; Tue, 30 Jan 2018 03:43:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517312639; cv=none; d=google.com; s=arc-20160816; b=YCrUVAjjIi/dOS14R/uSQaR/9OqQDayRSdANWBay2BywZo2QEnagpw5XGnDIdOsPxF yGJJZRrU5jEsrcJkxpLF2HS4+mybKq4q+/n9nW7mdBKSATSePy+ALfFeQ7HeWCCQjhXQ kGrD57OzjY5+FOvfYT2d5po9c2lOc5dsjA0Xqu+vFUWfPk0Ne3/pAjVBzxk29q7qGmab f7B6DGIP6JhXdZUlLQiv5mbBcyO/8OBj9zToZ3X4Inpzb5Q+x/DnUJrLB1oM+RR5DYTb 8E+7+O5aBglazHK48ybFFYzEQMBf/xU3J+lK9POV+bPUpYNVGKVsbFHsu+ZT5NLFcDvl EyuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=ne+K/Qex9p5yvPk2ssjAoD9DXTrZTM5LSc2SAe17Ie0=; b=pzEJUE10ufT3uu+xlUUSJQhQg8JqfHoP1eErgPg6lRzt6uo8H8A/9r9x+jYhNzJ/aN yeJPqdw5834l2P5RVV/tsklI0f51Uby2vSRrB0Txl8cT4WLLvXz/IoBewW1YG4Na65vA ymbYTHP2EP3/lo8yXR0TTOuUUob0CdsKiseXO5UMtDtqyVhdea02N+zMqXU+XEI27aeM 78kSRg0ERb+FANHKQ1nKg8Ydjmhv08+PXuwzPhCGRNaiLV6ck1KhDo/Abv4PWStRv79U l1WnsQ+WxGawGuWMiW4quic+L8tQwDMVs533raZYlsnRNyCTw7IYiiuzOtYH5zzkz82x +J3w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id g70si151754wmc.3.2018.01.30.03.43.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jan 2018 03:43:59 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w0UBhwFj016277 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jan 2018 12:43:59 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w0UBhw98019135; Tue, 30 Jan 2018 12:43:58 +0100 Date: Tue, 30 Jan 2018 12:44:17 +0100 From: Henning Schild To: "[ext] Jan Kiszka" , Alexander Smirnov , Baurzhan Ismagulov Cc: isar-users Subject: Re: [PATCH] Install /dev/null in rootfs Message-ID: <20180130124417.130d5b4c@mmd1pvb1c.ad001.siemens.net> In-Reply-To: <14fbc8f0-b5dd-afd0-bd73-1592f6ee05ca@siemens.com> References: <14fbc8f0-b5dd-afd0-bd73-1592f6ee05ca@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: HiU0rmxt346T Good catch, but that and the other mknods makes we wonder why wo do not just bind-mount /dev. And while we are at it also /sys. /dev /proc and /sys are known to be usually required for a working system. Is there a reason to not just mount all three of them? Otherwise it seems like this patch is just another one in a long series of mknod patches. Henning Am Tue, 30 Jan 2018 10:31:21 +0100 schrieb "[ext] Jan Kiszka" : > From: Jan Kiszka > > ...or hell breaks loose, at least in the buildchroot: > > x86 kernel builds will generate strange modules.order/builtin files. > That's because drivers/firmware/Makefile does > $(call as-instr,.arch armv7-a\n.arch_extension sec,-DREQUIRES_SEC=1) > That tries the above assembly on the x86 gcc which will not understand > it and complain. It's output is directed to /dev/null, but that does > not exist, so it will be printed to the above modules.* files. Argh. > > Who knows what may happen in the image rootfs, so update it as well. > Which reminds us that this ugly duplication should be resolved ASAP. > > Signed-off-by: Jan Kiszka > --- > .../files/{download_dev-random => download_dev-nodes} | 7 > +++++++ meta-isar/recipes-core/images/isar-image-base.bb > | 4 ++-- meta/recipes-devtools/buildchroot/buildchroot.bb > | 4 ++-- .../recipes-devtools/buildchroot/files/download_dev-nodes > | 7 +++++++ > meta/recipes-devtools/buildchroot/files/download_dev-random | 13 > ------------- 5 files changed, 18 insertions(+), 17 deletions(-) copy > meta-isar/recipes-core/images/files/{download_dev-random => > download_dev-nodes} (73%) rename > meta-isar/recipes-core/images/files/download_dev-random => > meta/recipes-devtools/buildchroot/files/download_dev-nodes (73%) > delete mode 100644 > meta/recipes-devtools/buildchroot/files/download_dev-random > > diff --git a/meta-isar/recipes-core/images/files/download_dev-random > b/meta-isar/recipes-core/images/files/download_dev-nodes similarity > index 73% copy from > meta-isar/recipes-core/images/files/download_dev-random copy to > meta-isar/recipes-core/images/files/download_dev-nodes index > f7f5fe5..3149faa 100644 --- > a/meta-isar/recipes-core/images/files/download_dev-random +++ > b/meta-isar/recipes-core/images/files/download_dev-nodes @@ -7,6 > +7,13 @@ set -e > readonly ROOTFS="$1" > > +if [ ! -c ${ROOTFS}/dev/null ]; then > + rm -f ${ROOTFS}/dev/null > + mknod "${ROOTFS}/dev/null" c 1 3 > + chmod 666 "${ROOTFS}/dev/null" > + chown 0:0 "${ROOTFS}/dev/null" > +fi > + > if [ ! -c ${ROOTFS}/dev/random ]; then > rm -f ${ROOTFS}/dev/random > mknod "${ROOTFS}/dev/random" c 1 8 > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb > b/meta-isar/recipes-core/images/isar-image-base.bb index > 2f03cd1..3954697 100644 --- > a/meta-isar/recipes-core/images/isar-image-base.bb +++ > b/meta-isar/recipes-core/images/isar-image-base.bb @@ -12,7 +12,7 @@ > FILESPATH =. "${LAYERDIR_isar}/recipes-core/images/files:" SRC_URI = > "file://multistrap.conf.in \ file://${DISTRO_CONFIG_SCRIPT} \ > file://setup.sh \ > - file://download_dev-random" > + file://download_dev-nodes" > > PV = "1.0" > > @@ -38,7 +38,7 @@ do_rootfs() { > > chmod +x "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}" > chmod +x "${WORKDIR}/setup.sh" > - install -m 755 "${WORKDIR}/download_dev-random" > "${WORKDIR}/hooks_multistrap/" > + install -m 755 "${WORKDIR}/download_dev-nodes" > "${WORKDIR}/hooks_multistrap/" > # Multistrap accepts only relative path in configuration files, > so get it: cd ${TOPDIR} > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb > b/meta/recipes-devtools/buildchroot/buildchroot.bb index > 51f9d5d..8743a02 100644 --- > a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ > b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -12,7 +12,7 @@ > FILESPATH =. "${LAYERDIR_core}/recipes-devtools/buildchroot/files:" > SRC_URI = "file://multistrap.conf.in \ file://configscript.sh \ > file://setup.sh \ > - file://download_dev-random \ > + file://download_dev-nodes \ > file://build.sh" > PV = "1.0" > > @@ -39,7 +39,7 @@ do_build() { > > chmod +x "${WORKDIR}/setup.sh" > chmod +x "${WORKDIR}/configscript.sh" > - install -m 755 "${WORKDIR}/download_dev-random" > "${WORKDIR}/hooks_multistrap/" > + install -m 755 "${WORKDIR}/download_dev-nodes" > "${WORKDIR}/hooks_multistrap/" > # Multistrap accepts only relative path in configuration files, > so get it: cd ${TOPDIR} > diff --git a/meta-isar/recipes-core/images/files/download_dev-random > b/meta/recipes-devtools/buildchroot/files/download_dev-nodes > similarity index 73% rename from > meta-isar/recipes-core/images/files/download_dev-random rename to > meta/recipes-devtools/buildchroot/files/download_dev-nodes index > f7f5fe5..3149faa 100644 --- > a/meta-isar/recipes-core/images/files/download_dev-random +++ > b/meta/recipes-devtools/buildchroot/files/download_dev-nodes @@ -7,6 > +7,13 @@ set -e > readonly ROOTFS="$1" > > +if [ ! -c ${ROOTFS}/dev/null ]; then > + rm -f ${ROOTFS}/dev/null > + mknod "${ROOTFS}/dev/null" c 1 3 > + chmod 666 "${ROOTFS}/dev/null" > + chown 0:0 "${ROOTFS}/dev/null" > +fi > + > if [ ! -c ${ROOTFS}/dev/random ]; then > rm -f ${ROOTFS}/dev/random > mknod "${ROOTFS}/dev/random" c 1 8 > diff --git > a/meta/recipes-devtools/buildchroot/files/download_dev-random > b/meta/recipes-devtools/buildchroot/files/download_dev-random deleted > file mode 100644 index 5b5b96b..0000000 --- > a/meta/recipes-devtools/buildchroot/files/download_dev-random > +++ /dev/null @@ -1,13 +0,0 @@ > -#!/bin/sh > - > -set -e > - > -readonly ROOTFS="$1" > - > -mknod "${ROOTFS}/dev/random" c 1 8 > -chmod 640 "${ROOTFS}/dev/random" > -chown 0:0 "${ROOTFS}/dev/random" > - > -mknod "${ROOTFS}/dev/urandom" c 1 9 > -chmod 640 "${ROOTFS}/dev/urandom" > -chown 0:0 "${ROOTFS}/dev/urandom"