Re: [PATCH 0/9] first wic integration

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 31 Jan 2018 13:02:53 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> On 01/31/2018 12:41 PM, Henning Schild wrote:
> > This is the first official post of a series that aims to do two
> > things. 1. integrate wic into Isar so it does not need to be called
> > after bitbake
> > 2. get our copy of wic back to an unmodified version from OE
> > 
> > Many people have been asking for the first, so i think i do not
> > need to motivate that change. Things this series already brings is
> > control over the partition sizes, that we did not have before.
> > The choice in working wks files is still limited. The plugins
> > dealing with bootloaders (isolinux, syslinux etc.) will probably
> > need to be forked (like the efigrub one).
> > 
> > The second one is important so we can update wic in the future and
> > developers do not get confused. Having a fork instead of a copy,
> > without a very good reason, is not a good idea. I found that wic
> > does not need to be changed and plugins can be forked.
> >   
> 
> Are there any changes in user interface? Am I right that old commands 
> still work?

There are no changes. Calling wic manually as non-root does not work
anymore, but that might be unrelated. I think it was broken before. It
is a "du" failing with permission denied, see comment in
scripts/wic_fakeroot. If it did work before, i think it must have been
a hack in the wic-modifications. I also do not fully understand where
the fsck "fail" comes from, wic had modifications there as well.

If the manual non-root call did work before, i will look into that. Or
just change the docs that mention it.

We will need test coverage in CI, but as far as i can tell the whole
wic-side was not covered.

Henning

> Alex
> 
> > Henning
> > 
> > Henning Schild (9):
> >    classes: image: introduce size measuring function, for before
> >      do_*_image
> >    images: new class wic-img for wic intregration
> >    wic: add a bootimg-efi-isar plugin outside the wic tree
> >    Revert "wic: Make the bootimg-efi plugin generate usable images"
> >    Revert "wic: Introduce the `WicExecError` exception class"
> >    Revert "wic: Work around mcopy error"
> >    Revert "wic: Use sudo instead of pseudo"
> >    Revert "wic: Remove sysroot support"
> >    wic: now truly go for the wic version we claim to have
> > 
> >   .../scripts/lib/wic/canned-wks/sdimage-efi.wks     |   2 +-
> >   .../lib/wic/plugins/source/bootimg-efi-isar.py     | 307
> > +++++++++++++++++++++
> > meta/classes/ext4-img.bbclass                      |   7 +-
> > meta/classes/image.bbclass                         |  19 ++
> > meta/classes/wic-img.bbclass                       |  64 +++++
> > scripts/lib/wic/canned-wks/qemux86-directdisk.wks  |   2 +-
> > scripts/lib/wic/engine.py                          |   7 +-
> > scripts/lib/wic/filemap.py                         |   6 +-
> > scripts/lib/wic/help.py                            |   2 -
> > scripts/lib/wic/ksparser.py                        |   4 +-
> > scripts/lib/wic/partition.py                       | 197
> > ++++++++----- scripts/lib/wic/pluginbase.py                      |
> > 11 +- scripts/lib/wic/plugins/imager/direct.py           |  66
> > +++-- scripts/lib/wic/plugins/source/bootimg-efi.py      |  78
> > +----- .../lib/wic/plugins/source/bootimg-partition.py    |   6 +-
> > scripts/lib/wic/plugins/source/bootimg-pcbios.py   |  68 ++---
> > scripts/lib/wic/plugins/source/fsimage.py          |  56
> > ++++ .../lib/wic/plugins/source/isoimage-isohybrid.py   |  28 +-
> > scripts/lib/wic/plugins/source/rawcopy.py          |   2 +-
> > scripts/lib/wic/plugins/source/rootfs.py           |   4 +-
> > scripts/lib/wic/utils/misc.py                      |  33 +--
> > scripts/lib/wic/utils/runner.py                    |  74 ++++-
> > scripts/wic                                        |  27 +-
> > scripts/wic_fakeroot                               |  37 +++ 24
> > files changed, 846 insertions(+), 261 deletions(-) create mode
> > 100644 meta-isar/scripts/lib/wic/plugins/source/bootimg-efi-isar.py
> > create mode 100644 meta/classes/wic-img.bbclass create mode 100644
> > scripts/lib/wic/plugins/source/fsimage.py create mode 100755
> > scripts/wic_fakeroot 
>