From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6517147827419742208 X-Received: by 10.223.151.207 with SMTP id t15mr497701wrb.10.1517393575464; Wed, 31 Jan 2018 02:12:55 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.45.209 with SMTP id t200ls995250wmt.11.gmail; Wed, 31 Jan 2018 02:12:55 -0800 (PST) X-Google-Smtp-Source: AH8x226HAn5YgM9uy3mUxWs19qigzZ+5sJJqWaqMeh6u22k+xn4BcKZgnnu5LB6Lbp3zFbt74hBg X-Received: by 10.28.192.26 with SMTP id q26mr3384842wmf.29.1517393575053; Wed, 31 Jan 2018 02:12:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517393575; cv=none; d=google.com; s=arc-20160816; b=fmDQ4w+04aA6uzSPqmZ21u2IPn7UVn3eLLQ6RXcIQ7G1WHlaLBX0dZC/0nulXNGz7y 2pwj+GNyl8TVjuetTvxSUV6LxqIQfXN8e5AlEM17Nle19AZfE3AfJ8JyAGxW7Sf/Ple5 yUPckfhDQRtU3hsUM2PJ1WNWVk8JOiiNAo1yVAU6VeFa4DjdhS0sGFOXoPN1IraSmU+2 woz2h1ADQzZkM9b6UEkAs8gg8iv0bJFaNof8KREsEOlFgHuoQM+cDbd8CNcx+bAZkmsu roFicmKYIfSNzDpbpNQbgHjRlH3ioNOUQ21G8vtaSzEo4KJVC4C54K9iLhcLfRCEf9vT sQJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=pj4nXA2Y8BXcLFkPrIMV+moSeMQxKSIMcAdmpBsirTU=; b=UMBZ1jhf+MNX035uCC36HEDz1OvYJn90Yt2C0CVTNac/b/9Rj6crW45XpZyRiOHujf 9lD1y1p4mgstGggQCSThCy58MlJjnWLDmopbc7h9mVNRsc8gfl3RkppbXr0U0os02tZa vaqb4DfCYCQUS18LjZ/XIV9LFraZ0gpvBUPUZiZTV5ZcKygv0KPHyyVBdhU0qeIZ9rvl S0bsx62QXzNdZry3llijX+A5VAF+Y0SVrHndTSQKUDu0yyT/GqGIHoOmKo9Al8AWzmxz QdsLVI8LJ7A4FLbgPbq4df0QnerlKgVn3AIELiw/YeoGkzOSgm4kx9f2JUSf44Je+Yin 7vlw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id g70si369653wmc.3.2018.01.31.02.12.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 02:12:55 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w0VACs1D000789 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jan 2018 11:12:54 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w0VACsfd013064; Wed, 31 Jan 2018 11:12:54 +0100 Date: Wed, 31 Jan 2018 11:12:53 +0100 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 0/9] first wic integration Message-ID: <20180131111253.49011346@mmd1pvb1c.ad001.siemens.net> In-Reply-To: References: X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: qvp9eNarublm Am Wed, 31 Jan 2018 13:02:53 +0300 schrieb Alexander Smirnov : > On 01/31/2018 12:41 PM, Henning Schild wrote: > > This is the first official post of a series that aims to do two > > things. 1. integrate wic into Isar so it does not need to be called > > after bitbake > > 2. get our copy of wic back to an unmodified version from OE > > > > Many people have been asking for the first, so i think i do not > > need to motivate that change. Things this series already brings is > > control over the partition sizes, that we did not have before. > > The choice in working wks files is still limited. The plugins > > dealing with bootloaders (isolinux, syslinux etc.) will probably > > need to be forked (like the efigrub one). > > > > The second one is important so we can update wic in the future and > > developers do not get confused. Having a fork instead of a copy, > > without a very good reason, is not a good idea. I found that wic > > does not need to be changed and plugins can be forked. > > > > Are there any changes in user interface? Am I right that old commands > still work? There are no changes. Calling wic manually as non-root does not work anymore, but that might be unrelated. I think it was broken before. It is a "du" failing with permission denied, see comment in scripts/wic_fakeroot. If it did work before, i think it must have been a hack in the wic-modifications. I also do not fully understand where the fsck "fail" comes from, wic had modifications there as well. If the manual non-root call did work before, i will look into that. Or just change the docs that mention it. We will need test coverage in CI, but as far as i can tell the whole wic-side was not covered. Henning > Alex > > > Henning > > > > Henning Schild (9): > > classes: image: introduce size measuring function, for before > > do_*_image > > images: new class wic-img for wic intregration > > wic: add a bootimg-efi-isar plugin outside the wic tree > > Revert "wic: Make the bootimg-efi plugin generate usable images" > > Revert "wic: Introduce the `WicExecError` exception class" > > Revert "wic: Work around mcopy error" > > Revert "wic: Use sudo instead of pseudo" > > Revert "wic: Remove sysroot support" > > wic: now truly go for the wic version we claim to have > > > > .../scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +- > > .../lib/wic/plugins/source/bootimg-efi-isar.py | 307 > > +++++++++++++++++++++ > > meta/classes/ext4-img.bbclass | 7 +- > > meta/classes/image.bbclass | 19 ++ > > meta/classes/wic-img.bbclass | 64 +++++ > > scripts/lib/wic/canned-wks/qemux86-directdisk.wks | 2 +- > > scripts/lib/wic/engine.py | 7 +- > > scripts/lib/wic/filemap.py | 6 +- > > scripts/lib/wic/help.py | 2 - > > scripts/lib/wic/ksparser.py | 4 +- > > scripts/lib/wic/partition.py | 197 > > ++++++++----- scripts/lib/wic/pluginbase.py | > > 11 +- scripts/lib/wic/plugins/imager/direct.py | 66 > > +++-- scripts/lib/wic/plugins/source/bootimg-efi.py | 78 > > +----- .../lib/wic/plugins/source/bootimg-partition.py | 6 +- > > scripts/lib/wic/plugins/source/bootimg-pcbios.py | 68 ++--- > > scripts/lib/wic/plugins/source/fsimage.py | 56 > > ++++ .../lib/wic/plugins/source/isoimage-isohybrid.py | 28 +- > > scripts/lib/wic/plugins/source/rawcopy.py | 2 +- > > scripts/lib/wic/plugins/source/rootfs.py | 4 +- > > scripts/lib/wic/utils/misc.py | 33 +-- > > scripts/lib/wic/utils/runner.py | 74 ++++- > > scripts/wic | 27 +- > > scripts/wic_fakeroot | 37 +++ 24 > > files changed, 846 insertions(+), 261 deletions(-) create mode > > 100644 meta-isar/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > create mode 100644 meta/classes/wic-img.bbclass create mode 100644 > > scripts/lib/wic/plugins/source/fsimage.py create mode 100755 > > scripts/wic_fakeroot >