From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6517147827419742208 X-Received: by 10.25.156.145 with SMTP id f139mr2513466lfe.39.1517406812231; Wed, 31 Jan 2018 05:53:32 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.143.193 with SMTP id s62ls746942lfk.3.gmail; Wed, 31 Jan 2018 05:53:31 -0800 (PST) X-Google-Smtp-Source: AH8x2279GFcmWQdVyTgZMWwMz8D2VRBtoi4izhHyyaOi4U0IkzAHSRpl2PF9faphxuJWI+KYW0FG X-Received: by 10.46.7.17 with SMTP id 17mr2075798ljh.34.1517406811723; Wed, 31 Jan 2018 05:53:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517406811; cv=none; d=google.com; s=arc-20160816; b=s+xneZevuTQyJTmYNDUS9pG6w6C2sqdIMo51uqSTq1TDOEPknQItUaAZngR2e0eJi3 r+X2CibTh2G0+V6Ym2IhJd+whn7HnSb5WZTkz50u5nTciDx48nSpL7ya1OM2/MoFBprc aeNtWa9SwpowE+qSB76OIadegTEylVskfwaMnV0pnNJJIdi1K+gms7fSOGYoDyLpi0cm kdjs2DD05z7YWxgkpr6mBPEixMgR3nt5PKzye5MnafPFMw83DiUaiG/aGzDHmRJZkjjy o9Jh8H6DGkqNyElXLxlmaIf/PXAMiLz1q7ezVxHU1d48o7Ru8xU1TZJNUEdQMGCwMF8K 2/zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=5VCTkuRY83V2Lp8rTa/FxhX4UKia7ViTWbTj15ekXs8=; b=wrkMO7oADIdofeypFRDmiisNrAu2BTljeo6SJ3yedvSTxnqr4osssUx8dapyN5g6iN e1CrYqOk9cBBTKmRVX03K9trW3Sj+eO3zSNE8Z5zyUR8QPe/YQdWZOoV27oWDkuKi1jj CKMmYxLJnjqCkQMauH+8VL+5DXPe+Of41olSz26IZl8Z6AptyutoGLv84ga69Zmv155k Hchk8j3m38Vi4h8RSxADI/HyFKZcYAJGrwwfUwEcNO2PHD+wekjKPGpL1HhBTkhNWAMZ +2FvIraynksm8hRqFU6368KNBwopoFiKxtpr8lN6uclA4AJfywE+gXsRj3lSFkCaP+Qf CVXQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id l26si1619939lja.0.2018.01.31.05.53.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 05:53:31 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w0VDrVdO021782 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jan 2018 14:53:31 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w0VDrV5s025673; Wed, 31 Jan 2018 14:53:31 +0100 Date: Wed, 31 Jan 2018 14:53:30 +0100 From: Henning Schild To: Baurzhan Ismagulov Cc: Subject: Re: [PATCH 9/9] wic: now truly go for the wic version we claim to have Message-ID: <20180131145330.71603c10@mmd1pvb1c.ad001.siemens.net> In-Reply-To: <20180131122841.GD6508@yssyq.radix50.net> References: <540bb04ce24f67c121c83801288a3aea6f4cedac.1517390790.git.henning.schild@siemens.com> <9882db52-7c2e-d135-2ca5-13c5b9a722a7@siemens.com> <943545ea-d6a4-8fb0-2c95-3d62b1375ad6@siemens.com> <20180131115324.GB6508@yssyq.radix50.net> <20180131122841.GD6508@yssyq.radix50.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: G/1IwpXoIdBK Yes, after the reverts and this patch a diff of wic and lib/wic against the claimed OE version is empty. Henning Am Wed, 31 Jan 2018 13:28:42 +0100 schrieb Baurzhan Ismagulov : > On Wed, Jan 31, 2018 at 01:01:57PM +0100, Jan Kiszka wrote: > > To my reading, no changes are moved to lib. lib is restored to the > > OE hash the original isar commit only /claimed/ to have used. > > Now I see, thanks. I didn't understand that from the patch > description, what about the following: > > > Subject: [PATCH 9/9] wic: Fix wic import > > Commit 2b164b18fd639c9 claims to introduce wic hash 131629ca6238ea05, > but the former differs from the latter. This change fixes that import. > > Issue: > - the wic version in Isar was modified > - that causes: > - confusion, maintainability and updateability issues > - potential quality issues > > Impact: > This patch and the previous reverts get wic back to a state where all > these Issues are solved. We could now just update our wic without > having to worry about local patches. In case of a wic-update Isar and > layers on top would still have to review their plugins. > > Signed-off-by: Henning Schild > > > (I've added the word "commit" because this is what I usually look for > searching for changes fixing other commits). > > > > Maybe just a mistake in the log of that original commit. But then > > please enlighten us what hash was truly used and if that should > > stay in favor of this reset. > > I'm not aware of any other commit. If Henning's version works, I > don't see the point in redoing his work with a different upstream > commit. > > > With kind regards, > Baurzhan. >