From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6514905123003564032 X-Received: by 10.28.63.65 with SMTP id m62mr22862wma.18.1517867810626; Mon, 05 Feb 2018 13:56:50 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.152.10 with SMTP id v10ls2630847wrb.3.gmail; Mon, 05 Feb 2018 13:56:50 -0800 (PST) X-Google-Smtp-Source: AH8x2270ZgI4MB60w+z4Ix8GzxiDilniRmJEWYDJ0L0OsOF1k7uTSWmHPXNdv6OeXAPFMiWwfK1r X-Received: by 10.223.152.40 with SMTP id v37mr31051wrb.13.1517867810146; Mon, 05 Feb 2018 13:56:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517867810; cv=none; d=google.com; s=arc-20160816; b=Dt984XCfTnzcidDwwHRaUJARYtNvN/7qgdl+sunCKsrH0wT7RhW1HMdCXIQIf475aS dexSevQMwVZipIETgKoDMMN0xRbz6tcm05TWF0PB75K2WSTr9AEMmuqBGzc0JFKl9dZ6 U9tnNn6n7eFiIsCgemTy/pC2LhncKVD9hN9RIYi3ztWx0xNe7INHHFQ0GiLUkCz9IdlS W2Pk/wYz0qDfqmEJom35j4wT7I5LZZQOEte7uaBIaAkrPzCFl5X+uEEH7bT/FyWmyUgz 0cBKdOhc1RijY2O7DAkZaA9JFhdPivxGURTr5uBL29nnQfqDSmJDwKLe7VLAMFB619el TcTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date :arc-authentication-results; bh=EdhKb9vYphY9b9dGw9UcEIrsQRCHvwyhGmmFkKDbrVc=; b=HuFOnrVRb254+Jk8VnVvi9HcoxL3pALtt9pfwNxVwRlKqqRJqIX7Zi9OIPx/3FZPub /Dreo+B5TWAb4u56/1gx7D5vMTAWSjANkME1+IgL5pqv+Lry7v5eKcQ2cAH9QR+sh/QY tNi8tOlPNMRBKCc8gylz3QK4xGYMI1U0ukyRhvKayv6NZoj+9KB7dz5LDgvKfGLEBZtP L8SsnCOf1A+judxwypULWiuYA19MV4yj95+0DQRiBmJHsmdTUas7xl+OtXGMaIr3IqlS MT+RYJ67Db3p2k8HVHRCFXcqN6FSCumvNnv9SzU9JkicBoVFYumFBkGbNen6JS+ilViA AbHg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id a12si1228966wmg.4.2018.02.05.13.56.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 13:56:50 -0800 (PST) Received-SPF: neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.radix50.net (dslb-088-067-189-042.088.067.pools.vodafone-ip.de [88.67.189.42]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w15Lulxq026380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 5 Feb 2018 22:56:49 +0100 Received: from yssyq.radix50.net (localhost [127.0.0.1]) by yssyq.radix50.net (8.14.4/8.14.4/Debian-8) with ESMTP id w15LugUM024076 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 5 Feb 2018 22:56:42 +0100 Received: (from ibr@localhost) by yssyq.radix50.net (8.14.4/8.14.4/Submit) id w15LugvT024075 for isar-users@googlegroups.com; Mon, 5 Feb 2018 22:56:42 +0100 Date: Mon, 5 Feb 2018 22:56:42 +0100 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH 0/3] Implement hello <-> libhello pattern Message-ID: <20180205215642.GF6836@yssyq.radix50.net> Mail-Followup-To: isar-users@googlegroups.com References: <20180125083851.5887-1-asmirnov@ilbers.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180125083851.5887-1-asmirnov@ilbers.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-TUID: jy6/eibgEXwt On Thu, Jan 25, 2018 at 11:38:48AM +0300, Alexander Smirnov wrote: > This series intended to add Isar build dependencies between recipes. Some comments on the hello / libhello themselves. > [PATCH 1/2] Rename binary package to avoid correlations with Debian hello. > [PATCH 2/2] Add dependency from 'libhello'. Please remove the trailing dot from the subjects. > diff --git a/debian/changelog b/debian/changelog ... > +hello (0.2) unstable; urgency=low I'd suggest to tag: v0.1 7f35942 Add autotools v0.2 ffca497 Add dependency from 'libhello' Otherwise, Acked-by: Baurzhan Ismagulov . > [PATCH] libhello: First implementation > diff --git a/Makefile.am b/Makefile.am ... > +DB2MAN = docbook-to-man I think that should be in Build-Depends: (the same applies to hello). > +man1_MANS = hello.1 I suggest say_hello.3. > +clean-local: > + -$(RM) -f $(man1_MANS) I suggest removing the leading "-" (the same applies to hello; not sure why I used that at the time). > diff --git a/debian/.control.swp b/debian/.control.swp Please remove. > diff --git a/debian/changelog b/debian/changelog ... > +libhello (0.1) unstable; urgency=low Suggest to tag v0.1 1671f02 libhello: First implementation. > diff --git a/debian/control b/debian/control ... > +Build-Depends: debhelper (>= 9), autotools-dev Strictly speaking, autotools-dev is not needed. However, in that case the build may fail due to timestamp mess after a git checkout (if configure.ac happens to be newer than configure, the latter would try to rebuild itself). Depending on autotools-dev workarounds that for the same build suite, but not for a different one (configure generated on jessie would rebuild fine on jessie, but possibly not on other version, since exactly the same autotools versions are required). That led to the following hack: https://github.com/ilbers/isar/blob/2d56fc1242ef3e3041eb248942324eb67e9b1319/meta/recipes-devtools/buildchroot/files/build.sh#L17 I suggest: * Dropping the autotools-dev build-dependency. * Adding AM_MAINTAINER_MODE([disable]) to configure.ac to avoid rebuilding configure, Makefile.in, etc. For development, one may enable it with ./configure --enable-maintainer-mode. * Dropping the mentioned touch hack. That would apply also to hello. That is documented in: https://www.gnu.org/software/automake/manual/html_node/CVS.html#CVS https://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html#maintainer_002dmode > diff --git a/debian/copyright b/debian/copyright ... > +Copyright: 2016 ilbers GmbH 2018? > diff --git a/debian/menu b/debian/menu I don't think we need a GUI menu entry for libhello. Suggest dropping the file. > diff --git a/hello.h b/hello.h ... > +#ifndef __HELLO_H__ According to C99, identifiers that begin with an underscore are reserved (typically for compiler or OS use). Suggest HELLO_H. > diff --git a/hello.sgml b/hello.sgml ... > + HELLO > + 1 ... > + hello ... > + EXIT STATUS > + > + libhello always returns zero. Suggest providing info applicable for say_hello(3). As we have a backlog of patches and the issues are minor, feel free to create github bugs for issues that would take longer and mention them as # TODO: https://github.com/ilbers/isar/issues/NN in the code. With kind regards, Baurzhan.