Re: [PATCH v2][libhello] libhello: First implementation

[Baurzhan Ismagulov <ibr@radix50.net>]

On Thu, Feb 08, 2018 at 01:03:41PM +0300, Alexander Smirnov wrote:
> diff --git a/Makefile.am b/Makefile.am
...
> +man1_MANS = libhello.3
...
> +clean-local:
> +	$(RM) -f $(man1_MANS)

I'd suggest man3_MANS.


> diff --git a/debian/control b/debian/control
...
> +Build-Depends: debhelper (>= 9), autotools-dev, docbook-to-man

You've removed autotools-dev from hello, so I assume it works with Isar. Any
reason to keep it here?

I'd suggest dropping it from here and providing a patch removing the autotools
timestamp hack below. Could you please report whether that works? The last
time, ten attempts were enough to trigger the re-generation problem.

https://github.com/ilbers/isar/blob/2d56fc1242ef3e3041eb248942324eb67e9b1319/meta/recipes-devtools/buildchroot/files/build.sh#L17


> diff --git a/debian/libhello-dev.install b/debian/libhello-dev.install
...
> +usr/lib/*/libhello.a
> +usr/lib/*/libhello.la
...
> diff --git a/debian/libhello.install b/debian/libhello.install
...
> +usr/lib/*/libhello.so*

In which directory are those installed?


> diff --git a/libhello.sgml b/libhello.sgml
...
> +    <title>EXIT STATUS</title>

Suggest "RETURN VALUE".


Otherwise, Acked-by: Baurzhan Ismagulov <ibr@ilbers.de>.


With kind regards,
Baurzhan.