From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6520143438976909312 X-Received: by 10.25.150.9 with SMTP id y9mr292942lfd.7.1518200173858; Fri, 09 Feb 2018 10:16:13 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.16.106 with SMTP id f103ls834990lfi.9.gmail; Fri, 09 Feb 2018 10:16:13 -0800 (PST) X-Google-Smtp-Source: AH8x227MdAVoUw2HYqed4UWIrmQ9wK+SS68P5zF0gspxVtbYjVJmqfBgrp0x4UVne5wjKQkvcWW9 X-Received: by 10.25.18.85 with SMTP id h82mr297992lfi.4.1518200173130; Fri, 09 Feb 2018 10:16:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518200173; cv=none; d=google.com; s=arc-20160816; b=HAvDTAF4oo7L4atH37CwXDdZTHSM9me22VM85X/5dz2QNtahOnq6WAkgSvag/zg+pZ RpdVu9NbnQbBxQxTj1VsT76jHKqinLHp80fzsDziXX8osWOqiU+nW2bjQWeOj+AaABhM KWRVyt5liXLBHtMEFIK1nEFgUPWCrX64nzpkZglFwzooOShTAR7iOh2PItziodzo/sw+ 9ePrcMYkEv4EKKahkT6Fk6IAlIkOG0JDsQ3+2OxSzlkZQzdfVdA5LG8UtAVoLSnXgznk U0oMLtsoy6dskK/IXdZY00Zujrd1cOEBSIbtbxvRcwmbQfG3v8EAzZFBOMovMfUDyUn/ 2qMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=dC3fm9s5qDodNGfYiE+lDH5l0E8fIdydoxFLAqqwgZw=; b=dFMCMLhwD4ZXyqDHGdv3BDVg9WqhAlo8+ADpb3ViPpxAxMD5O0JgjZB0SmxZWasdLj TQPfFVyb1JH8cnHdTpbgy5RA5idwL/49ebfjckJUOCB2Scy+ar3dHzZNLuSo2io4U4oj 1aqq671pxK2n9IDonKqo4cKMRQsF6Nk4TnYi6SUkGifhVBlIxxbwF68L+0H4EvJuVe3N Dar8G/ZtKAyYhOVjg7qMAO2rz7vznnux1P9uzQ0SjBi27jTaNyPQRBGdeV1J0aFDrzXD 3q6is6QVCXZSjgGZf0KgPAPyM67Mjmurne4QZD+GwGFFkkPW4x3hPlYPwU9VxfNRcnyN kmDQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id w20si129232ljd.2.2018.02.09.10.16.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 10:16:13 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w19IGBd1024599 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Feb 2018 19:16:11 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w19IGBrU013487; Fri, 9 Feb 2018 19:16:11 +0100 Date: Fri, 9 Feb 2018 19:16:10 +0100 From: Henning Schild To: Alexander Smirnov Cc: , Claudius Heine Subject: Re: [PATCH v2] meta/classes/base: Fix showdata and liststasks after bitbake update Message-ID: <20180209191610.161916ad@mmd1pvb1c.ad001.siemens.net> In-Reply-To: <20180209172850.28852-1-asmirnov@ilbers.de> References: <20180209172850.28852-1-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: JKons1mQNC9q Mhh this one rings a bell ;) https://groups.google.com/d/msg/isar-users/Raq3ayrqtnc/oqTt6_sSBQAJ Someone has to reread that and check whether my symlink approach was rejected rightfully, or whether it was just one of the many misunderstandings we had in the past. Henning Am Fri, 9 Feb 2018 20:28:50 +0300 schrieb Alexander Smirnov : > From: Claudius Heine > > 8<-- > > Just added references to origin code in comment. Didn't touch the > code. > > 8<-- > > Those tasks were broken, this patchs fixes by implementing them > similar to how openembedded-core does it. > > Signed-off-by: Claudius Heine > --- > meta/classes/base.bbclass | 30 +++++++++++++++++++----------- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index 7d44f72..ae84677 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -37,25 +37,33 @@ bbfatal() { > exit 1 > } > > +# Derived from bitbake: bitbake/classes/base.bbclass > addtask showdata > do_showdata[nostamp] = "1" > python do_showdata() { > - import sys > - # emit variables and shell functions > - bb.data.emit_env(sys.__stdout__, d, True) > - # emit the metadata which isnt valid shell > - for e in bb.data.keys(d): > - if bb.data.getVarFlag(e, 'python', d): > - sys.__stdout__.write("\npython %s () > {\n%s}\n" % (e, bb.data.getVar(e, d, 1))) > + for e in d.keys(): > + if d.getVarFlag(e, 'python'): > + bb.plain("\npython %s () {\n%s}\n" % (e, d.getVar(e, > True))) } > > +# Derived from Open Embedded: > openembedded-core/meta/classes/utility-tasks.bbclass addtask listtasks > do_listtasks[nostamp] = "1" > python do_listtasks() { > - import sys > - for e in bb.data.keys(d): > - if bb.data.getVarFlag(e, 'task', d): > - sys.__stdout__.write("%s\n" % e) > + taskdescs = {} > + maxlen = 0 > + for e in d.keys(): > + if d.getVarFlag(e, 'task'): > + maxlen = max(maxlen, len(e)) > + if e.endswith('_setscene'): > + desc = "%s (setscene version)" % > (d.getVarFlag(e[:-9], 'doc') or '') > + else: > + desc = d.getVarFlag(e, 'doc') or '' > + taskdescs[e] = desc > + > + tasks = sorted(taskdescs.keys()) > + for taskname in tasks: > + bb.plain("%s %s" % (taskname.ljust(maxlen), > taskdescs[taskname])) } > > do_fetch[dirs] = "${DL_DIR}"