From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6520199916203016192 X-Received: by 10.25.123.3 with SMTP id w3mr309700lfc.41.1518203059138; Fri, 09 Feb 2018 11:04:19 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.80.30 with SMTP id e30ls844003lfb.10.gmail; Fri, 09 Feb 2018 11:04:18 -0800 (PST) X-Google-Smtp-Source: AH8x226dhRs4+/Kg7SVX8LQiymlh4DmAMb1cw99vKXXXpIr/+3bRPzf7rXatOtkj3kXeqQTtiMJ1 X-Received: by 10.25.44.7 with SMTP id s7mr309178lfs.20.1518203058518; Fri, 09 Feb 2018 11:04:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518203058; cv=none; d=google.com; s=arc-20160816; b=zMHm51Z0y3KVJTZIq5exUv0lUJqCfyxTTBY9DwxP2h0841VILnj46NWD1Wr4VROe/a 8aA37hLrZd7HoVNurvzKmfwa/MRmA5tfkLD4UMNW2Y0jtH0PqDkj72tdQFYG4E48vXY7 WIO+0tST6CsLRCRNCcK/f6QfDMUgF9dPjarM9MYKkFDpWv2cfWttnav+Fl8huzgiiu60 Sc5Jmk2eruSo3ruka/03FB5yGKBmHG8zfWkZmx+fTTnQ0DbpRc9DZws0m6wwpqA4i5+l R0JBiUSj1GoBl22PxpAt0DNa9GWKxFuMO4vC86V2Ubz/QNInTRDzPWGFzRX7qKoNG6fE zOWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=J98F2KYI6GwzDr3EiMc3FSRGfrEVqWR7tmVeqiE/e1I=; b=JC7/oHXbsqoj8r+VGmWr2v45gDx4xIXf/ARKEvv2fm2K112vbbgjrHkAUQpMtO2MzA CMCtw9UGmBNaQFLebKHI27rN4u8mbfNIOTG9wMnU3s8mgO7TtkeEPozOypbYR9o+qkpy DD50aYfcO2B/Khf2MQWnGkmbne2KDL1JuouxXV7hC/yZAR6MsfhPdFW/wY6Ck8qo4jOj /nfCIesJuwor9Hx6QV+CbtyYd18b1TeYqWSKXRNWVgxuWJM4Tgqh0za0puxIMyRYN9Pu 0Iz06Lc6GvycRxtzJoVBcL+wt/nhCJOZdL0QWJeiO7e97uzWzAYbEx5UGOx/C7E960S1 sQNw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id m2si179571lfj.2.2018.02.09.11.04.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 11:04:18 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w19J4HAR017027 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 9 Feb 2018 20:04:17 +0100 Received: from mmd1pvb1c.ad001.siemens.net ([167.87.31.179]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w19J4HaU024719; Fri, 9 Feb 2018 20:04:17 +0100 Date: Fri, 9 Feb 2018 20:04:15 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH v2 5/8] Provide include file for easy custom kernel builds Message-ID: <20180209200415.19dd80a4@mmd1pvb1c.ad001.siemens.net> In-Reply-To: References: <8ee0db162e27f31b64bc17eaf00d24f7b488806e.1518110579.git.jan.kiszka@siemens.com> <20180209183039.537f17d6@mmd1pvb1c.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 7xTG/54sfZyd Am Fri, 9 Feb 2018 18:54:12 +0100 schrieb Jan Kiszka : > On 2018-02-09 18:30, Henning Schild wrote: > > Am Thu, 8 Feb 2018 18:22:56 +0100 > > schrieb "[ext] Jan Kiszka" : > > > >> From: Jan Kiszka > >> > >> With this include file, it becomes almost trivial to replace the > >> distro kernel with a custom build. You just need to include > >> linux-custom.inc, specify the source URI, define via S where the > >> source is unpacked to and provide a defconfig. To switch to a > >> custom kernel recipe, PREFERRED_PROVIDER_virtual/kernel has to be > >> adjusted in local.conf or the distro conf. > >> > >> The approach works internally by first running "make deb-pkg" on > >> the kernel and the repackages the output to make the binary > >> linux-image and linux-header debs act as replacement of their > >> distro packages. This results in a suboptimal technical > >> implementation which may eventually be replaced by an > >> isar-implemented deb-pkg build process. However, this is not > >> expected to affect the user-visible interface of this include file. > >> > >> Signed-off-by: Jan Kiszka > >> --- > >> meta/recipes-kernel/linux/linux-custom.inc | 98 > >> ++++++++++++++++++++++++++++++ 1 file changed, 98 insertions(+) > >> create mode 100644 meta/recipes-kernel/linux/linux-custom.inc > >> > >> diff --git a/meta/recipes-kernel/linux/linux-custom.inc > >> b/meta/recipes-kernel/linux/linux-custom.inc new file mode 100644 > >> index 0000000..feb96a1 > >> --- /dev/null > >> +++ b/meta/recipes-kernel/linux/linux-custom.inc > >> @@ -0,0 +1,98 @@ > >> +# Custom kernel recipe include > >> +# > >> +# This software is a part of ISAR. > >> +# Copyright (c) Siemens AG, 2018 > >> +# > >> +# SPDX-License-Identifier: MIT > >> + > >> +DESCRIPTION ?= "Custom kernel" > >> +PROVIDES = "virtual/kernel" > >> + > >> +inherit dpkg-base > >> + > >> +KERNEL_DEBIAN_DEPENDS = "initramfs-tools | linux-initramfs-tool, > >> kmod, linux-base (>= 4.3~)" +KERNEL_HEADERS_DEBIAN_DEPENDS = > >> "libc6, libssl1.1, gcc" +KBUILD_DEPENDS = "libssl-dev libelf-dev > >> bc" > > > > These guys and the repacking are here because someone wrote a > > build-script that does not allow customization, how about not > > repeating that mistake and using "?=". > > As this is an include, you can already easily adjust after including. > Granted, defining those as default assignment would permit > project-wide overrides in local.conf & Co. OK, will send v3. Maybe i missed that so far, but could you explain why this is an include and not a bbclass. Not that i prefer one over the other but so far we do not seem to use .incs in Isar. Henning > Jan > > >> +REPACK_DIR = "${PP}/repack" > >> +REPACK_LINUX_IMAGE_DIR = "${REPACK_DIR}/linux-image" > >> +REPACK_LINUX_HEADERS_DIR = "${REPACK_DIR}/linux-headers" > >> + > >> +dpkg_runbuild() { > >> + E="${@ bb.utils.export_proxies(d)}" > >> + sudo -E chroot ${BUILDCHROOT_DIR} sh -c ' > >> + set -e > >> + > >> + apt-get install -y -o > >> Debug::pkgProblemResolver=yes \ > >> + --no-install-recommends ${KBUILD_DEPENDS} > >> + > >> + cd ${PP}/${S} > >> + cp ../defconfig .config > >> + make olddefconfig > >> + > >> + make -j ${@bb.utils.cpu_count() * 2} deb-pkg > >> + > >> + rm -rf ${REPACK_DIR} > >> + mkdir -p ${REPACK_DIR} > >> + mkdir -p ${REPACK_LINUX_IMAGE_DIR} > >> + mkdir -p ${REPACK_LINUX_HEADERS_DIR} > >> + > >> + cd ${PP} > >> + tar xzf linux-${PV}_${PV}-1.debian.tar.gz -C > >> ${REPACK_DIR} > >> + dpkg-deb -R > >> linux-image-${PV}_${PV}-1_${KERNEL_ARCH}.deb \ > >> + ${REPACK_LINUX_IMAGE_DIR} > >> + dpkg-deb -R > >> linux-headers-${PV}_${PV}-1_${KERNEL_ARCH}.deb \ > >> + ${REPACK_LINUX_HEADERS_DIR} > >> + > >> + dpkg-gencontrol -crepack/debian/control \ > >> + -lrepack/debian/changelog \ > >> + -frepack/debian/files \ > >> + -plinux-image-${PV} \ > >> + -P${REPACK_LINUX_IMAGE_DIR} \ > >> + -DPackage="linux-image-${KERNEL_ARCH}" \ > >> + -DSection=kernel \ > >> + -DPriority=required \ > >> + -DProvides="${PN}" \ > >> + -DDepends="${KERNEL_DEBIAN_DEPENDS}" > >> + > >> + # Add Debian-like link installation to postinst > >> + touch > >> ${REPACK_LINUX_IMAGE_DIR}/lib/modules/${PV}/.fresh-install > >> + sed -i ${REPACK_LINUX_IMAGE_DIR}/DEBIAN/postinst \ > >> + -e "/^set -e$/a\\ > >> +\\ > >> +if [ -f /lib/modules/${PV}/.fresh-install ]; then\\ > >> + change=install\\ > >> +else\\ > >> + change=upgrade\\ > >> +fi\\ > >> +linux-update-symlinks \$change ${PV} /boot/vmlinuz-${PV}\\ > >> +rm -f /lib/modules/${PV}/.fresh-install" > >> + > >> + # Add Debian-like link removal to postrm > >> + sed -i ${REPACK_LINUX_IMAGE_DIR}/DEBIAN/postrm \ > >> + -e "/^set -e$/a\\ > >> +\\ > >> +rm -f /lib/modules/${PV}/.fresh-install\\ > >> +\\ > >> +if [ \"\$1\" != upgrade ] && command -v linux-update-symlinks > >>> /dev/null; then\\ > >> + linux-update-symlinks remove ${PV} /boot/vmlinuz-${PV}\\ > >> +fi" > >> + > >> + dpkg-gencontrol -crepack/debian/control \ > >> + -lrepack/debian/changelog \ > >> + -frepack/debian/files \ > >> + -plinux-headers-${PV} \ > >> + -P${REPACK_LINUX_HEADERS_DIR} \ > >> + -Vkernel:debarch="${KERNEL_ARCH}" \ > >> + -DPackage="linux-headers-${KERNEL_ARCH}" \ > >> + -DSection=kernel \ > >> + -DDepends="${KERNEL_HEADERS_DEBIAN_DEPENDS}" > >> + > >> + dpkg-deb -b ${REPACK_LINUX_IMAGE_DIR} \ > >> + > >> linux-image-${KERNEL_ARCH}_${PV}-1_${KERNEL_ARCH}.deb > >> + rm -f linux-image-${PV}_${PV}-1_${KERNEL_ARCH}.deb > >> + dpkg-deb -b ${REPACK_LINUX_HEADERS_DIR} \ > >> + > >> linux-headers-${KERNEL_ARCH}_${PV}-1_${KERNEL_ARCH}.deb > >> + rm -f > >> linux-headers-${PV}_${PV}-1_${KERNEL_ARCH}.deb > >> + ' > >> +} > > > >