Re: [PATCH 2/2] centralize multistrap configuration generation

[Baurzhan Ismagulov <ibr@radix50.net>]

On Wed, Feb 14, 2018 at 02:15:09PM +0100, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> Previous there was redundant code between the buildchroot and
> isar-image-base recipe.
> 
> This patch moves the generation of the multistrap configuration to a
> central python script that can be parametrized by both recipes.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>  .../recipes-core/images/files/multistrap.conf.in   | 38 ----------
>  meta/lib/isar/multistrap.py                        | 80 ++++++++++++++++++++++
>  .../buildchroot/files/multistrap.conf.in           | 37 ----------

Could you please post two final multistrap.confs you'd like to get with your
changes?

I'd like to understand the reasons for moving from templates to a magic
generator.

In my experience, magic is usually poorly documented (if at all) and very
ununderstandable for users. Simple change of a line requires locating the
generator, understanding what it does (they tend to be hairy with tons of
conditions) and patching the upstream [Isar] code. Templates have their
disadvantages, but are straightforward for users. In general, I'd like to keep
the current UX and stick with templates, which is possible most of the time.

With kind regards,
Baurzhan.