From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6522397978051739648 X-Received: by 10.46.34.69 with SMTP id i66mr120541lji.10.1518694938093; Thu, 15 Feb 2018 03:42:18 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.46.12 with SMTP id u12ls2016342lju.4.gmail; Thu, 15 Feb 2018 03:42:17 -0800 (PST) X-Google-Smtp-Source: AH8x2278CJf9WENB46/z8iC99kkF866hOxM0ZdgNmoqip5/u6tM99TFbksMK6nAVDAj2zTq6wMls X-Received: by 10.46.19.26 with SMTP id 26mr128816ljt.6.1518694937512; Thu, 15 Feb 2018 03:42:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518694937; cv=none; d=google.com; s=arc-20160816; b=K0BO0XojBzJl1XSNGpAoyfp0xaSqLEuVE+oWAwNEiLJyIzKexKWN1eYJ3sYXS3LNuW G1owuEQi5LaHI7xljTgvi0sqCs4Fn8ECpMfD544jOfX5Q6NayZG9w8dtyNGrUaZL4anJ hiO7Np2Rwzyp9EwsvXdfCClEotNngCIePaBS76Wu3NXoF329NiC/InX0x3hTSWJfqycM G/uyrl4l1OLL806VuhuK70iwmQTDk03wFFFw0YqabYQJt/NIU+b9jrNn2xdukCtHkzQU e3N930/7/l7jKI2QB6TPolIS0mTqQFaKsI0IvyxRt7g4vK/WdI9kT1PwIMEsv8h5/V4e I1Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date :arc-authentication-results; bh=JHs6dToolCc51TLNKyZmO7FeWEMJWulAeKZz83Xxrd0=; b=BG0Yie3oYXumJW7WgLLmG8VoHA/ky1hO6NDZCI+ktfEg0kncDfca/rr/UJwxhUPpK+ m/JT4H+wfYCeJZtiDhbtllccZ3HTJ1jyxvw62F5fXKbw8j/90lnIky8LNSISeqn1waNp qbluHLPcCn3GvRpKt751dWOTWP5SzniVH11cZtWo4G3NCoqZjaT60b8gTunWQbwuBAOJ +Xw6AquVFoc1g+bIxKyf01sz2GA0KtlWpWRILoauDWsu/FDmzmRkfhXjLEGfhfKAiF3/ kbveDBaH4UWjB9OBHjseVMdkBCi+7YPhJrlJ9tDSASamfljN5DY9pDuhWNghZnGEX+ul INXw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id w7si388598ljw.4.2018.02.15.03.42.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 03:42:17 -0800 (PST) Received-SPF: neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.radix50.net (p2E51BAA3.dip0.t-ipconnect.de [46.81.186.163]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w1FBgENf014163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 15 Feb 2018 12:42:16 +0100 Received: from yssyq.radix50.net (localhost [127.0.0.1]) by yssyq.radix50.net (8.14.4/8.14.4/Debian-8) with ESMTP id w1FBgEvB008050 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 15 Feb 2018 12:42:14 +0100 Received: (from ibr@localhost) by yssyq.radix50.net (8.14.4/8.14.4/Submit) id w1FBgEsu008049 for isar-users@googlegroups.com; Thu, 15 Feb 2018 12:42:14 +0100 Date: Thu, 15 Feb 2018 12:42:14 +0100 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH 2/2] centralize multistrap configuration generation Message-ID: <20180215114214.GC5374@yssyq.radix50.net> Mail-Followup-To: isar-users@googlegroups.com References: <20180214131509.16361-1-claudius.heine.ext@siemens.com> <20180214131509.16361-3-claudius.heine.ext@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180214131509.16361-3-claudius.heine.ext@siemens.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TUID: D+nejcmUlP2L On Wed, Feb 14, 2018 at 02:15:09PM +0100, claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Previous there was redundant code between the buildchroot and > isar-image-base recipe. > > This patch moves the generation of the multistrap configuration to a > central python script that can be parametrized by both recipes. > > Signed-off-by: Claudius Heine > --- > .../recipes-core/images/files/multistrap.conf.in | 38 ---------- > meta/lib/isar/multistrap.py | 80 ++++++++++++++++++++++ > .../buildchroot/files/multistrap.conf.in | 37 ---------- Could you please post two final multistrap.confs you'd like to get with your changes? I'd like to understand the reasons for moving from templates to a magic generator. In my experience, magic is usually poorly documented (if at all) and very ununderstandable for users. Simple change of a line requires locating the generator, understanding what it does (they tend to be hairy with tons of conditions) and patching the upstream [Isar] code. Templates have their disadvantages, but are straightforward for users. In general, I'd like to keep the current UX and stick with templates, which is possible most of the time. With kind regards, Baurzhan.