public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Andreas Reichel <andreas.reichel.ext@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: Alexander Smirnov <asmirnov@ilbers.de>,
	Claudius Heine <claudius.heine.ext@siemens.com>,
	isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] dpkg-raw: Fix creation of DEBIAN folder
Date: Mon, 26 Feb 2018 13:27:15 +0100	[thread overview]
Message-ID: <20180226122715.GA32638@iiotirae> (raw)
In-Reply-To: <20180226113934.GA25174@iiotirae>

On Mon, Feb 26, 2018 at 12:39:34PM +0100, Andreas Reichel wrote:
> On Thu, Feb 15, 2018 at 11:53:39AM +0100, [ext] Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> 
Please ignore this report :) my do_install was wrong

> I just noticed, for me it tries to create a DEBIAN folder inside
> an "image" folder, that has root-only write permissions and thus
> fails since the function is executed as user "builder".
> 
> I reproduced this with a clean build and a dpkg-raw recipe.
> 
> No time to debug this atm.
> 
> > 
> > If do_install did not do this for us, we failed.
> > 
> > Fixes: b04530d19c79 (dpkg-raw: Clean DEBIAN dir prior to filling it)
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >  meta/classes/dpkg-raw.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass
> > index e0ea811..28233ac 100644
> > --- a/meta/classes/dpkg-raw.bbclass
> > +++ b/meta/classes/dpkg-raw.bbclass
> > @@ -18,7 +18,7 @@ addtask install after do_unpack before do_deb_package_prepare
> >  
> >  do_deb_package_prepare() {
> >  	sudo rm -rf ${D}/DEBIAN
> > -	mkdir ${D}/DEBIAN
> > +	mkdir -p ${D}/DEBIAN
> >  	cat<<-__EOF__ > ${D}/DEBIAN/control
> >  		Package: ${PN}
> >  		Architecture: ${DISTRO_ARCH}
> > -- 
> > 2.13.6
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "isar-users" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> > To post to this group, send email to isar-users@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/3ae97982-962e-be4d-22a6-477db2fad432%40siemens.com.
> > For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> Andreas Reichel
> Dipl.-Phys. (Univ.)
> Software Consultant
> 
> Andreas.Reichel@tngtech.com, +49-174-3180074
> TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
> Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
> Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082
> 

-- 
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082


  parent reply	other threads:[~2018-02-26 12:30 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 20:05 [PATCH v2 0/9] Add support for automatic partial rebuilds on recipe changes Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 1/9] dpkg-raw: Install hooks automatically Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 2/9] Fix indention of base_do_build Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 3/9] Add clean and cleanall tasks Jan Kiszka
2018-02-14 15:14   ` [PATCH v3 " Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 4/9] Enable recipe caching Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 5/9] Move buildchroot mounts into dpkg-base class Jan Kiszka
2018-02-13 20:17   ` Alexander Smirnov
2018-02-13 20:47     ` Jan Kiszka
2018-02-14  5:54       ` Alexander Smirnov
2018-02-14  8:37         ` Jan Kiszka
2018-02-14  8:52   ` [PATCH v3 " Jan Kiszka
2018-02-14  9:09     ` Alexander Smirnov
2018-02-14  9:16       ` Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 6/9] Enable proper rebuilds on dependency changes Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 7/9] dpkg-raw: Clean DEBIAN dir prior to filling it Jan Kiszka
2018-02-15  9:14   ` Claudius Heine
2018-02-15  9:18     ` Jan Kiszka
2018-02-15 10:26       ` Claudius Heine
2018-02-15 10:30         ` Alexander Smirnov
2018-02-15 10:53           ` [PATCH] dpkg-raw: Fix creation of DEBIAN folder Jan Kiszka
2018-02-15 15:39             ` Alexander Smirnov
2018-02-26 11:39             ` Andreas Reichel
2018-02-26 12:03               ` Jan Kiszka
2018-02-26 12:27               ` Andreas Reichel [this message]
2018-02-15 12:20           ` [PATCH v2 7/9] dpkg-raw: Clean DEBIAN dir prior to filling it Claudius Heine
2018-02-13 20:05 ` [PATCH v2 8/9] isar-image-base: Clean rootfs folder prior to building Jan Kiszka
2018-02-13 20:05 ` [PATCH v2 9/9] buildchroot: Clean up rootfs prior to populating it Jan Kiszka
2018-02-14 17:43   ` Alexander Smirnov
2018-02-14 17:48     ` Jan Kiszka
2018-02-14 11:33 ` [PATCH v2 0/9] Add support for automatic partial rebuilds on recipe changes Alexander Smirnov
2018-02-14 12:41   ` Jan Kiszka
2018-02-14 12:57     ` Alexander Smirnov
2018-02-14 13:10       ` Jan Kiszka
2018-02-14 13:29         ` Jan Kiszka
2018-02-14 13:38           ` Jan Kiszka
2018-02-14 13:49             ` Jan Kiszka
2018-02-14 14:06               ` Alexander Smirnov
2018-02-14 14:03             ` Alexander Smirnov
2018-02-14 14:10               ` Jan Kiszka
2018-02-14 17:51 ` Alexander Smirnov
2018-02-14 17:54   ` Jan Kiszka
2018-02-14 17:57     ` Alexander Smirnov
2018-02-14 18:02       ` Jan Kiszka
2018-02-14 18:34         ` Alexander Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226122715.GA32638@iiotirae \
    --to=andreas.reichel.ext@siemens.com \
    --cc=asmirnov@ilbers.de \
    --cc=claudius.heine.ext@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox